List comments

GET /api/patches/40709/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 82075,
        "web_url": "http://patches.dpdk.org/comment/82075/",
        "msgid": "<20180612061839.GA14136@debian>",
        "date": "2018-06-12T06:18:39",
        "subject": "Re: [dpdk-dev] [PATCH v3 2/5] net/virtio: use simple path for Tx\n\teven if Rx mergeable",
        "submitter": {
            "id": 617,
            "url": "http://patches.dpdk.org/api/people/617/",
            "name": "Tiwei Bie",
            "email": "tiwei.bie@intel.com"
        },
        "content": "On Thu, Jun 07, 2018 at 11:26:13AM +0200, Maxime Coquelin wrote:\n> Having Rx mergeable buffers feature enabled should not be\n> a reason to not use Tx simple path.\n> \n> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n\nReviewed-by: Tiwei Bie <tiwei.bie@intel.com>\n\n> ---\n>  drivers/net/virtio/virtio_ethdev.c | 4 +---\n>  1 file changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\n> index 052dd056a..c6087d9b1 100644\n> --- a/drivers/net/virtio/virtio_ethdev.c\n> +++ b/drivers/net/virtio/virtio_ethdev.c\n> @@ -1948,10 +1948,8 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n>  \t\thw->use_simple_tx = 0;\n>  \t}\n>  #endif\n> -\tif (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {\n> +\tif (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF))\n>  \t\thw->use_simple_rx = 0;\n> -\t\thw->use_simple_tx = 0;\n> -\t}\n>  \n>  \tif (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |\n>  \t\t\t   DEV_RX_OFFLOAD_TCP_CKSUM))\n> -- \n> 2.14.3\n>",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180607092616.27720-1-maxime.coquelin@redhat.com>\n\t<20180607092616.27720-3-maxime.coquelin@redhat.com>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": "E=Sophos;i=\"5.51,213,1526367600\"; d=\"scan'208\";a=\"63815035\"",
            "From": "Tiwei Bie <tiwei.bie@intel.com>",
            "User-Agent": "Mutt/1.9.5 (2018-04-13)",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=utf-8",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 43D611E8A0;\n\tTue, 12 Jun 2018 08:18:37 +0200 (CEST)",
                "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 731C11E89F\n\tfor <dev@dpdk.org>; Tue, 12 Jun 2018 08:18:35 +0200 (CEST)",
                "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jun 2018 23:18:33 -0700",
                "from debian.sh.intel.com (HELO debian) ([10.67.104.228])\n\tby orsmga001.jf.intel.com with ESMTP; 11 Jun 2018 23:18:32 -0700"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH v3 2/5] net/virtio: use simple path for Tx\n\teven if Rx mergeable",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-Amp-File-Uploaded": "False",
            "Message-ID": "<20180612061839.GA14136@debian>",
            "X-Amp-Original-Verdict": "FILE UNKNOWN",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Tue, 12 Jun 2018 14:18:39 +0800",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-ExtLoop1": "1",
            "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "zhihong.wang@intel.com, dev@dpdk.org",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Precedence": "list",
            "In-Reply-To": "<20180607092616.27720-3-maxime.coquelin@redhat.com>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "To": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "X-Amp-Result": "UNKNOWN",
            "Content-Disposition": "inline"
        }
    }
]