Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 40387,
    "url": "http://patches.dpdk.org/api/patches/40387/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180524130423.15554-1-zhiyong.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180524130423.15554-1-zhiyong.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180524130423.15554-1-zhiyong.yang@intel.com",
    "date": "2018-05-24T13:04:23",
    "name": "[dpdk-dev] net/virtio-user: fix add pointer checking for rxvq",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b6a59cdb52f914afaaa12286b9c22b3eb93c393b",
    "submitter": {
        "id": 540,
        "url": "http://patches.dpdk.org/api/people/540/?format=api",
        "name": "Yang, Zhiyong",
        "email": "zhiyong.yang@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180524130423.15554-1-zhiyong.yang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/40387/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/40387/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2DE402C6E;\n\tThu, 24 May 2018 07:29:04 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 7039B1B05;\n\tThu, 24 May 2018 07:29:02 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 May 2018 22:29:00 -0700",
            "from dpdk9.bj.intel.com ([172.16.182.183])\n\tby orsmga003.jf.intel.com with ESMTP; 23 May 2018 22:28:58 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.49,435,1520924400\"; d=\"scan'208\";a=\"53419711\"",
        "From": "zhiyong.yang@intel.com",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n\tlei.a.yao@intel.com, ferruh.yigit@intel.com,\n\tZhiyong Yang <zhiyong.yang@intel.com>",
        "Date": "Thu, 24 May 2018 21:04:23 +0800",
        "Message-Id": "<20180524130423.15554-1-zhiyong.yang@intel.com>",
        "X-Mailer": "git-send-email 2.14.3",
        "Subject": "[dpdk-dev] [PATCH] net/virtio-user: fix add pointer checking for\n\trxvq",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "For virtio-user server mode, One use case comes across segmentation fault.\nstep 1: Launch vhost side as client firstly.\nstep 2: launch virtio-user side as server.\n\nThe cause is: after registering virtio_interrupt_handler into\neal-intr-thread, two threads (main thread and eal-intr-thread) have\nsync issues, so add rxvq pointer checking in function virtio_notify_peers\nto decide if the code can continue.\n\nFixes: bd8f50a45d0f (\"net/virtio-user: support server mode\")\nCc: stable@dpdk.org\nCc: maxime.coquelin@redhat.com\nCc: tiwei.bie@intel.com\nCc: lei.a.yao@intel.com\nCc: ferruh.yigit@intel.com\n\nSigned-off-by: Zhiyong Yang <zhiyong.yang@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 5833dad73..df50a571a 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1245,6 +1245,9 @@ virtio_notify_peers(struct rte_eth_dev *dev)\n \t\treturn;\n \n \trxvq = dev->data->rx_queues[0];\n+\tif (!rxvq)\n+\t\treturn;\n+\n \trarp_mbuf = rte_net_make_rarp_packet(rxvq->mpool,\n \t\t\t(struct ether_addr *)hw->mac_addr);\n \tif (rarp_mbuf == NULL) {\n",
    "prefixes": [
        "dpdk-dev"
    ]
}