Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40281/?format=api
{ "id": 40281, "url": "http://patches.dpdk.org/api/patches/40281/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180521154829.6297-1-adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180521154829.6297-1-adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180521154829.6297-1-adrien.mazarguil@6wind.com", "date": "2018-05-21T15:50:09", "name": "[dpdk-dev,v2,1/2] net/mlx4: fix inadequate default in RSS converter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7eba2746aa3d259bd0f9ae8f705ec06ee4608643", "submitter": { "id": 165, "url": "http://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180521154829.6297-1-adrien.mazarguil@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/40281/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/40281/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D4EFC1B1EE;\n\tMon, 21 May 2018 17:50:26 +0200 (CEST)", "from mail-wr0-f194.google.com (mail-wr0-f194.google.com\n\t[209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 866031B1E6\n\tfor <dev@dpdk.org>; Mon, 21 May 2018 17:50:25 +0200 (CEST)", "by mail-wr0-f194.google.com with SMTP id i12-v6so3334179wrc.4\n\tfor <dev@dpdk.org>; Mon, 21 May 2018 08:50:25 -0700 (PDT)", "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t42-v6sm30841386wrx.24.2018.05.21.08.50.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 21 May 2018 08:50:24 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to;\n\tbh=l1m+UUuMNNht5ziig5yz2xx/W+ej83ZbebCOXZPrgZc=;\n\tb=tsqPND29rsVkwTPo42eUvrPpXgQlZsmj+hHq5NmeXu7B/zdsIeGO0XyoRqMdyMmJuk\n\tT/s38K1ptSFB+v8S5sqZOEsqhYs/TDaHwgUWuEEP3iGwUppEgMRot+5PHw2f7EFEievo\n\tafYMQp0oo4olRnoLZWrxm0i6UnMAIY1D0ybALRJL5ctdtRAurZYMcinb45xpJiEr6KT2\n\te9uuW3PbL3oyRHi+MLLfP0YCUjYTGhsS8UMHFcq2kqJris75QP+rZtH5QeLrXLQe4sYf\n\teWGtPcL0CkMT35Ao6/KvR6RDLn89gz6ZIPPbARG6sXgkvBZdmWLjAcRcp96pALA22s5a\n\tM7zw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to;\n\tbh=l1m+UUuMNNht5ziig5yz2xx/W+ej83ZbebCOXZPrgZc=;\n\tb=MRyjLzMWbDfrybpauDGL4CHr1xT+Xo2MtRSwBNZgt6l/66avos81kUamzvpmTdNxnR\n\tFgywCVJOMjwiWoSmygwWc+XBLsD4j1goqi6a6cecv6MdNpWSvUPX/7ggu18hqves0OEn\n\tHBquUc81Sp13JJwSNqiiAsEfjaaxgiBeR+u3dSaGX7Q7cYz5fdS1ngSDQ2L91kCKPFk0\n\teGQ4m5wjdH+QrTxx78Qac5nyS06q/Y2V8yxlPBXhu7Q+Jlvj/xORhP5mn3OLuMxPhN1w\n\t1XfZwI36AwV+ON6vp8eBISImcwE07L6nD6d6VE00/fM5NnUxD8cUPAkfv8ovRZKTb3K/\n\tN+uw==", "X-Gm-Message-State": "ALKqPwfKb6fNKYQSsVTFqQ9jsW69pMlr0YfyjftPolQQeGmwafFNadWo\n\tTdxSheyta51tQWYsjFWA/ojvHg==", "X-Google-Smtp-Source": "AB8JxZrbkH0HWY4JxKrDsPQfNni8Yvu7c8XKKqPX4UwozXnrtOC95b+DLWCrq81jE7Fm4K2s4aUgSA==", "X-Received": "by 2002:adf:adf0:: with SMTP id\n\tw103-v6mr17045448wrc.101.1526917825288; \n\tMon, 21 May 2018 08:50:25 -0700 (PDT)", "Date": "Mon, 21 May 2018 17:50:09 +0200", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "Shahaf Shuler <shahafs@mellanox.com>", "Cc": "dev@dpdk.org", "Message-ID": "<20180521154829.6297-1-adrien.mazarguil@6wind.com>", "References": "<20180515154853.6361-1-adrien.mazarguil@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20180515154853.6361-1-adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH v2 1/2] net/mlx4: fix inadequate default in RSS\n\tconverter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Below commit documents 0 as a value standing for a default set of RSS hash\ntypes, however the mlx4 PMD doesn't interpret it correctly and still uses\nits own internal special value for that (-1).\n\nAlso, its function prototype was not updated.\n\nFixes: ac8d22de2394 (\"ethdev: flatten RSS configuration in flow API\")\nFixes: 1d173da83ef2 (\"net/mlx4: fix default RSS hash fields\")\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n\n--\n\nThis is a rework of \"net/mlx4: fix useless default in RSS converter\" [1].\n\nNot a candidate for stable anymore since DPDK 18.02 does not include the\nflow API RSS rework.\n\n[1] http://dpdk.org/ml/archives/dev/2018-May/100285.html\n---\n drivers/net/mlx4/mlx4_flow.c | 6 +++---\n drivers/net/mlx4/mlx4_flow.h | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c\nindex 202779f7d..ebc9eeb8b 100644\n--- a/drivers/net/mlx4/mlx4_flow.c\n+++ b/drivers/net/mlx4/mlx4_flow.c\n@@ -114,7 +114,7 @@ struct mlx4_drop {\n * Convert DPDK RSS hash types to their Verbs equivalent.\n *\n * This function returns the supported (default) set when @p types has\n- * special value (uint64_t)-1.\n+ * special value 0.\n *\n * @param priv\n * Pointer to private structure.\n@@ -160,7 +160,7 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t types)\n \tuint64_t conv = 0;\n \tunsigned int i;\n \n-\tif (types == (uint64_t)-1)\n+\tif (!types)\n \t\treturn priv->hw_rss_sup;\n \tfor (i = 0; i != RTE_DIM(in); ++i)\n \t\tif (types & in[i]) {\n@@ -1384,7 +1384,7 @@ mlx4_flow_internal(struct priv *priv, struct rte_flow_error *error)\n \tstruct rte_flow_action_rss action_rss = {\n \t\t.func = RTE_ETH_HASH_FUNCTION_DEFAULT,\n \t\t.level = 0,\n-\t\t.types = -1,\n+\t\t.types = 0,\n \t\t.key_len = MLX4_RSS_HASH_KEY_SIZE,\n \t\t.queue_num = queues,\n \t\t.key = mlx4_rss_hash_key_default,\ndiff --git a/drivers/net/mlx4/mlx4_flow.h b/drivers/net/mlx4/mlx4_flow.h\nindex d1f1611eb..2e82903bd 100644\n--- a/drivers/net/mlx4/mlx4_flow.h\n+++ b/drivers/net/mlx4/mlx4_flow.h\n@@ -48,7 +48,7 @@ struct rte_flow {\n \n /* mlx4_flow.c */\n \n-uint64_t mlx4_conv_rss_types(struct priv *priv, uint64_t rss_hf);\n+uint64_t mlx4_conv_rss_types(struct priv *priv, uint64_t types);\n uint64_t mlx4_ibv_to_rss_types(uint64_t ibv_rss_types);\n int mlx4_flow_sync(struct priv *priv, struct rte_flow_error *error);\n void mlx4_flow_clean(struct priv *priv);\n", "prefixes": [ "dpdk-dev", "v2", "1/2" ] }