Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40133/?format=api
http://patches.dpdk.org/api/patches/40133/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180517073525.103984-1-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180517073525.103984-1-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180517073525.103984-1-xiao.w.wang@intel.com", "date": "2018-05-17T07:35:25", "name": "[dpdk-dev] net/virtio-user: fix dev_init in legacy-mem mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7cd9e6a7539aca4cfabd2e1e788dca85aba678c7", "submitter": { "id": 281, "url": "http://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180517073525.103984-1-xiao.w.wang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/40133/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/40133/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9BB0E4C7B;\n\tThu, 17 May 2018 09:37:40 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 892A14C79\n\tfor <dev@dpdk.org>; Thu, 17 May 2018 09:37:39 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 May 2018 00:37:38 -0700", "from dpdk-xiao-1.sh.intel.com ([10.67.111.90])\n\tby orsmga005.jf.intel.com with ESMTP; 17 May 2018 00:37:37 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,409,1520924400\"; d=\"scan'208\";a=\"224953169\"", "From": "Xiao Wang <xiao.w.wang@intel.com>", "To": "maxime.coquelin@redhat.com", "Cc": "dev@dpdk.org, tiwei.bie@intel.com, lei.a.yao@intel.com,\n\tXiao Wang <xiao.w.wang@intel.com>", "Date": "Thu, 17 May 2018 15:35:25 +0800", "Message-Id": "<20180517073525.103984-1-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 2.15.1", "Subject": "[dpdk-dev] [PATCH] net/virtio-user: fix dev_init in legacy-mem mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In legacy-mem mode, memory event callback registering is not supported,\nwe should not return error in dev_init on this case.\n\nFixes: 12ecb2f63b12 (\"net/virtio-user: support memory hotplug\")\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\nSuggested-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 992a68757..bd16fbb60 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -445,8 +445,11 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n \n \tif (rte_mem_event_callback_register(VIRTIO_USER_MEM_EVENT_CLB_NAME,\n \t\t\t\tvirtio_user_mem_event_cb, dev)) {\n-\t\tPMD_INIT_LOG(ERR, \"Failed to register mem event callback\\n\");\n-\t\treturn -1;\n+\t\tif (rte_errno != ENOTSUP) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to register mem event\"\n+\t\t\t\t\t\" callback\\n\");\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \n \treturn 0;\n", "prefixes": [ "dpdk-dev" ] }{ "id": 40133, "url": "