Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 39824,
    "url": "http://patches.dpdk.org/api/patches/39824/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180511105542.18395-1-tiwei.bie@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180511105542.18395-1-tiwei.bie@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180511105542.18395-1-tiwei.bie@intel.com",
    "date": "2018-05-11T10:55:42",
    "name": "[dpdk-dev] net/virtio-user: strip VIRTIO_NET_F_MAC when MAC isn't specified",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "793db9519ff70556ae066312cab02a1d26f2d9be",
    "submitter": {
        "id": 617,
        "url": "http://patches.dpdk.org/api/people/617/?format=api",
        "name": "Tiwei Bie",
        "email": "tiwei.bie@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180511105542.18395-1-tiwei.bie@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/39824/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/39824/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 64513CF68;\n\tFri, 11 May 2018 12:55:16 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 37EE17D00\n\tfor <dev@dpdk.org>; Fri, 11 May 2018 12:55:13 +0200 (CEST)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 May 2018 03:55:12 -0700",
            "from debian.sh.intel.com ([10.67.104.164])\n\tby fmsmga006.fm.intel.com with ESMTP; 11 May 2018 03:55:11 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.49,388,1520924400\"; d=\"scan'208\";a=\"227695736\"",
        "From": "Tiwei Bie <tiwei.bie@intel.com>",
        "To": "maxime.coquelin@redhat.com",
        "Cc": "dev@dpdk.org",
        "Date": "Fri, 11 May 2018 18:55:42 +0800",
        "Message-Id": "<20180511105542.18395-1-tiwei.bie@intel.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "Subject": "[dpdk-dev] [PATCH] net/virtio-user: strip VIRTIO_NET_F_MAC when MAC\n\tisn't specified",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Currently VIRTIO_NET_F_MAC is set unconditionally when server\nmode is used. It should be stripped when MAC isn't specified.\n\nFixes: bd8f50a45d0f (\"net/virtio-user: support server mode\")\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 38b8bc90d..d31f895f2 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -378,6 +378,8 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n \n \tif (dev->mac_specified)\n \t\tdev->device_features |= (1ull << VIRTIO_NET_F_MAC);\n+\telse\n+\t\tdev->device_features &= ~(1ull << VIRTIO_NET_F_MAC);\n \n \tif (cq) {\n \t\t/* device does not really need to know anything about CQ,\n",
    "prefixes": [
        "dpdk-dev"
    ]
}