Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/39578/?format=api
{ "id": 39578, "url": "http://patches.dpdk.org/api/patches/39578/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180509124552.22854-6-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180509124552.22854-6-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180509124552.22854-6-mk@semihalf.com", "date": "2018-05-09T12:45:50", "name": "[dpdk-dev,v1,06/24] net/ena: handle ENA notification", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "504a337f35a9dc0243da3cf8c5f3fe2f770b2bd8", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180509124552.22854-6-mk@semihalf.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/39578/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/39578/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 281FC1B419;\n\tWed, 9 May 2018 14:46:25 +0200 (CEST)", "from mail-lf0-f65.google.com (mail-lf0-f65.google.com\n\t[209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 333701B3F9\n\tfor <dev@dpdk.org>; Wed, 9 May 2018 14:46:16 +0200 (CEST)", "by mail-lf0-f65.google.com with SMTP id y72-v6so36997413lfd.2\n\tfor <dev@dpdk.org>; Wed, 09 May 2018 05:46:16 -0700 (PDT)", "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\ti6-v6sm5157497lji.49.2018.05.09.05.46.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 09 May 2018 05:46:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=gSYe3sqnjCJ3kEAv8HRI2wnRTXSw7HJWpmUIJksemDc=;\n\tb=xtkWmDX0I5atPvlZmZRCNvJ/NhKMx5FUZipIjCTF+gQuhsD4j9fxJ+7/MJqchDaJ4C\n\t0ObLxQ088kta1ufWoOrRb+ft/5yChN0/76ee+oW37tO9boX6TIDBqPlMgl/d81nrgcEk\n\td7lmsv4DQ5q5hvNMYFcFDbSdvyBl1TXytlTrOb8GZolSfFCpZAEYH3RIoZ60XV5lv/rG\n\tkOGm1+6JrhUOdfaB9xafd1P6qdi2emFX0Ea3LWnFnndLdRBuztHER1m03uYhI6m65AQm\n\tYyyPCREqfAQXlDTYMzeEzYZujk+fQHnA3+nprvek8V8TxjvkyRp/ghTbn8R8VeXD+7to\n\tSDcg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=gSYe3sqnjCJ3kEAv8HRI2wnRTXSw7HJWpmUIJksemDc=;\n\tb=QQBq295OPTh+8fBVeeVKlbwscxzKeIRNpUP0MOVjIL4nNd9lfnlou5QUJq2Sh2dzD3\n\tZOTrOU2Nz6MkPG8qdurPHaAQ/xX60+/7Li/rjilnFtQYjcn7ZZs7twcTJnJQTrohlwbz\n\tJWOI6YpJzUnIH0Num32rN8A8o4uMbsXsjb+EZQ/7NrhqU8vZcgLqUgBjYEIgZao16glO\n\tggiIFFecHgZRKZSe3p7Qy1e+jzqpo6glh2X/7YpeKbd7Fv7ZhbLCkRj/HNGDgjZXoI6A\n\tdGFFJuWir73SzZ+zroEXDgmnonYwHsBsi7R7em4MdVUNChTNZASxOafFtSyjQJUbYWY1\n\tBv0Q==", "X-Gm-Message-State": "ALKqPwclEkdFxO1glPv6s8KQIwnOL5J0TwacUvEcZPftyKmpSHwNkGxv\n\tSl85076lN3NdjDxRRvvx0KtHRw==", "X-Google-Smtp-Source": "AB8JxZpj7MW6pdvcH5fmqWRtOVKvpcXKt3FSG1FDQMDNRXDZ7YVibNUA80wlSfr8VePOKS8Ne1SqCw==", "X-Received": "by 2002:a19:3b86:: with SMTP id\n\td6-v6mr11202306lfl.95.1525869975795; \n\tWed, 09 May 2018 05:46:15 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,\n\tGuy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>", "Cc": "dev@dpdk.org,\n\tmatua@amazon.com,\n\tRafal Kozik <rk@semihalf.com>", "Date": "Wed, 9 May 2018 14:45:50 +0200", "Message-Id": "<20180509124552.22854-6-mk@semihalf.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180509124552.22854-1-mk@semihalf.com>", "References": "<20180509124552.22854-1-mk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v1 06/24] net/ena: handle ENA notification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rafal Kozik <rk@semihalf.com>\n\nWhen ENA notifications are provided ena_notification handler is called.\nIt checks if received value is not corrupted and if necessary it\nreports proper warnings.\n\nData received from NIC is parsed in ena_update_hints. Fields for\nstoring those information was added to ena_adapter structure.\n\nENA notification are enabled by setting ENA_ADMIN_NOTIFICATION flag in\naenq_groups.\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 41 +++++++++++++++++++++++++++++++++++++++--\n 1 file changed, 39 insertions(+), 2 deletions(-)\n\n--\n2.14.1", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex e9011e721..09a5ee6c8 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1305,7 +1305,8 @@ static int ena_device_init(struct ena_com_dev *ena_dev,\n \t\tgoto err_admin_init;\n \t}\n\n-\taenq_groups = BIT(ENA_ADMIN_LINK_CHANGE);\n+\taenq_groups = BIT(ENA_ADMIN_LINK_CHANGE) |\n+\t\t BIT(ENA_ADMIN_NOTIFICATION);\n\n \taenq_groups &= get_feat_ctx->aenq.supported_groups;\n \trc = ena_com_set_aenq_config(ena_dev, aenq_groups);\n@@ -1781,6 +1782,19 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \treturn i;\n }\n\n+static void ena_update_hints(struct ena_adapter *adapter,\n+\t\t\t struct ena_admin_ena_hw_hints *hints)\n+{\n+\tif (hints->admin_completion_tx_timeout)\n+\t\tadapter->ena_dev.admin_queue.completion_timeout =\n+\t\t\thints->admin_completion_tx_timeout * 1000;\n+\n+\tif (hints->mmio_read_timeout)\n+\t\t/* convert to usec */\n+\t\tadapter->ena_dev.mmio_read.reg_read_to =\n+\t\t\thints->mmio_read_timeout * 1000;\n+}\n+\n static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\t uint16_t nb_pkts)\n {\n@@ -1976,6 +1990,29 @@ static void ena_update_on_link_change(void *adapter_data,\n \t_rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL);\n }\n\n+static void ena_notification(void *data,\n+\t\t\t struct ena_admin_aenq_entry *aenq_e)\n+{\n+\tstruct ena_adapter *adapter = (struct ena_adapter *)data;\n+\tstruct ena_admin_ena_hw_hints *hints;\n+\n+\tif (aenq_e->aenq_common_desc.group != ENA_ADMIN_NOTIFICATION)\n+\t\tRTE_LOG(WARNING, PMD, \"Invalid group(%x) expected %x\\n\",\n+\t\t\taenq_e->aenq_common_desc.group,\n+\t\t\tENA_ADMIN_NOTIFICATION);\n+\n+\tswitch (aenq_e->aenq_common_desc.syndrom) {\n+\tcase ENA_ADMIN_UPDATE_HINTS:\n+\t\thints = (struct ena_admin_ena_hw_hints *)\n+\t\t\t(&aenq_e->inline_data_w4);\n+\t\tena_update_hints(adapter, hints);\n+\t\tbreak;\n+\tdefault:\n+\t\tRTE_LOG(ERR, PMD, \"Invalid aenq notification link state %d\\n\",\n+\t\t\taenq_e->aenq_common_desc.syndrom);\n+\t}\n+}\n+\n /**\n * This handler will called for unknown event group or unimplemented handlers\n **/\n@@ -1988,7 +2025,7 @@ static void unimplemented_aenq_handler(__rte_unused void *data,\n static struct ena_aenq_handlers aenq_handlers = {\n \t.handlers = {\n \t\t[ENA_ADMIN_LINK_CHANGE] = ena_update_on_link_change,\n-\t\t[ENA_ADMIN_NOTIFICATION] = unimplemented_aenq_handler,\n+\t\t[ENA_ADMIN_NOTIFICATION] = ena_notification,\n \t\t[ENA_ADMIN_KEEP_ALIVE] = unimplemented_aenq_handler\n \t},\n \t.unimplemented_handler = unimplemented_aenq_handler\n", "prefixes": [ "dpdk-dev", "v1", "06/24" ] }