Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 39564,
    "url": "http://patches.dpdk.org/api/patches/39564/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1525865729-16086-2-git-send-email-reshma.pattan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1525865729-16086-2-git-send-email-reshma.pattan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1525865729-16086-2-git-send-email-reshma.pattan@intel.com",
    "date": "2018-05-09T11:35:28",
    "name": "[dpdk-dev] examples/quota_watermark: fix gcc 8.0.1 cast between incompatible types",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d0467571188ad7a2b9013ac3594b10ca55939fcb",
    "submitter": {
        "id": 70,
        "url": "http://patches.dpdk.org/api/people/70/?format=api",
        "name": "Pattan, Reshma",
        "email": "reshma.pattan@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1525865729-16086-2-git-send-email-reshma.pattan@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/39564/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/39564/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C650D1B2A3;\n\tWed,  9 May 2018 13:35:39 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 7D2DD1B1CC;\n\tWed,  9 May 2018 13:35:36 +0200 (CEST)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 May 2018 04:35:35 -0700",
            "from sivswdev02.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.46])\n\tby orsmga006.jf.intel.com with ESMTP; 09 May 2018 04:35:34 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.49,381,1520924400\"; d=\"scan'208\";a=\"40432062\"",
        "From": "Reshma Pattan <reshma.pattan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org,\n\tReshma Pattan <reshma.pattan@intel.com>",
        "Date": "Wed,  9 May 2018 12:35:28 +0100",
        "Message-Id": "<1525865729-16086-2-git-send-email-reshma.pattan@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "In-Reply-To": "<1525865729-16086-1-git-send-email-reshma.pattan@intel.com>",
        "References": "<1525865729-16086-1-git-send-email-reshma.pattan@intel.com>",
        "Subject": "[dpdk-dev] [PATCH] examples/quota_watermark: fix gcc 8.0.1 cast\n\tbetween incompatible types",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Gcc 8.0.1 reports incompatible cast between types i.e. from\n`void (*)(void *)` to `(int (*)(void *)`.\n\nChange the pipeline_stage prototype to retun int type\nto fix the issue.\n\nFixes: a0ffcb257a (\"examples/quota_watermark: correct code indentation\")\nCC: stable@dpdk.org\n\nSigned-off-by: Reshma Pattan <reshma.pattan@intel.com>\n---\n examples/quota_watermark/qw/main.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/examples/quota_watermark/qw/main.c b/examples/quota_watermark/qw/main.c\nindex 313216f39..dda3e0a3e 100644\n--- a/examples/quota_watermark/qw/main.c\n+++ b/examples/quota_watermark/qw/main.c\n@@ -181,7 +181,7 @@ receive_stage(__attribute__((unused)) void *args)\n \t}\n }\n \n-static void\n+static int\n pipeline_stage(__attribute__((unused)) void *args)\n {\n \tint i, ret;\n@@ -243,9 +243,11 @@ pipeline_stage(__attribute__((unused)) void *args)\n \t\t\t}\n \t\t}\n \t}\n+\n+\treturn 0;\n }\n \n-static void\n+static int\n send_stage(__attribute__((unused)) void *args)\n {\n \tuint16_t nb_dq_pkts;\n@@ -287,6 +289,8 @@ send_stage(__attribute__((unused)) void *args)\n \t\t\t/* TODO: Check if nb_dq_pkts == nb_tx_pkts? */\n \t\t}\n \t}\n+\n+\treturn 0;\n }\n \n int\n@@ -347,7 +351,7 @@ main(int argc, char **argv)\n \t\t\t\t\tinit_ring(lcore_id, port_id);\n \n \t\t\t/* typecast is a workaround for GCC 4.3 bug */\n-\t\t\trte_eal_remote_launch((int (*)(void *))pipeline_stage,\n+\t\t\trte_eal_remote_launch(pipeline_stage,\n \t\t\t\t\tNULL, lcore_id);\n \t\t}\n \t}\n",
    "prefixes": [
        "dpdk-dev"
    ]
}