Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 3934,
    "url": "http://patches.dpdk.org/api/patches/3934/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1425896433-12452-2-git-send-email-vladz@cloudius-systems.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1425896433-12452-2-git-send-email-vladz@cloudius-systems.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1425896433-12452-2-git-send-email-vladz@cloudius-systems.com",
    "date": "2015-03-09T10:20:31",
    "name": "[dpdk-dev,v5,1/3] ixgbe: Cleanups",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e95b138e2e808fc656d2363beb0ad0b505a32801",
    "submitter": {
        "id": 141,
        "url": "http://patches.dpdk.org/api/people/141/?format=api",
        "name": "Vladislav Zolotarov",
        "email": "vladz@cloudius-systems.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1425896433-12452-2-git-send-email-vladz@cloudius-systems.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/3934/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/3934/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 795A69A91;\n\tMon,  9 Mar 2015 11:20:40 +0100 (CET)",
            "from mail-we0-f170.google.com (mail-we0-f170.google.com\n\t[74.125.82.170]) by dpdk.org (Postfix) with ESMTP id 36B5A5A9C\n\tfor <dev@dpdk.org>; Mon,  9 Mar 2015 11:20:38 +0100 (CET)",
            "by wevl61 with SMTP id l61so8058760wev.10\n\tfor <dev@dpdk.org>; Mon, 09 Mar 2015 03:20:38 -0700 (PDT)",
            "from vladz-laptop.localdomain ([109.65.117.109])\n\tby mx.google.com with ESMTPSA id\n\tmd2sm18728782wic.19.2015.03.09.03.20.36\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 09 Mar 2015 03:20:37 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=nFZOfS82JHyYcWcYBTc6Z9fvG2amIUDtlOoUQH6izhA=;\n\tb=eeZFoCw48fLop/F8HNyQC4qTxI95elFOZ1DdXOgDaIqkQtMmhSL/PQJf6UV5ijNbVN\n\t2807yiFRDcik8kQLkOkN4kCFi7Fbx+DcgSHra/xczLTIhdeO5Df1tULv/NgTtD/fdop6\n\t2GOTRaujm1evMRh0g3FqzVE+cnHzurqPXhsWAGim1tikOkfeW/O0DeLPlfhljUgPnosu\n\tfGwzWtoFZ8BfS00hQFH2HIhJ3P7z3/2x0lBvDTS955KU8Gn2Y2COlKMLA8jC6OPm0NHt\n\t7ts4tmfYocuHv6fz/FTw/Zll/H/0S88mZDigHkq1jdEv47Z/vmIxXUI1hdcz2rUzBKTT\n\tJf4Q==",
        "X-Gm-Message-State": "ALoCoQlI6TOgp7in4b7UbAcaoSzlwSNZQxZp1IVg5gYHodX1Obq5XWpZoH5KD/WU7PIykVbVHUGJ",
        "X-Received": "by 10.194.61.12 with SMTP id l12mr55947644wjr.139.1425896438002; \n\tMon, 09 Mar 2015 03:20:38 -0700 (PDT)",
        "From": "Vlad Zolotarov <vladz@cloudius-systems.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  9 Mar 2015 12:20:31 +0200",
        "Message-Id": "<1425896433-12452-2-git-send-email-vladz@cloudius-systems.com>",
        "X-Mailer": "git-send-email 2.1.0",
        "In-Reply-To": "<1425896433-12452-1-git-send-email-vladz@cloudius-systems.com>",
        "References": "<1425896433-12452-1-git-send-email-vladz@cloudius-systems.com>",
        "Subject": "[dpdk-dev]  [PATCH v5 1/3] ixgbe: Cleanups",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "- Removed the not needed casting.\n   - ixgbe_dev_rx_init(): shorten the lines by defining a local alias variable to access\n                          &dev->data->dev_conf.rxmode.\n\nSigned-off-by: Vlad Zolotarov <vladz@cloudius-systems.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 27 ++++++++++++---------------\n 1 file changed, 12 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex 72c65df..609b5fd 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -1032,8 +1032,7 @@ ixgbe_rx_alloc_bufs(struct igb_rx_queue *rxq)\n \tint diag, i;\n \n \t/* allocate buffers in bulk directly into the S/W ring */\n-\talloc_idx = (uint16_t)(rxq->rx_free_trigger -\n-\t\t\t\t(rxq->rx_free_thresh - 1));\n+\talloc_idx = rxq->rx_free_trigger - (rxq->rx_free_thresh - 1);\n \trxep = &rxq->sw_ring[alloc_idx];\n \tdiag = rte_mempool_get_bulk(rxq->mb_pool, (void *)rxep,\n \t\t\t\t    rxq->rx_free_thresh);\n@@ -1061,10 +1060,9 @@ ixgbe_rx_alloc_bufs(struct igb_rx_queue *rxq)\n \tIXGBE_PCI_REG_WRITE(rxq->rdt_reg_addr, rxq->rx_free_trigger);\n \n \t/* update state of internal queue structure */\n-\trxq->rx_free_trigger = (uint16_t)(rxq->rx_free_trigger +\n-\t\t\t\t\t\trxq->rx_free_thresh);\n+\trxq->rx_free_trigger = rxq->rx_free_trigger + rxq->rx_free_thresh;\n \tif (rxq->rx_free_trigger >= rxq->nb_rx_desc)\n-\t\trxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1);\n+\t\trxq->rx_free_trigger = rxq->rx_free_thresh - 1;\n \n \t/* no errors */\n \treturn 0;\n@@ -3560,6 +3558,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \tuint32_t rxcsum;\n \tuint16_t buf_size;\n \tuint16_t i;\n+\tstruct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode;\n \n \tPMD_INIT_FUNC_TRACE();\n \thw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -3582,7 +3581,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \t * Configure CRC stripping, if any.\n \t */\n \thlreg0 = IXGBE_READ_REG(hw, IXGBE_HLREG0);\n-\tif (dev->data->dev_conf.rxmode.hw_strip_crc)\n+\tif (rx_conf->hw_strip_crc)\n \t\thlreg0 |= IXGBE_HLREG0_RXCRCSTRP;\n \telse\n \t\thlreg0 &= ~IXGBE_HLREG0_RXCRCSTRP;\n@@ -3590,11 +3589,11 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \t/*\n \t * Configure jumbo frame support, if any.\n \t */\n-\tif (dev->data->dev_conf.rxmode.jumbo_frame == 1) {\n+\tif (rx_conf->jumbo_frame == 1) {\n \t\thlreg0 |= IXGBE_HLREG0_JUMBOEN;\n \t\tmaxfrs = IXGBE_READ_REG(hw, IXGBE_MAXFRS);\n \t\tmaxfrs &= 0x0000FFFF;\n-\t\tmaxfrs |= (dev->data->dev_conf.rxmode.max_rx_pkt_len << 16);\n+\t\tmaxfrs |= (rx_conf->max_rx_pkt_len << 16);\n \t\tIXGBE_WRITE_REG(hw, IXGBE_MAXFRS, maxfrs);\n \t} else\n \t\thlreg0 &= ~IXGBE_HLREG0_JUMBOEN;\n@@ -3618,9 +3617,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \t\t * Reset crc_len in case it was changed after queue setup by a\n \t\t * call to configure.\n \t\t */\n-\t\trxq->crc_len = (uint8_t)\n-\t\t\t\t((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0 :\n-\t\t\t\tETHER_CRC_LEN);\n+\t\trxq->crc_len = rx_conf->hw_strip_crc ? 0 : ETHER_CRC_LEN;\n \n \t\t/* Setup the Base and Length of the Rx Descriptor Rings */\n \t\tbus_addr = rxq->rx_ring_phys_addr;\n@@ -3638,7 +3635,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \t\t/*\n \t\t * Configure Header Split\n \t\t */\n-\t\tif (dev->data->dev_conf.rxmode.header_split) {\n+\t\tif (rx_conf->header_split) {\n \t\t\tif (hw->mac.type == ixgbe_mac_82599EB) {\n \t\t\t\t/* Must setup the PSRTYPE register */\n \t\t\t\tuint32_t psrtype;\n@@ -3648,7 +3645,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \t\t\t\t\tIXGBE_PSRTYPE_IPV6HDR;\n \t\t\t\tIXGBE_WRITE_REG(hw, IXGBE_PSRTYPE(rxq->reg_idx), psrtype);\n \t\t\t}\n-\t\t\tsrrctl = ((dev->data->dev_conf.rxmode.split_hdr_size <<\n+\t\t\tsrrctl = ((rx_conf->split_hdr_size <<\n \t\t\t\tIXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &\n \t\t\t\tIXGBE_SRRCTL_BSIZEHDR_MASK);\n \t\t\tsrrctl |= IXGBE_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;\n@@ -3699,7 +3696,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \t */\n \trxcsum = IXGBE_READ_REG(hw, IXGBE_RXCSUM);\n \trxcsum |= IXGBE_RXCSUM_PCSD;\n-\tif (dev->data->dev_conf.rxmode.hw_ip_checksum)\n+\tif (rx_conf->hw_ip_checksum)\n \t\trxcsum |= IXGBE_RXCSUM_IPPCSE;\n \telse\n \t\trxcsum &= ~IXGBE_RXCSUM_IPPCSE;\n@@ -3709,7 +3706,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)\n \tif (hw->mac.type == ixgbe_mac_82599EB ||\n \t    hw->mac.type == ixgbe_mac_X540) {\n \t\trdrxctl = IXGBE_READ_REG(hw, IXGBE_RDRXCTL);\n-\t\tif (dev->data->dev_conf.rxmode.hw_strip_crc)\n+\t\tif (rx_conf->hw_strip_crc)\n \t\t\trdrxctl |= IXGBE_RDRXCTL_CRCSTRIP;\n \t\telse\n \t\t\trdrxctl &= ~IXGBE_RDRXCTL_CRCSTRIP;\n",
    "prefixes": [
        "dpdk-dev",
        "v5",
        "1/3"
    ]
}