Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/39182/?format=api
{ "id": 39182, "url": "http://patches.dpdk.org/api/patches/39182/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1525126835-21775-1-git-send-email-llouis@vmware.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1525126835-21775-1-git-send-email-llouis@vmware.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1525126835-21775-1-git-send-email-llouis@vmware.com", "date": "2018-04-30T22:20:35", "name": "[dpdk-dev] net/vmxnet3: convert to new rx offload api", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2eb1338f726d4f6fca0d0ee79641c2a96bbe0a61", "submitter": { "id": 1025, "url": "http://patches.dpdk.org/api/people/1025/?format=api", "name": "Louis Luo", "email": "llouis@vmware.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1525126835-21775-1-git-send-email-llouis@vmware.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/39182/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/39182/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E7D41E5D;\n\tTue, 1 May 2018 00:20:56 +0200 (CEST)", "from EX13-EDG-OU-001.vmware.com (ex13-edg-ou-001.vmware.com\n\t[208.91.0.189]) by dpdk.org (Postfix) with ESMTP id E43DE23C\n\tfor <dev@dpdk.org>; Tue, 1 May 2018 00:20:54 +0200 (CEST)", "from sc9-mailhost2.vmware.com (10.113.161.72) by\n\tEX13-EDG-OU-001.vmware.com (10.113.208.155) with Microsoft SMTP\n\tServer id 15.0.1156.6; Mon, 30 Apr 2018 15:20:50 -0700", "from htb-1n-eng-dhcp179.eng.vmware.com\n\t(htb-1n-eng-dhcp179.prom.eng.vmware.com [10.33.75.71])\n\tby sc9-mailhost2.vmware.com (Postfix) with ESMTP id C2BF4B081B;\n\tMon, 30 Apr 2018 15:20:53 -0700 (PDT)" ], "From": "Louis Luo <llouis@vmware.com>", "To": "<yongwang@vmware.com>", "CC": "<dev@dpdk.org>, Louis Luo <llouis@vmware.com>", "Date": "Mon, 30 Apr 2018 15:20:35 -0700", "Message-ID": "<1525126835-21775-1-git-send-email-llouis@vmware.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain", "Received-SPF": "None (EX13-EDG-OU-001.vmware.com: llouis@vmware.com does not\n\tdesignate permitted sender hosts)", "Subject": "[dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Ethdev RX offloads API has changed since: commit ce17eddefc20\n(\"ethdev: introduce Rx queue offloads API\")\n\nThis patch adopts the new RX Offload API in vmxnet3 driver.\n\nSigned-off-by: Louis Luo <llouis@vmware.com>\n---\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 61 ++++++++++++++++++++++++++----------\n 1 file changed, 45 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 4568521..d9d5bda 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -42,6 +42,23 @@\n \n #define\tVMXNET3_TX_MAX_SEG\tUINT8_MAX\n \n+#define VMXNET3_TX_OFFLOAD_CAP\t\t\\\n+\t(DEV_TX_OFFLOAD_VLAN_INSERT |\t\\\n+\t DEV_TX_OFFLOAD_IPV4_CKSUM |\t\\\n+\t DEV_TX_OFFLOAD_TCP_CKSUM |\t\\\n+\t DEV_TX_OFFLOAD_UDP_CKSUM |\t\\\n+\t DEV_TX_OFFLOAD_TCP_TSO |\t\\\n+\t DEV_TX_OFFLOAD_MULTI_SEGS)\n+\n+#define VMXNET3_RX_OFFLOAD_CAP\t\t\\\n+\t(DEV_RX_OFFLOAD_VLAN_STRIP |\t\\\n+\t DEV_RX_OFFLOAD_SCATTER |\t\\\n+\t DEV_RX_OFFLOAD_IPV4_CKSUM |\t\\\n+\t DEV_RX_OFFLOAD_UDP_CKSUM |\t\\\n+\t DEV_RX_OFFLOAD_TCP_CKSUM |\t\\\n+\t DEV_RX_OFFLOAD_TCP_LRO |\t\\\n+\t DEV_RX_OFFLOAD_JUMBO_FRAME)\n+\n static int eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev);\n static int eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev);\n static int vmxnet3_dev_configure(struct rte_eth_dev *dev);\n@@ -376,9 +393,25 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)\n \tconst struct rte_memzone *mz;\n \tstruct vmxnet3_hw *hw = dev->data->dev_private;\n \tsize_t size;\n+\tuint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;\n+\tuint64_t tx_offloads = dev->data->dev_conf.txmode.offloads;\n \n \tPMD_INIT_FUNC_TRACE();\n \n+\tif ((rx_offloads & VMXNET3_RX_OFFLOAD_CAP) != rx_offloads) {\n+\t\tRTE_LOG(ERR, PMD, \"Requested RX offloads 0x%lx\"\n+\t\t\t\" do not match supported 0x%lx\\n\",\n+\t\t\trx_offloads, (uint64_t)VMXNET3_RX_OFFLOAD_CAP);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif ((tx_offloads & VMXNET3_TX_OFFLOAD_CAP) != tx_offloads) {\n+\t\tRTE_LOG(ERR, PMD, \"Requested TX offloads 0x%lx\"\n+\t\t\t\" do not match supported 0x%lx\\n\",\n+\t\t\ttx_offloads, (uint64_t)VMXNET3_TX_OFFLOAD_CAP);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n \tif (dev->data->nb_tx_queues > VMXNET3_MAX_TX_QUEUES ||\n \t dev->data->nb_rx_queues > VMXNET3_MAX_RX_QUEUES) {\n \t\tPMD_INIT_LOG(ERR, \"ERROR: Number of queues not supported\");\n@@ -567,6 +600,7 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)\n \tuint32_t mtu = dev->data->mtu;\n \tVmxnet3_DriverShared *shared = hw->shared;\n \tVmxnet3_DSDevRead *devRead = &shared->devRead;\n+\tuint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;\n \tuint32_t i;\n \tint ret;\n \n@@ -644,10 +678,10 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)\n \tdevRead->rxFilterConf.rxMode = 0;\n \n \t/* Setting up feature flags */\n-\tif (dev->data->dev_conf.rxmode.hw_ip_checksum)\n+\tif (rx_offloads & DEV_RX_OFFLOAD_CHECKSUM)\n \t\tdevRead->misc.uptFeatures |= VMXNET3_F_RXCSUM;\n \n-\tif (dev->data->dev_conf.rxmode.enable_lro) {\n+\tif (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO) {\n \t\tdevRead->misc.uptFeatures |= VMXNET3_F_LRO;\n \t\tdevRead->misc.maxNumRxSG = 0;\n \t}\n@@ -1050,17 +1084,10 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev __rte_unused,\n \t\t.nb_mtu_seg_max = VMXNET3_MAX_TXD_PER_PKT,\n \t};\n \n-\tdev_info->rx_offload_capa =\n-\t\tDEV_RX_OFFLOAD_VLAN_STRIP |\n-\t\tDEV_RX_OFFLOAD_UDP_CKSUM |\n-\t\tDEV_RX_OFFLOAD_TCP_CKSUM |\n-\t\tDEV_RX_OFFLOAD_TCP_LRO;\n-\n-\tdev_info->tx_offload_capa =\n-\t\tDEV_TX_OFFLOAD_VLAN_INSERT |\n-\t\tDEV_TX_OFFLOAD_TCP_CKSUM |\n-\t\tDEV_TX_OFFLOAD_UDP_CKSUM |\n-\t\tDEV_TX_OFFLOAD_TCP_TSO;\n+\tdev_info->rx_offload_capa = VMXNET3_RX_OFFLOAD_CAP;\n+\tdev_info->rx_queue_offload_capa = 0;\n+\tdev_info->tx_offload_capa = VMXNET3_TX_OFFLOAD_CAP;\n+\tdev_info->tx_queue_offload_capa = 0;\n }\n \n static const uint32_t *\n@@ -1154,8 +1181,9 @@ vmxnet3_dev_promiscuous_disable(struct rte_eth_dev *dev)\n {\n \tstruct vmxnet3_hw *hw = dev->data->dev_private;\n \tuint32_t *vf_table = hw->shared->devRead.rxFilterConf.vfTable;\n+\tuint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;\n \n-\tif (dev->data->dev_conf.rxmode.hw_vlan_filter)\n+\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n \t\tmemcpy(vf_table, hw->shadow_vfta, VMXNET3_VFT_TABLE_SIZE);\n \telse\n \t\tmemset(vf_table, 0xff, VMXNET3_VFT_TABLE_SIZE);\n@@ -1217,9 +1245,10 @@ vmxnet3_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \tstruct vmxnet3_hw *hw = dev->data->dev_private;\n \tVmxnet3_DSDevRead *devRead = &hw->shared->devRead;\n \tuint32_t *vf_table = devRead->rxFilterConf.vfTable;\n+\tuint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;\n \n \tif (mask & ETH_VLAN_STRIP_MASK) {\n-\t\tif (dev->data->dev_conf.rxmode.hw_vlan_strip)\n+\t\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)\n \t\t\tdevRead->misc.uptFeatures |= UPT1_F_RXVLAN;\n \t\telse\n \t\t\tdevRead->misc.uptFeatures &= ~UPT1_F_RXVLAN;\n@@ -1229,7 +1258,7 @@ vmxnet3_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \t}\n \n \tif (mask & ETH_VLAN_FILTER_MASK) {\n-\t\tif (dev->data->dev_conf.rxmode.hw_vlan_filter)\n+\t\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n \t\t\tmemcpy(vf_table, hw->shadow_vfta, VMXNET3_VFT_TABLE_SIZE);\n \t\telse\n \t\t\tmemset(vf_table, 0xff, VMXNET3_VFT_TABLE_SIZE);\n", "prefixes": [ "dpdk-dev" ] }