Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3914/?format=api
{ "id": 3914, "url": "http://patches.dpdk.org/api/patches/3914/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1425657587-23516-1-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1425657587-23516-1-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1425657587-23516-1-git-send-email-konstantin.ananyev@intel.com", "date": "2015-03-06T15:59:47", "name": "[dpdk-dev,PATCHv2] headers: typeof -> __typeof__ to unbreak C++11 code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "60a36be6962afa27a79de957d1171218afb21605", "submitter": { "id": 33, "url": "http://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1425657587-23516-1-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/3914/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/3914/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4A40011C5;\n\tFri, 6 Mar 2015 17:00:15 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id D13BB11A2\n\tfor <dev@dpdk.org>; Fri, 6 Mar 2015 17:00:13 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga103.fm.intel.com with ESMTP; 06 Mar 2015 07:54:57 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 06 Mar 2015 08:00:04 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt26G048s023118; Fri, 6 Mar 2015 16:00:04 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t26G03oY023731;\n\tFri, 6 Mar 2015 16:00:03 GMT", "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with id t26G032K023727;\n\tFri, 6 Mar 2015 16:00:03 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,353,1422950400\"; d=\"scan'208\";a=\"661490744\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 6 Mar 2015 15:59:47 +0000", "Message-Id": "<1425657587-23516-1-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": [ "<20150225142851.55406347@miho>", "<20150225142851.55406347@miho>" ], "References": [ "<20150225142851.55406347@miho>", "<20150225142851.55406347@miho>" ], "Subject": "[dpdk-dev] [PATCHv2] headers: typeof -> __typeof__ to unbreak C++11\n\tcode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "v2:\nInstead of changing all the affected files,\ndefine 'typeofi' and 'asm' if needed.\n\nWhen compiling C++11-code or above (--std=c++11), the build fails with\nlots of\n\n rte_eth_ctrl.h:517:3: note: in expansion of macro RTE_ALIGN\n (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT32_BIT)/UINT32_BIT)\n ^\n\nWhen reading the GCC info pages, I get the feeling that __typeof__ is\na better choice, and that indeed works when including the headers in\nC++ files (--std=c++11).\n\nThere are some typeof()s left in C files, the patch only touches the\npublic API.\n\nSigned-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_eal/common/include/rte_common.h | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h\nindex 8ac940c..1867692 100644\n--- a/lib/librte_eal/common/include/rte_common.h\n+++ b/lib/librte_eal/common/include/rte_common.h\n@@ -51,6 +51,15 @@ extern \"C\" {\n #include <errno.h>\n #include <limits.h>\n \n+#ifndef typeof\n+#define typeof __typeof__\n+#endif\n+\n+#ifndef asm\n+#define asm __asm__\n+#endif\n+\n+\n /*********** Macros to eliminate unused variable warnings ********/\n \n /**\n", "prefixes": [ "dpdk-dev", "PATCHv2" ] }