Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/390/?format=api
{ "id": 390, "url": "http://patches.dpdk.org/api/patches/390/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1410940461-17509-2-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1410940461-17509-2-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1410940461-17509-2-git-send-email-helin.zhang@intel.com", "date": "2014-09-17T07:54:19", "name": "[dpdk-dev,1/3] i40e: renaming some local variables", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8131baf170e34f36fe46cbabe924bd15817cc58c", "submitter": { "id": 14, "url": "http://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1410940461-17509-2-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/390/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/390/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 95599AFD1;\n\tWed, 17 Sep 2014 09:48:59 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 266D1AFD1\n\tfor <dev@dpdk.org>; Wed, 17 Sep 2014 09:48:57 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 17 Sep 2014 00:45:38 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 17 Sep 2014 00:54:28 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id s8H7sQ4k024656;\n\tWed, 17 Sep 2014 15:54:26 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s8H7sOKK017552; Wed, 17 Sep 2014 15:54:26 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s8H7sOWc017548; \n\tWed, 17 Sep 2014 15:54:24 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,539,1406617200\"; d=\"scan'208\";a=\"592481929\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 17 Sep 2014 15:54:19 +0800", "Message-Id": "<1410940461-17509-2-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1410940461-17509-1-git-send-email-helin.zhang@intel.com>", "References": "<1410940461-17509-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/3] i40e: renaming some local variables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To be more straightforward, two local variables in interrupt\nhandler are renamed.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nReviewed-by: Jing Chen <jing.d.chen@intel.com>\nReviewed-by: Jijiang Liu <jijiang.liu@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 26 +++++++++++++-------------\n 1 file changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex 4e65ca4..003b084 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -3391,53 +3391,53 @@ i40e_dev_interrupt_handler(__rte_unused struct rte_intr_handle *handle,\n {\n \tstruct rte_eth_dev *dev = (struct rte_eth_dev *)param;\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tuint32_t cause, enable;\n+\tuint32_t icr0, icr0_ena;\n \n \ti40e_pf_disable_irq0(hw);\n \n-\tcause = I40E_READ_REG(hw, I40E_PFINT_ICR0);\n-\tenable = I40E_READ_REG(hw, I40E_PFINT_ICR0_ENA);\n+\ticr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);\n+\ticr0_ena = I40E_READ_REG(hw, I40E_PFINT_ICR0_ENA);\n \n \t/* Shared IRQ case, return */\n-\tif (!(cause & I40E_PFINT_ICR0_INTEVENT_MASK)) {\n+\tif (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK)) {\n \t\tPMD_DRV_LOG(INFO, \"Port%d INT0:share IRQ case, \"\n \t\t\t\"no INT event to process\\n\", hw->pf_id);\n \t\tgoto done;\n \t}\n \n-\tif (cause & I40E_PFINT_ICR0_LINK_STAT_CHANGE_MASK) {\n+\tif (icr0 & I40E_PFINT_ICR0_LINK_STAT_CHANGE_MASK) {\n \t\tPMD_DRV_LOG(INFO, \"INT:Link status changed\\n\");\n \t\ti40e_dev_link_update(dev, 0);\n \t}\n \n-\tif (cause & I40E_PFINT_ICR0_ECC_ERR_MASK)\n+\tif (icr0 & I40E_PFINT_ICR0_ECC_ERR_MASK)\n \t\tPMD_DRV_LOG(INFO, \"INT:Unrecoverable ECC Error\\n\");\n \n-\tif (cause & I40E_PFINT_ICR0_MAL_DETECT_MASK)\n+\tif (icr0 & I40E_PFINT_ICR0_MAL_DETECT_MASK)\n \t\tPMD_DRV_LOG(INFO, \"INT:Malicious programming detected\\n\");\n \n-\tif (cause & I40E_PFINT_ICR0_GRST_MASK)\n+\tif (icr0 & I40E_PFINT_ICR0_GRST_MASK)\n \t\tPMD_DRV_LOG(INFO, \"INT:Global Resets Requested\\n\");\n \n-\tif (cause & I40E_PFINT_ICR0_PCI_EXCEPTION_MASK)\n+\tif (icr0 & I40E_PFINT_ICR0_PCI_EXCEPTION_MASK)\n \t\tPMD_DRV_LOG(INFO, \"INT:PCI EXCEPTION occured\\n\");\n \n-\tif (cause & I40E_PFINT_ICR0_HMC_ERR_MASK)\n+\tif (icr0 & I40E_PFINT_ICR0_HMC_ERR_MASK)\n \t\tPMD_DRV_LOG(INFO, \"INT:HMC error occured\\n\");\n \n \t/* Add processing func to deal with VF reset vent */\n-\tif (cause & I40E_PFINT_ICR0_VFLR_MASK) {\n+\tif (icr0 & I40E_PFINT_ICR0_VFLR_MASK) {\n \t\tPMD_DRV_LOG(INFO, \"INT:VF reset detected\\n\");\n \t\ti40e_dev_handle_vfr_event(dev);\n \t}\n \t/* Find admin queue event */\n-\tif (cause & I40E_PFINT_ICR0_ADMINQ_MASK) {\n+\tif (icr0 & I40E_PFINT_ICR0_ADMINQ_MASK) {\n \t\tPMD_DRV_LOG(INFO, \"INT:ADMINQ event\\n\");\n \t\ti40e_dev_handle_aq_msg(dev);\n \t}\n \n done:\n-\tI40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA, enable);\n+\tI40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA, icr0_ena);\n \t/* Re-enable interrupt from device side */\n \ti40e_pf_enable_irq0(hw);\n \t/* Re-enable interrupt from host side */\n", "prefixes": [ "dpdk-dev", "1/3" ] }