Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 38953,
    "url": "http://patches.dpdk.org/api/patches/38953/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180425155646.3627-8-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180425155646.3627-8-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180425155646.3627-8-stephen@networkplumber.org",
    "date": "2018-04-25T15:56:43",
    "name": "[dpdk-dev,next,07/10] net/kni: support dynamic logging",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "e4373056bd5ec9bfefa990b217c8e14e2ff399b0",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180425155646.3627-8-stephen@networkplumber.org/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/38953/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/38953/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F237A568;\n\tWed, 25 Apr 2018 17:57:15 +0200 (CEST)",
            "from mail-pg0-f68.google.com (mail-pg0-f68.google.com\n\t[74.125.83.68]) by dpdk.org (Postfix) with ESMTP id C0A6D8E63\n\tfor <dev@dpdk.org>; Wed, 25 Apr 2018 17:56:59 +0200 (CEST)",
            "by mail-pg0-f68.google.com with SMTP id e12so13635059pgn.9\n\tfor <dev@dpdk.org>; Wed, 25 Apr 2018 08:56:59 -0700 (PDT)",
            "from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95])\n\tby smtp.gmail.com with ESMTPSA id\n\ty3sm25713924pgc.81.2018.04.25.08.56.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 25 Apr 2018 08:56:57 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=qDmwztWVnwRPayPUB4x9b/Mw0WMcx/7Q6y9dqOZkDDQ=;\n\tb=CyhsGIwgFQns2/vQL4rZ2Prd9Tca1potO7khlnvagmFKpoKHktrQ+RRKCUaJtCGsIi\n\tBPG4XfWl9hlFptLoRf4ho0BFKibRo7icNRKpmlNwwjMQFHaUwTI5Ar7+gRZJd5rBvKkV\n\t8VjEmtgAVj3U8DybnGCvX4kZVQbOUeLUrELpF++uMV1pbV9A1MKetOB7EhbvG7BkL0dL\n\t/4y5ePvCzOkWQ2WBHXT5bROIqihqD1FJPdq8MQ0ga6sF70k/QwR1Su4iJxz5EfY9A5ia\n\tqOC2MYLYIt3MH8mp7YWMvsUcpfJPpMM9HwfUqqNp3y4dIdcMIlpP/EV4ZW6NI1+dkMpa\n\tv58g==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=qDmwztWVnwRPayPUB4x9b/Mw0WMcx/7Q6y9dqOZkDDQ=;\n\tb=r0UYB6svNuQp+yxyq0Acsu7YX3lmSyDAdqIqr0epIZ2qkit9S5eLtxAGZgH7EYQMEJ\n\t/cNrZeB2/IRv4IMtdwxFizFOWcTi0kY5FogZKHRo5QZFyVEGRohQ0iM2XkUrp/Xbwqde\n\t6K4g7kMLU3N6zOWQBmPDGLqm6mI2lnHKOuOpI34cSKagJtbtsToZsA7DQfSO/9CoCU8V\n\tX5NyDI+9exidSrF2KS1JjsyXagMA3+U0dlwpk3AWfyhX6wTR12eqDerPFp3P7PIyElKw\n\tl6DHhWDDA/XFtfuWvVDjqLmDqfodr437MRjYdqns044kwFuCDhJmdiJaH5kPPkT5NY8b\n\tB+4g==",
        "X-Gm-Message-State": "ALQs6tDkTbnu8KNLo0kNIDM155g4+Dc1v1uJde/z9gVejRIPOVGsGg1e\n\tkcTwnzsjOzR29tj69hzaa/kXPV9FhuQ=",
        "X-Google-Smtp-Source": "AIpwx4+wTHQrJB9dxkHyDmES82xfMPkrSfq2E8giWDcp9xdLzihBSakz/1HVU4BjtHRBhP+zRac2NA==",
        "X-Received": "by 10.98.166.92 with SMTP id t89mr28201077pfe.27.1524671818685; \n\tWed, 25 Apr 2018 08:56:58 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Wed, 25 Apr 2018 08:56:43 -0700",
        "Message-Id": "<20180425155646.3627-8-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.0",
        "In-Reply-To": "<20180425155646.3627-1-stephen@networkplumber.org>",
        "References": "<20180425155646.3627-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH next 07/10] net/kni: support dynamic logging",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/kni/rte_eth_kni.c | 34 ++++++++++++++++++++++++----------\n 1 file changed, 24 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c\nindex 35a6d3ef7280..bbb2f00c80d7 100644\n--- a/drivers/net/kni/rte_eth_kni.c\n+++ b/drivers/net/kni/rte_eth_kni.c\n@@ -65,6 +65,11 @@ static const struct rte_eth_link pmd_link = {\n };\n static int is_kni_initialized;\n \n+static int eth_kni_logtype;\n+\n+#define PMD_LOG(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ## level, eth_kni_logtype, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n static uint16_t\n eth_kni_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n {\n@@ -126,8 +131,8 @@ eth_kni_start(struct rte_eth_dev *dev)\n \n \tinternals->kni = rte_kni_alloc(mb_pool, &conf, NULL);\n \tif (internals->kni == NULL) {\n-\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\"Fail to create kni interface for port: %d\\n\",\n+\t\tPMD_LOG(ERR,\n+\t\t\t\"Fail to create kni interface for port: %d\",\n \t\t\tport_id);\n \t\treturn -1;\n \t}\n@@ -153,8 +158,8 @@ eth_kni_dev_start(struct rte_eth_dev *dev)\n \t\t\t\"kni_handle_req\", NULL,\n \t\t\tkni_handle_request, internals);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\t\"Fail to create kni request thread\\n\");\n+\t\t\tPMD_LOG(ERR,\n+\t\t\t\t\"Fail to create kni request thread\");\n \t\t\treturn -1;\n \t\t}\n \t}\n@@ -175,11 +180,11 @@ eth_kni_dev_stop(struct rte_eth_dev *dev)\n \n \t\tret = pthread_cancel(internals->thread);\n \t\tif (ret)\n-\t\t\tRTE_LOG(ERR, PMD, \"Can't cancel the thread\\n\");\n+\t\t\tPMD_LOG(ERR, \"Can't cancel the thread\");\n \n \t\tret = pthread_join(internals->thread, NULL);\n \t\tif (ret)\n-\t\t\tRTE_LOG(ERR, PMD, \"Can't join the thread\\n\");\n+\t\t\tPMD_LOG(ERR, \"Can't join the thread\");\n \n \t\tinternals->stop_thread = 0;\n \t}\n@@ -338,7 +343,7 @@ eth_kni_create(struct rte_vdev_device *vdev,\n \tstruct rte_eth_dev_data *data;\n \tstruct rte_eth_dev *eth_dev;\n \n-\tRTE_LOG(INFO, PMD, \"Creating kni ethdev on numa socket %u\\n\",\n+\tPMD_LOG(INFO, \"Creating kni ethdev on numa socket %u\",\n \t\t\tnuma_node);\n \n \t/* reserve an ethdev entry */\n@@ -403,13 +408,13 @@ eth_kni_probe(struct rte_vdev_device *vdev)\n \n \tname = rte_vdev_device_name(vdev);\n \tparams = rte_vdev_device_args(vdev);\n-\tRTE_LOG(INFO, PMD, \"Initializing eth_kni for %s\\n\", name);\n+\tPMD_LOG(INFO, \"Initializing eth_kni for %s\", name);\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY &&\n \t    strlen(params) == 0) {\n \t\teth_dev = rte_eth_dev_attach_secondary(name);\n \t\tif (!eth_dev) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to probe %s\\n\", name);\n+\t\t\tPMD_LOG(ERR, \"Failed to probe %s\", name);\n \t\t\treturn -1;\n \t\t}\n \t\t/* TODO: request info from primary to set up Rx and Tx */\n@@ -449,7 +454,7 @@ eth_kni_remove(struct rte_vdev_device *vdev)\n \tconst char *name;\n \n \tname = rte_vdev_device_name(vdev);\n-\tRTE_LOG(INFO, PMD, \"Un-Initializing eth_kni for %s\\n\", name);\n+\tPMD_LOG(INFO, \"Un-Initializing eth_kni for %s\", name);\n \n \t/* find the ethdev entry */\n \teth_dev = rte_eth_dev_allocated(name);\n@@ -479,3 +484,12 @@ static struct rte_vdev_driver eth_kni_drv = {\n \n RTE_PMD_REGISTER_VDEV(net_kni, eth_kni_drv);\n RTE_PMD_REGISTER_PARAM_STRING(net_kni, ETH_KNI_NO_REQUEST_THREAD_ARG \"=<int>\");\n+\n+RTE_INIT(eth_kni_init_log);\n+static void\n+eth_kni_init_log(void)\n+{\n+\teth_kni_logtype = rte_log_register(\"pmd.net.kni\");\n+\tif (eth_kni_logtype >= 0)\n+\t\trte_log_set_level(eth_kni_logtype, RTE_LOG_NOTICE);\n+}\n",
    "prefixes": [
        "dpdk-dev",
        "next",
        "07/10"
    ]
}