Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 38950,
    "url": "http://patches.dpdk.org/api/patches/38950/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180425155646.3627-5-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180425155646.3627-5-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180425155646.3627-5-stephen@networkplumber.org",
    "date": "2018-04-25T15:56:40",
    "name": "[dpdk-dev,next,04/10] net/ring: convert to dynamic logging",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a4ad2015a1db70be57d1c577aa5073282a2164fd",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180425155646.3627-5-stephen@networkplumber.org/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/38950/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/38950/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BAF0F9605;\n\tWed, 25 Apr 2018 17:57:03 +0200 (CEST)",
            "from mail-pf0-f193.google.com (mail-pf0-f193.google.com\n\t[209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 813058E5D\n\tfor <dev@dpdk.org>; Wed, 25 Apr 2018 17:56:55 +0200 (CEST)",
            "by mail-pf0-f193.google.com with SMTP id o76so10881322pfi.5\n\tfor <dev@dpdk.org>; Wed, 25 Apr 2018 08:56:55 -0700 (PDT)",
            "from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95])\n\tby smtp.gmail.com with ESMTPSA id\n\ty3sm25713924pgc.81.2018.04.25.08.56.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 25 Apr 2018 08:56:52 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=n/f3eUv2sIKxtHeZQGtgqCjp/BjuqrxivPHJohdKL1Y=;\n\tb=1oJrao02QTOsetX3uPh5qETy7JC0DRf2MjiwHjoxMwU4OxyCtyiyEPkKLQvVQeOsK4\n\tW7R1MVJ8B0RSI32PF0Ni9Qak98Ubc4FMXWGV0sqCgwcu1/6hv/jfrCxj9L244d0ZzviR\n\tftBSNLQwExvqOfiKKJHFI79OymKOpRM2mPh+4z7gUuGBYqwwX0oK/dcg0lpxdWrahHed\n\tLON/oAYhtLGRrVDGASSGjxiQu+O/Iel1sExddoKOevrUexqeOEslj4ttcC7Gyko7EKTn\n\tZxpyL0IWhzEOqVFhhAIyuzF7vCyR/xQoekXfq/h8gIaQIF5cfJthf+HwXkz9iv3jYqkj\n\tD7HA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=n/f3eUv2sIKxtHeZQGtgqCjp/BjuqrxivPHJohdKL1Y=;\n\tb=JOeC0EEDGPJi25AljgLTl7Em1nL6I62JZJZQI/t6xYENrRwKjAnL58RJ+C4ECfGp2j\n\tirXsFCTR8K4ZekvT6N8zgc3zA5FvzeYR/PlKgtQYjcAGN/RbC88Vw/Fsrk2/pqkMktyo\n\tb53zNEgul/2k3rdjLkT3WcskMYJ3L3mw7+wM0iWX2xqS54NtTjG+IKr5E5IZcT0LLY1r\n\t4M+hUBrdi4dk8Jsq08m7ea04yhpaKQMYP+ZCR06k0tP1IjwmcEwGP2z/Wspk6KQYKjpP\n\tQtpa+GRXA9HMD5NZspbQbU0atv4yKBMS1qhkq/z5Yd+LkH3hiE8PjHn8sKh9I0hZfe05\n\taEsA==",
        "X-Gm-Message-State": "ALQs6tA3RZpq3R0BrkpKl7l7fCwkhLcxwXvBPYmub6OGcr0fcJzld2Zt\n\tkRjUeNyFZXO0M3sUmtIPxG4eAf2785w=",
        "X-Google-Smtp-Source": "AIpwx4+xdFwJqKZoPFokQTCPGBNDEqtC3ngmPWDVDtw+N+k1IsEUxEWzMDLlsPU/dQIIxZ6btOEwKQ==",
        "X-Received": "by 10.98.77.2 with SMTP id a2mr28494089pfb.213.1524671814259;\n\tWed, 25 Apr 2018 08:56:54 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Wed, 25 Apr 2018 08:56:40 -0700",
        "Message-Id": "<20180425155646.3627-5-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.0",
        "In-Reply-To": "<20180425155646.3627-1-stephen@networkplumber.org>",
        "References": "<20180425155646.3627-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH next 04/10] net/ring: convert to dynamic logging",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ring/rte_eth_ring.c | 46 ++++++++++++++++++++++-----------\n 1 file changed, 31 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex e53823adb3e5..0581ab216cd4 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -63,6 +63,12 @@ static struct rte_eth_link pmd_link = {\n \t\t.link_autoneg = ETH_LINK_AUTONEG\n };\n \n+static int eth_ring_logtype;\n+\n+#define PMD_LOG(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ## level, eth_ring_logtype, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n+\n static uint16_t\n eth_ring_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n {\n@@ -256,7 +262,7 @@ do_eth_dev_ring_create(const char *name,\n \tvoid **tx_queues_local = NULL;\n \tunsigned i;\n \n-\tRTE_LOG(INFO, PMD, \"Creating rings-backed ethdev on numa socket %u\\n\",\n+\tPMD_LOG(INFO, \"Creating rings-backed ethdev on numa socket %u\",\n \t\t\tnuma_node);\n \n \trx_queues_local = rte_zmalloc_socket(name,\n@@ -446,13 +452,13 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *\n \tret = -EINVAL;\n \n \tif (!name) {\n-\t\tRTE_LOG(WARNING, PMD, \"command line parameter is empty for ring pmd!\\n\");\n+\t\tPMD_LOG(WARNING, \"command line parameter is empty for ring pmd!\");\n \t\tgoto out;\n \t}\n \n \tnode = strchr(name, ':');\n \tif (!node) {\n-\t\tRTE_LOG(WARNING, PMD, \"could not parse node value from %s\\n\",\n+\t\tPMD_LOG(WARNING, \"could not parse node value from %s\",\n \t\t\tname);\n \t\tgoto out;\n \t}\n@@ -462,7 +468,7 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *\n \n \taction = strchr(node, ':');\n \tif (!action) {\n-\t\tRTE_LOG(WARNING, PMD, \"could not parse action value from %s\\n\",\n+\t\tPMD_LOG(WARNING, \"could not parse action value from %s\",\n \t\t\tnode);\n \t\tgoto out;\n \t}\n@@ -485,7 +491,8 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *\n \tinfo->list[info->count].node = strtol(node, &end, 10);\n \n \tif ((errno != 0) || (*end != '\\0')) {\n-\t\tRTE_LOG(WARNING, PMD, \"node value %s is unparseable as a number\\n\", node);\n+\t\tPMD_LOG(WARNING,\n+\t\t\t\"node value %s is unparseable as a number\", node);\n \t\tgoto out;\n \t}\n \n@@ -529,14 +536,14 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)\n \tname = rte_vdev_device_name(dev);\n \tparams = rte_vdev_device_args(dev);\n \n-\tRTE_LOG(INFO, PMD, \"Initializing pmd_ring for %s\\n\", name);\n+\tPMD_LOG(INFO, \"Initializing pmd_ring for %s\", name);\n \n \tif (params == NULL || params[0] == '\\0') {\n \t\tret = eth_dev_ring_create(name, rte_socket_id(), DEV_CREATE,\n \t\t\t\t&eth_dev);\n \t\tif (ret == -1) {\n-\t\t\tRTE_LOG(INFO, PMD,\n-\t\t\t\t\"Attach to pmd_ring for %s\\n\", name);\n+\t\t\tPMD_LOG(INFO,\n+\t\t\t\t\"Attach to pmd_ring for %s\", name);\n \t\t\tret = eth_dev_ring_create(name, rte_socket_id(),\n \t\t\t\t\t\t  DEV_ATTACH, &eth_dev);\n \t\t}\n@@ -544,13 +551,13 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)\n \t\tkvlist = rte_kvargs_parse(params, valid_arguments);\n \n \t\tif (!kvlist) {\n-\t\t\tRTE_LOG(INFO, PMD, \"Ignoring unsupported parameters when creating\"\n-\t\t\t\t\t\" rings-backed ethernet device\\n\");\n+\t\t\tPMD_LOG(INFO, \"Ignoring unsupported parameters when creating\"\n+\t\t\t\t\t\" rings-backed ethernet device\");\n \t\t\tret = eth_dev_ring_create(name, rte_socket_id(),\n \t\t\t\t\t\t  DEV_CREATE, &eth_dev);\n \t\t\tif (ret == -1) {\n-\t\t\t\tRTE_LOG(INFO, PMD,\n-\t\t\t\t\t\"Attach to pmd_ring for %s\\n\",\n+\t\t\t\tPMD_LOG(INFO,\n+\t\t\t\t\t\"Attach to pmd_ring for %s\",\n \t\t\t\t\tname);\n \t\t\t\tret = eth_dev_ring_create(name, rte_socket_id(),\n \t\t\t\t\t\t\t  DEV_ATTACH, &eth_dev);\n@@ -604,8 +611,8 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)\n \t\t\t\t\t\t\t  &eth_dev);\n \t\t\t\tif ((ret == -1) &&\n \t\t\t\t    (info->list[info->count].action == DEV_CREATE)) {\n-\t\t\t\t\tRTE_LOG(INFO, PMD,\n-\t\t\t\t\t\t\"Attach to pmd_ring for %s\\n\",\n+\t\t\t\t\tPMD_LOG(INFO,\n+\t\t\t\t\t\t\"Attach to pmd_ring for %s\",\n \t\t\t\t\t\tname);\n \t\t\t\t\tret = eth_dev_ring_create(name,\n \t\t\t\t\t\t\tinfo->list[info->count].node,\n@@ -634,7 +641,7 @@ rte_pmd_ring_remove(struct rte_vdev_device *dev)\n \tstruct ring_queue *r = NULL;\n \tuint16_t i;\n \n-\tRTE_LOG(INFO, PMD, \"Un-Initializing pmd_ring for %s\\n\", name);\n+\tPMD_LOG(INFO, \"Un-Initializing pmd_ring for %s\", name);\n \n \tif (name == NULL)\n \t\treturn -EINVAL;\n@@ -675,3 +682,12 @@ RTE_PMD_REGISTER_VDEV(net_ring, pmd_ring_drv);\n RTE_PMD_REGISTER_ALIAS(net_ring, eth_ring);\n RTE_PMD_REGISTER_PARAM_STRING(net_ring,\n \tETH_RING_NUMA_NODE_ACTION_ARG \"=name:node:action(ATTACH|CREATE)\");\n+\n+RTE_INIT(eth_ring_init_log);\n+static void\n+eth_ring_init_log(void)\n+{\n+\teth_ring_logtype = rte_log_register(\"pmd.net.ring\");\n+\tif (eth_ring_logtype >= 0)\n+\t\trte_log_set_level(eth_ring_logtype, RTE_LOG_NOTICE);\n+}\n",
    "prefixes": [
        "dpdk-dev",
        "next",
        "04/10"
    ]
}