Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/38863/?format=api
{ "id": 38863, "url": "http://patches.dpdk.org/api/patches/38863/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180425083944.34476-1-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180425083944.34476-1-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180425083944.34476-1-qi.z.zhang@intel.com", "date": "2018-04-25T08:39:44", "name": "[dpdk-dev,v2] ethdev: fix naming for device capability", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "371fd49451d335785046d761f9991dc08e9b836c", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180425083944.34476-1-qi.z.zhang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/38863/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/38863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DB5501DB3;\n\tWed, 25 Apr 2018 10:39:34 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 4913510BD\n\tfor <dev@dpdk.org>; Wed, 25 Apr 2018 10:39:32 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Apr 2018 01:39:30 -0700", "from dpdk51.sh.intel.com ([10.67.110.184])\n\tby orsmga003.jf.intel.com with ESMTP; 25 Apr 2018 01:39:29 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,325,1520924400\"; d=\"scan'208\";a=\"45887124\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "thomas@monjalon.net", "Cc": "dev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Wed, 25 Apr 2018 16:39:44 +0800", "Message-Id": "<20180425083944.34476-1-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "Subject": "[dpdk-dev] [PATCH v2] ethdev: fix naming for device capability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rename all device capabilities to start with RTE_ETH_DEV_CAPA.\n\nFixes: 8719ad91e5772 (\"ethdev: support runtime queue setup\")\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n\nv2:\n- fix fix line\n\n doc/guides/nics/features.rst | 4 ++--\n drivers/net/i40e/i40e_ethdev.c | 4 ++--\n lib/librte_ether/rte_ethdev.c | 4 ++--\n lib/librte_ether/rte_ethdev.h | 6 +++---\n 4 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst\nindex 67d459f80..14b8672bc 100644\n--- a/doc/guides/nics/features.rst\n+++ b/doc/guides/nics/features.rst\n@@ -899,7 +899,7 @@ Runtime Rx queue setup\n \n Supports Rx queue setup after device started.\n \n-* **[provides] rte_eth_dev_info**: ``dev_capa:DEV_CAPA_RUNTIME_RX_QUEUE_SETUP``.\n+* **[provides] rte_eth_dev_info**: ``dev_capa:RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP``.\n * **[related] API**: ``rte_eth_dev_info_get()``.\n \n .. _nic_features_runtime_tx_queue_setup:\n@@ -909,7 +909,7 @@ Runtime Tx queue setup\n \n Supports Tx queue setup after device started.\n \n-* **[provides] rte_eth_dev_info**: ``dev_capa:DEV_CAPA_RUNTIME_TX_QUEUE_SETUP``.\n+* **[provides] rte_eth_dev_info**: ``dev_capa:RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP``.\n * **[related] API**: ``rte_eth_dev_info_get()``.\n \n .. _nic_features_other:\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex e329042df..2fc98a7e7 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -3245,8 +3245,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tDEV_TX_OFFLOAD_IPIP_TNL_TSO |\n \t\tDEV_TX_OFFLOAD_GENEVE_TNL_TSO;\n \tdev_info->dev_capa =\n-\t\tDEV_CAPA_RUNTIME_RX_QUEUE_SETUP |\n-\t\tDEV_CAPA_RUNTIME_TX_QUEUE_SETUP;\n+\t\tRTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |\n+\t\tRTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;\n \n \tdev_info->hash_key_size = (I40E_PFQF_HKEY_MAX_INDEX + 1) *\n \t\t\t\t\t\tsizeof(uint32_t);\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 0e503ab7e..5f1a1bf2b 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1478,7 +1478,7 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,\n \n \tif (dev->data->dev_started &&\n \t\t!(dev_info.dev_capa &\n-\t\t\tDEV_CAPA_RUNTIME_RX_QUEUE_SETUP))\n+\t\t\tRTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP))\n \t\treturn -EBUSY;\n \n \tif (dev->data->rx_queue_state[rx_queue_id] !=\n@@ -1586,7 +1586,7 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,\n \n \tif (dev->data->dev_started &&\n \t\t!(dev_info.dev_capa &\n-\t\t\tDEV_CAPA_RUNTIME_TX_QUEUE_SETUP))\n+\t\t\tRTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP))\n \t\treturn -EBUSY;\n \n \tif (dev->data->tx_queue_state[tx_queue_id] !=\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 4096f688a..8da452cdf 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -993,9 +993,9 @@ struct rte_eth_conf {\n */\n #define DEV_TX_OFFLOAD_IP_TNL_TSO 0x00080000\n \n-#define DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001\n+#define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001\n /**< Device supports Rx queue setup after device started*/\n-#define DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002\n+#define RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002\n /**< Device supports Tx queue setup after device started*/\n \n /*\n@@ -1071,7 +1071,7 @@ struct rte_eth_dev_info {\n \tstruct rte_eth_dev_portconf default_rxportconf;\n \t/** Tx parameter recommendations */\n \tstruct rte_eth_dev_portconf default_txportconf;\n-\t/** Generic device capabilities */\n+\t/** Generic device capabilities (RTE_ETH_DEV_CAPA_). */\n \tuint64_t dev_capa;\n };\n \n", "prefixes": [ "dpdk-dev", "v2" ] }