Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3884/?format=api
{ "id": 3884, "url": "http://patches.dpdk.org/api/patches/3884/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1425574530-16019-1-git-send-email-michael.qiu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1425574530-16019-1-git-send-email-michael.qiu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1425574530-16019-1-git-send-email-michael.qiu@intel.com", "date": "2015-03-05T16:55:30", "name": "[dpdk-dev,1/3,v2] librte_hash: Fix unsupported instruction `crc32' in i686 platform", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cc1b430fbd2440c4730579696676eca54dbc641d", "submitter": { "id": 101, "url": "http://patches.dpdk.org/api/people/101/?format=api", "name": "Michael Qiu", "email": "michael.qiu@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1425574530-16019-1-git-send-email-michael.qiu@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/3884/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/3884/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5030E5A6A;\n\tThu, 5 Mar 2015 17:55:44 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 07CD511C5\n\tfor <dev@dpdk.org>; Thu, 5 Mar 2015 17:55:42 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP; 05 Mar 2015 08:55:41 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 05 Mar 2015 08:55:40 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t25GtbJa000493;\n\tFri, 6 Mar 2015 00:55:37 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t25GtaFi016054; Fri, 6 Mar 2015 00:55:38 +0800", "(from dayuqiu@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t25GtY19016050; \n\tFri, 6 Mar 2015 00:55:34 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.11,348,1422950400\"; d=\"scan'208\";a=\"675674230\"", "From": "Michael Qiu <michael.qiu@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 6 Mar 2015 00:55:30 +0800", "Message-Id": "<1425574530-16019-1-git-send-email-michael.qiu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1425561339-13300-2-git-send-email-michael.qiu@intel.com>", "References": "<1425561339-13300-2-git-send-email-michael.qiu@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/3 v2] librte_hash: Fix unsupported instruction\n\t`crc32' in i686 platform", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "CC rte_hash.o\nError: unsupported instruction `crc32'\n\nThe root cause is that i686 platform does not support 'crc32q'\nNeed make it only available in x86_64 platform\n\nSigned-off-by: Michael Qiu <michael.qiu@intel.com>\n---\nv2 --> v1:\n Make crc32 instruction only works in X86 platform\n lib/librte_hash/rte_hash_crc.h | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h\nindex d28bb2a..c0a789e 100644\n--- a/lib/librte_hash/rte_hash_crc.h\n+++ b/lib/librte_hash/rte_hash_crc.h\n@@ -364,6 +364,7 @@ crc32c_2words(uint64_t data, uint32_t init_val)\n \treturn crc;\n }\n \n+#if defined RTE_ARCH_I686 || defined RTE_ARCH_X86_64\n static inline uint32_t\n crc32c_sse42_u32(uint32_t data, uint32_t init_val)\n {\n@@ -373,7 +374,9 @@ crc32c_sse42_u32(uint32_t data, uint32_t init_val)\n \t\t\t: [data] \"rm\" (data));\n \treturn init_val;\n }\n+#endif\n \n+#ifdef RTE_ARCH_X86_64\n static inline uint32_t\n crc32c_sse42_u64(uint64_t data, uint64_t init_val)\n {\n@@ -383,7 +386,9 @@ crc32c_sse42_u64(uint64_t data, uint64_t init_val)\n \t\t\t: [data] \"rm\" (data));\n \treturn init_val;\n }\n+#endif\n \n+#if defined RTE_ARCH_I686 || defined RTE_ARCH_X86_64\n static inline uint32_t\n crc32c_sse42_u64_mimic(uint64_t data, uint64_t init_val)\n {\n@@ -397,6 +402,7 @@ crc32c_sse42_u64_mimic(uint64_t data, uint64_t init_val)\n \tinit_val = crc32c_sse42_u32(d.u32[1], init_val);\n \treturn init_val;\n }\n+#endif\n \n #define CRC32_SW (1U << 0)\n #define CRC32_SSE42 (1U << 1)\n@@ -455,8 +461,10 @@ rte_hash_crc_init_alg(void)\n static inline uint32_t\n rte_hash_crc_4byte(uint32_t data, uint32_t init_val)\n {\n+#if defined RTE_ARCH_I686 || defined RTE_ARCH_X86_64\n \tif (likely(crc32_alg & CRC32_SSE42))\n \t\treturn crc32c_sse42_u32(data, init_val);\n+#endif\n \n \treturn crc32c_1word(data, init_val);\n }\n@@ -476,11 +484,15 @@ rte_hash_crc_4byte(uint32_t data, uint32_t init_val)\n static inline uint32_t\n rte_hash_crc_8byte(uint64_t data, uint32_t init_val)\n {\n+#ifdef RTE_ARCH_X86_64\n \tif (likely(crc32_alg == CRC32_SSE42_x64))\n \t\treturn crc32c_sse42_u64(data, init_val);\n+#endif\n \n+#if defined RTE_ARCH_I686 || defined RTE_ARCH_X86_64\n \tif (likely(crc32_alg & CRC32_SSE42))\n \t\treturn crc32c_sse42_u64_mimic(data, init_val);\n+#endif\n \n \treturn crc32c_2words(data, init_val);\n }\n", "prefixes": [ "dpdk-dev", "1/3", "v2" ] }