Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/38371/?format=api
{ "id": 38371, "url": "http://patches.dpdk.org/api/patches/38371/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/9a3e52dc5bb1cc7e4f62997d388a54164583d47a.1523977588.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9a3e52dc5bb1cc7e4f62997d388a54164583d47a.1523977588.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9a3e52dc5bb1cc7e4f62997d388a54164583d47a.1523977588.git.anatoly.burakov@intel.com", "date": "2018-04-17T15:50:10", "name": "[dpdk-dev,03/10] mem: fix potential double close", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e60812db9e45a9bc6e5e2cc57554463839aaee4c", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/9a3e52dc5bb1cc7e4f62997d388a54164583d47a.1523977588.git.anatoly.burakov@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/38371/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/38371/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A3AD11B1DC;\n\tTue, 17 Apr 2018 17:50:33 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 610591B16B\n\tfor <dev@dpdk.org>; Tue, 17 Apr 2018 17:50:21 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Apr 2018 08:50:19 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 17 Apr 2018 08:50:18 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw3HFoHXV032137; Tue, 17 Apr 2018 16:50:17 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w3HFoHML027044;\n\tTue, 17 Apr 2018 16:50:17 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w3HFoHvG027040;\n\tTue, 17 Apr 2018 16:50:17 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,464,1517904000\"; d=\"scan'208\";a=\"43995996\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, anatoly.burakov@intel.com", "Date": "Tue, 17 Apr 2018 16:50:10 +0100", "Message-Id": "<9a3e52dc5bb1cc7e4f62997d388a54164583d47a.1523977588.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1523977588.git.anatoly.burakov@intel.com>", "<cover.1523977588.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1523977588.git.anatoly.burakov@intel.com>", "<cover.1523977588.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 03/10] mem: fix potential double close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We were closing descriptor before checking if mapping has\nfailed, but if it did, we did a second close afterwards. Fix\nit by moving closing descriptor to after we check if mmap has\nsucceeded.\n\nCoverity issue: 272560\n\nFixes: 2a04139f66b4 (\"eal: add single file segments option\")\nCc: anatoly.burakov@intel.com\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_memalloc.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c\nindex 1f553dd..9156f8b 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c\n@@ -458,9 +458,6 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,\n \t */\n \tvoid *va = mmap(addr, alloc_sz, PROT_READ | PROT_WRITE,\n \t\t\tMAP_SHARED | MAP_POPULATE | MAP_FIXED, fd, map_offset);\n-\t/* for non-single file segments, we can close fd here */\n-\tif (!internal_config.single_file_segments)\n-\t\tclose(fd);\n \n \tif (va == MAP_FAILED) {\n \t\tRTE_LOG(DEBUG, EAL, \"%s(): mmap() failed: %s\\n\", __func__,\n@@ -471,6 +468,9 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,\n \t\tRTE_LOG(DEBUG, EAL, \"%s(): wrong mmap() address\\n\", __func__);\n \t\tgoto mapped;\n \t}\n+\t/* for non-single file segments, we can close fd here */\n+\tif (!internal_config.single_file_segments)\n+\t\tclose(fd);\n \n \trte_iova_t iova = rte_mem_virt2iova(addr);\n \tif (iova == RTE_BAD_PHYS_ADDR) {\n", "prefixes": [ "dpdk-dev", "03/10" ] }