Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/38365/?format=api
http://patches.dpdk.org/api/patches/38365/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/ff6dd425580b10d3c97e62118e204eddba0ef787.1523979264.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<ff6dd425580b10d3c97e62118e204eddba0ef787.1523979264.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/ff6dd425580b10d3c97e62118e204eddba0ef787.1523979264.git.anatoly.burakov@intel.com", "date": "2018-04-17T15:48:16", "name": "[dpdk-dev,4/5] malloc: fix potential dereferencing of NULL pointer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6447fc77d33581657d62159f61190a45ab80c419", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/ff6dd425580b10d3c97e62118e204eddba0ef787.1523979264.git.anatoly.burakov@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/38365/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/38365/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 52B9C1B1A9;\n\tTue, 17 Apr 2018 17:48:31 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id BA961CF9E\n\tfor <dev@dpdk.org>; Tue, 17 Apr 2018 17:48:21 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Apr 2018 08:48:20 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga007.fm.intel.com with ESMTP; 17 Apr 2018 08:48:19 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw3HFmIWC031006; Tue, 17 Apr 2018 16:48:18 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w3HFmIJu024793;\n\tTue, 17 Apr 2018 16:48:18 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w3HFmIbf024789;\n\tTue, 17 Apr 2018 16:48:18 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,464,1517904000\"; d=\"scan'208\";a=\"32646976\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, anatoly.burakov@intel.com", "Date": "Tue, 17 Apr 2018 16:48:16 +0100", "Message-Id": "<ff6dd425580b10d3c97e62118e204eddba0ef787.1523979264.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1523979264.git.anatoly.burakov@intel.com>", "<cover.1523979264.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1523979264.git.anatoly.burakov@intel.com>", "<cover.1523979264.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 4/5] malloc: fix potential dereferencing of NULL\n\tpointer", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous code checked for both first/last elements being NULL,\nbut if they weren't, the expectation was that they're both\nnon-NULL, which will be the case under normal conditions, but\nmay not be the case due to heap structure corruption.\n\nCoverity issue: 272566\n\nFixes: bb372060dad4 (\"malloc: make heap a doubly-linked list\")\nCc: anatoly.burakov@intel.com\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/malloc_elem.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/malloc_elem.c b/lib/librte_eal/common/malloc_elem.c\nindex ee79dcd..af81961 100644\n--- a/lib/librte_eal/common/malloc_elem.c\n+++ b/lib/librte_eal/common/malloc_elem.c\n@@ -49,6 +49,12 @@ malloc_elem_insert(struct malloc_elem *elem)\n \tstruct malloc_elem *prev_elem, *next_elem;\n \tstruct malloc_heap *heap = elem->heap;\n \n+\t/* first and last elements must be both NULL or both non-NULL */\n+\tif ((heap->first == NULL) != (heap->last == NULL)) {\n+\t\tRTE_LOG(ERR, EAL, \"Heap is probably corrupt\\n\");\n+\t\treturn;\n+\t}\n+\n \tif (heap->first == NULL && heap->last == NULL) {\n \t\t/* if empty heap */\n \t\theap->first = elem;\n", "prefixes": [ "dpdk-dev", "4/5" ] }{ "id": 38365, "url": "