Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3799/?format=api
{ "id": 3799, "url": "http://patches.dpdk.org/api/patches/3799/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1425142563-27185-1-git-send-email-keith.wiles@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1425142563-27185-1-git-send-email-keith.wiles@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1425142563-27185-1-git-send-email-keith.wiles@intel.com", "date": "2015-02-28T16:56:03", "name": "[dpdk-dev] External app builds need to locate common make fragments and includes.", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "d97c3be1e0964cb537194db1cc33a6ebe4fce1d1", "submitter": { "id": 166, "url": "http://patches.dpdk.org/api/people/166/?format=api", "name": "Wiles, Keith", "email": "keith.wiles@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1425142563-27185-1-git-send-email-keith.wiles@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/3799/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/3799/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 23E83959;\n\tSat, 28 Feb 2015 17:56:19 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id B8AF2903\n\tfor <dev@dpdk.org>; Sat, 28 Feb 2015 17:56:17 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP; 28 Feb 2015 08:54:59 -0800", "from unknown (HELO rkwiles-desk.ger.corp.intel.com)\n\t([10.255.41.74])\n\tby orsmga003.jf.intel.com with ESMTP; 28 Feb 2015 08:56:24 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,668,1418112000\"; d=\"scan'208\";a=\"534221636\"", "From": "Keith Wiles <keith.wiles@intel.com>", "To": "dev@dpdk.org", "Date": "Sat, 28 Feb 2015 10:56:03 -0600", "Message-Id": "<1425142563-27185-1-git-send-email-keith.wiles@intel.com>", "X-Mailer": "git-send-email 2.3.0", "Subject": "[dpdk-dev] [PATCH] External app builds need to locate common make\n\tfragments and includes.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When building an external application like Pktgen and using the proper\nmakefile fragments rte.extXYZ.mk NOT rte.XYZ.mk files as you would\nuse with example applications in the same RTE_SDK directory the rte.extXYZ.mk\nfiles are missing some defines/includes.\n\n 1 - Add missing tests for RTE_SDK/RTE_TARGET not defined code.\n 2 - The build of external applications are forced to be verbose ouput\n as the Q=@ define is not present.\n 3 - Missing include of target/generic/rte.vars.mk file which includes\n the information to locate the rte_config.h and other DPDK include\n files.\n\nA patch like this one was submitted before and was rejected because it\nseemed it was not required, because target/generic/rte.vars.mk already\nincluded by rte.vars.mk.\n\nThis is not the cause for external applications like Pktgen which are\nbuilt outside of the RTE_SDK directory and only include the rte.extXYZ.mk\nmakefile fragments.\n\nSigned-off-by: Keith Wiles <keith.wiles@intel.com>\n---\n mk/rte.extvars.mk | 36 ++++++++++++++++++++++++++++++++++--\n 1 file changed, 34 insertions(+), 2 deletions(-)", "diff": "diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk\nindex 3e5a990..e6c6401 100644\n--- a/mk/rte.extvars.mk\n+++ b/mk/rte.extvars.mk\n@@ -30,8 +30,19 @@\n # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n \n #\n-# directory where sources are located\n+# To be included at the beginning of all RTE external user Makefiles. This\n+# .mk will define the RTE environment variables by including the\n+# config file of SDK. It also includes the config file from external\n+# application if any.\n #\n+\n+ifeq ($(RTE_SDK),)\n+$(error RTE_SDK is not defined)\n+endif\n+ifeq ($(wildcard $(RTE_SDK)),)\n+$(error RTE_SDK variable points to an invalid location)\n+endif\n+\n ifdef S\n ifeq (\"$(origin S)\", \"command line\")\n RTE_SRCDIR := $(abspath $(S))\n@@ -40,6 +51,16 @@ endif\n RTE_SRCDIR ?= $(CURDIR)\n export RTE_SRCDIR\n \n+# define Q to '@' or not. $(Q) is used to prefix all shell commands to\n+# be executed silently.\n+Q=@\n+ifdef V\n+ifeq (\"$(origin V)\", \"command line\")\n+Q=\n+endif\n+endif\n+export Q\n+\n #\n # Makefile to call once $(RTE_OUTPUT) is created\n #\n@@ -51,6 +72,13 @@ endif\n RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile\n export RTE_EXTMK\n \n+# RTE_TARGET is deducted from config when we are building the SDK.\n+# Else, when building an external app, RTE_TARGET must be specified\n+# by the user.\n+ifeq ($(RTE_TARGET),)\n+$(error RTE_TARGET is not defined)\n+endif\n+\n RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)\n \n #\n@@ -78,4 +106,8 @@ RTE_MACHINE := $(CONFIG_RTE_MACHINE:\"%\"=%)\n RTE_EXEC_ENV := $(CONFIG_RTE_EXEC_ENV:\"%\"=%)\n RTE_TOOLCHAIN := $(CONFIG_RTE_TOOLCHAIN:\"%\"=%)\n \n-\n+ifneq ($(wildcard $(RTE_SDK)/mk/target/$(RTE_TARGET)/rte.vars.mk),)\n+include $(RTE_SDK)/mk/target/$(RTE_TARGET)/rte.vars.mk\n+else\n+include $(RTE_SDK)/mk/target/generic/rte.vars.mk\n+endif\n", "prefixes": [ "dpdk-dev" ] }