Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 37772,
    "url": "http://patches.dpdk.org/api/patches/37772/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/b4fe53189e469a14102934d59a536bebbad2538d.1523354362.git.anatoly.burakov@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<b4fe53189e469a14102934d59a536bebbad2538d.1523354362.git.anatoly.burakov@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/b4fe53189e469a14102934d59a536bebbad2538d.1523354362.git.anatoly.burakov@intel.com",
    "date": "2018-04-10T10:03:05",
    "name": "[dpdk-dev] eal/ipc: stop async IPC loop on callback request",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "9930dea91ada2c89146a3bd12907142e4ace6213",
    "submitter": {
        "id": 4,
        "url": "http://patches.dpdk.org/api/people/4/?format=api",
        "name": "Anatoly Burakov",
        "email": "anatoly.burakov@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/b4fe53189e469a14102934d59a536bebbad2538d.1523354362.git.anatoly.burakov@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/37772/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/37772/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E77291B8D4;\n\tTue, 10 Apr 2018 12:03:10 +0200 (CEST)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 2A75C1B888\n\tfor <dev@dpdk.org>; Tue, 10 Apr 2018 12:03:08 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Apr 2018 03:03:06 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 10 Apr 2018 03:03:06 -0700",
            "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw3AA35ne006967; Tue, 10 Apr 2018 11:03:05 +0100",
            "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w3AA35ia013021;\n\tTue, 10 Apr 2018 11:03:05 +0100",
            "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w3AA35nh013017;\n\tTue, 10 Apr 2018 11:03:05 +0100"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.48,431,1517904000\"; d=\"scan'208\";a=\"46618797\"",
        "From": "Anatoly Burakov <anatoly.burakov@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "jianfeng.tan@intel.com, anatoly.burakov@intel.com",
        "Date": "Tue, 10 Apr 2018 11:03:05 +0100",
        "Message-Id": "<b4fe53189e469a14102934d59a536bebbad2538d.1523354362.git.anatoly.burakov@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "Subject": "[dpdk-dev] [PATCH] eal/ipc: stop async IPC loop on callback request",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "EAL did not stop processing further asynchronous requests on\nencountering a request that should trigger the callback. This\nresulted in erasing valid requests but not triggering them.\n\nFix this by stopping the loop once we have a request that we\ncan trigger. Also, remove unnecessary check for trigger\nrequest being NULL.\n\nFixes: f05e26051c15 (\"eal: add IPC asynchronous request\")\nCc: anatoly.burakov@intel.com\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_proc.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex f98622f..1ea3b58 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -510,11 +510,11 @@ async_reply_handle(void *arg __rte_unused)\n \t\t\t\t\tTAILQ_REMOVE(&pending_requests.requests,\n \t\t\t\t\t\t\tsr, next);\n \t\t\t\t\tfree(sr);\n-\t\t\t\t} else if (action == ACTION_TRIGGER &&\n-\t\t\t\t\t\ttrigger == NULL) {\n+\t\t\t\t} else if (action == ACTION_TRIGGER) {\n \t\t\t\t\tTAILQ_REMOVE(&pending_requests.requests,\n \t\t\t\t\t\t\tsr, next);\n \t\t\t\t\ttrigger = sr;\n+\t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n \t\t}\n",
    "prefixes": [
        "dpdk-dev"
    ]
}