Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/37726/?format=api
{ "id": 37726, "url": "http://patches.dpdk.org/api/patches/37726/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/722e0dde55f774a94c0a6f882a7125bb368eabdd.1523296701.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<722e0dde55f774a94c0a6f882a7125bb368eabdd.1523296701.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/722e0dde55f774a94c0a6f882a7125bb368eabdd.1523296701.git.anatoly.burakov@intel.com", "date": "2018-04-09T18:01:02", "name": "[dpdk-dev,v5,59/70] eal: add secondary process init with memory hotplug", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ddfe18ef73f62aa60b2acb5a5159de57d781cbd4", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/722e0dde55f774a94c0a6f882a7125bb368eabdd.1523296701.git.anatoly.burakov@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/37726/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/37726/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 830941BA8E;\n\tMon, 9 Apr 2018 20:03:38 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 90A691B8E9\n\tfor <dev@dpdk.org>; Mon, 9 Apr 2018 20:02:07 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Apr 2018 11:02:07 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga004.fm.intel.com with ESMTP; 09 Apr 2018 11:02:03 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw39I22e3031397; Mon, 9 Apr 2018 19:02:02 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w39I22Xl028480;\n\tMon, 9 Apr 2018 19:02:02 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w39I22i2028473;\n\tMon, 9 Apr 2018 19:02:02 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.48,427,1517904000\"; d=\"scan'208\";a=\"44756788\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com,\n\tlaszlo.vadkeri@ericsson.com, benjamin.walker@intel.com,\n\tbruce.richardson@intel.com, thomas@monjalon.net,\n\tkonstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com,\n\tlouise.m.daly@intel.com, nelio.laranjeiro@6wind.com,\n\tyskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, \n\themant.agrawal@nxp.com, olivier.matz@6wind.com, shreyansh.jain@nxp.com,\n\tgowrishankar.m@linux.vnet.ibm.com", "Date": "Mon, 9 Apr 2018 19:01:02 +0100", "Message-Id": "<722e0dde55f774a94c0a6f882a7125bb368eabdd.1523296701.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1523296700.git.anatoly.burakov@intel.com>", "<cover.1523296700.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1523296700.git.anatoly.burakov@intel.com>", "<cover.1523218215.git.anatoly.burakov@intel.com>\n\t<cover.1523296700.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v5 59/70] eal: add secondary process init with\n\tmemory hotplug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Secondary initialization will just sync memory map with\nprimary process.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nTested-by: Santosh Shukla <Santosh.Shukla@caviumnetworks.com>\nTested-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n\nNotes:\n v3:\n - Improved handling of EAL hugepage info\n\n lib/librte_eal/common/eal_common_memory.c | 1 +\n lib/librte_eal/linuxapp/eal/eal_memory.c | 18 +++++++++++++++---\n 2 files changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex d519f15..fe5fdfc 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -20,6 +20,7 @@\n #include <rte_errno.h>\n #include <rte_log.h>\n \n+#include \"eal_memalloc.h\"\n #include \"eal_private.h\"\n #include \"eal_internal_cfg.h\"\n \ndiff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex efa1202..7ec7129 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -1776,6 +1776,18 @@ eal_legacy_hugepage_attach(void)\n \treturn -1;\n }\n \n+static int\n+eal_hugepage_attach(void)\n+{\n+\tif (eal_memalloc_sync_with_primary()) {\n+\t\tRTE_LOG(ERR, EAL, \"Could not map memory from primary process\\n\");\n+\t\tif (aslr_enabled() > 0)\n+\t\t\tRTE_LOG(ERR, EAL, \"It is recommended to disable ASLR in the kernel and retry running both primary and secondary processes\\n\");\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n int\n rte_eal_hugepage_init(void)\n {\n@@ -1787,9 +1799,9 @@ rte_eal_hugepage_init(void)\n int\n rte_eal_hugepage_attach(void)\n {\n-\tif (internal_config.legacy_mem)\n-\t\treturn eal_legacy_hugepage_attach();\n-\treturn -1;\n+\treturn internal_config.legacy_mem ?\n+\t\t\teal_legacy_hugepage_attach() :\n+\t\t\teal_hugepage_attach();\n }\n \n int\n", "prefixes": [ "dpdk-dev", "v5", "59/70" ] }