Patch Comment List
List patch comments
GET /api/patches/375/comments/?format=api
[ { "id": 769, "web_url": "http://patches.dpdk.org/comment/769/", "msgid": "<20140914083609.GA23464@mhcomputing.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20140914083609.GA23464@mhcomputing.net", "date": "2014-09-14T08:36:09", "subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "submitter": { "id": 37, "url": "http://patches.dpdk.org/api/people/37/?format=api", "name": "Matthew Hall", "email": "mhall@mhcomputing.net" }, "content": "On Sun, Sep 14, 2014 at 01:34:46AM -0700, Matthew Hall wrote:\n> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>\n> ---\n> lib/librte_eal/common/eal_common_log.c | 7 +++++++\n> lib/librte_eal/common/include/rte_log.h | 6 ++++++\n> 2 files changed, 13 insertions(+)\n\nI forgot to mention in the comments, this patch is helpful when you want \noutside code to cooperate with and respect log levels set in DPDK. Then you \ncan avoid using duplicate incompatible log code in the DPDK and non-DPDK parts \nof the app.\n\nMatthew.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7A10A5FEB;\n\tSun, 14 Sep 2014 10:31:05 +0200 (CEST)", "from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])\n\tby dpdk.org (Postfix) with ESMTP id 46CFA5901\n\tfor <dev@dpdk.org>; Sun, 14 Sep 2014 10:31:03 +0200 (CEST)", "by mail.mhcomputing.net (Postfix, from userid 1000)\n\tid 4166880C764; Sun, 14 Sep 2014 01:36:09 -0700 (PDT)" ], "Date": "Sun, 14 Sep 2014 01:36:09 -0700", "From": "Matthew Hall <mhall@mhcomputing.net>", "To": "dev@dpdk.org", "Message-ID": "<20140914083609.GA23464@mhcomputing.net>", "References": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "Subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 777, "web_url": "http://patches.dpdk.org/comment/777/", "msgid": "<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com", "date": "2014-09-15T08:14:57", "subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matthew Hall\n> Sent: Sunday, September 14, 2014 9:35 AM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH] librte_log: add function to retrieve log_level\n> \n> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n\n> ---\n> lib/librte_eal/common/eal_common_log.c | 7 +++++++\n> lib/librte_eal/common/include/rte_log.h | 6 ++++++\n> 2 files changed, 13 insertions(+)\n> \n> diff --git a/lib/librte_eal/common/eal_common_log.c\n> b/lib/librte_eal/common/eal_common_log.c\n> index e4df0b9..d979f28 100644\n> --- a/lib/librte_eal/common/eal_common_log.c\n> +++ b/lib/librte_eal/common/eal_common_log.c\n> @@ -176,6 +176,13 @@ rte_set_log_level(uint32_t level)\n> \trte_logs.level = (uint32_t)level;\n> }\n> \n> +/* Get global log level */\n> +uint32_t\n> +rte_get_log_level()\n> +{\n> +\treturn rte_logs.level;\n> +}\n> +\n> /* Set global log type */\n> void\n> rte_set_log_type(uint32_t type, int enable)\n> diff --git a/lib/librte_eal/common/include/rte_log.h\n> b/lib/librte_eal/common/include/rte_log.h\n> index 565415a..7f1c2f9 100644\n> --- a/lib/librte_eal/common/include/rte_log.h\n> +++ b/lib/librte_eal/common/include/rte_log.h\n> @@ -130,6 +130,12 @@ int rte_openlog_stream(FILE *f);\n> void rte_set_log_level(uint32_t level);\n> \n> /**\n> + * Get the global log level.\n> + *\n> + */\n> +uint32_t rte_get_log_level(void);\n> +\n> +/**\n> * Enable or disable the log type.\n> *\n> * @param type\n> --\n> 1.9.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C0F4D58E8;\n\tMon, 15 Sep 2014 10:09:33 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 7BA192E81\n\tfor <dev@dpdk.org>; Mon, 15 Sep 2014 10:09:31 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP; 15 Sep 2014 01:15:01 -0700", "from irsmsx103.ger.corp.intel.com ([163.33.3.157])\n\tby FMSMGA003.fm.intel.com with ESMTP; 15 Sep 2014 01:09:38 -0700", "from irsmsx155.ger.corp.intel.com (163.33.192.3) by\n\tIRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Mon, 15 Sep 2014 09:14:58 +0100", "from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by\n\tIRSMSX155.ger.corp.intel.com ([169.254.14.85]) with mapi id\n\t14.03.0195.001; Mon, 15 Sep 2014 09:14:58 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"386140086\"", "From": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "To": "Matthew Hall <mhall@mhcomputing.net>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "Thread-Index": "AQHPz/bYFLbQpI9mL0OFr1ca9ijjPJwB2jcg", "Date": "Mon, 15 Sep 2014 08:14:57 +0000", "Message-ID": "<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>", "References": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>", "In-Reply-To": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>", "Accept-Language": "en-GB, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.182]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 778, "web_url": "http://patches.dpdk.org/comment/778/", "msgid": "<515e4bf4-8e68-4d46-bf05-677e02717768@email.android.com>", "list_archive_url": "https://inbox.dpdk.org/dev/515e4bf4-8e68-4d46-bf05-677e02717768@email.android.com", "date": "2014-09-15T08:16:37", "subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "submitter": { "id": 37, "url": "http://patches.dpdk.org/api/people/37/?format=api", "name": "Matthew Hall", "email": "mhall@mhcomputing.net" }, "content": "Thanks for the ack Bruce! Used this one to clean up a lot of grubby app-side code and I hate forking open source for too long if it can be avoided.\n\nMatthew.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A7A4658E8;\n\tMon, 15 Sep 2014 10:11:23 +0200 (CEST)", "from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])\n\tby dpdk.org (Postfix) with ESMTP id A583C3976\n\tfor <dev@dpdk.org>; Mon, 15 Sep 2014 10:11:20 +0200 (CEST)", "from android-fb5fc4f6ed62fb42.attlocal.net\n\t(99-34-229-174.lightspeed.sntcca.sbcglobal.net [99.34.229.174])\n\tby mail.mhcomputing.net (Postfix) with ESMTPSA id 13AB180C764;\n\tMon, 15 Sep 2014 01:16:31 -0700 (PDT)" ], "User-Agent": "K-9 Mail for Android", "In-Reply-To": "<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>", "References": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>\n\t<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain;\n charset=UTF-8", "From": "Matthew Hall <mhall@mhcomputing.net>", "Date": "Mon, 15 Sep 2014 01:16:37 -0700", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>,\n\t\"dev@dpdk.org\" <dev@dpdk.org>", "Message-ID": "<515e4bf4-8e68-4d46-bf05-677e02717768@email.android.com>", "Subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 780, "web_url": "http://patches.dpdk.org/comment/780/", "msgid": "<59AF69C657FD0841A61C55336867B5B0343F1631@IRSMSX103.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/59AF69C657FD0841A61C55336867B5B0343F1631@IRSMSX103.ger.corp.intel.com", "date": "2014-09-15T08:20:32", "subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "> -----Original Message-----\r\n> From: Matthew Hall [mailto:mhall@mhcomputing.net]\r\n> Sent: Monday, September 15, 2014 9:17 AM\r\n> To: Richardson, Bruce; dev@dpdk.org\r\n> Subject: RE: [dpdk-dev] [PATCH] librte_log: add function to retrieve log_level\r\n> \r\n> Thanks for the ack Bruce! Used this one to clean up a lot of grubby app-side\r\n> code and I hate forking open source for too long if it can be avoided.\r\n\r\nNo problem. With such huge patches as this the code review takes many hours of strenuous effort! :-)\r\n\r\n/Bruce\r\n> \r\n> Matthew.\r\n> --\r\n> Sent from my mobile device.\r\n> \r\n> On September 15, 2014 1:14:57 AM PDT, \"Richardson, Bruce\"\r\n> <bruce.richardson@intel.com> wrote:\r\n> >> -----Original Message-----\r\n> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matthew Hall\r\n> >> Sent: Sunday, September 14, 2014 9:35 AM\r\n> >> To: dev@dpdk.org\r\n> >> Subject: [dpdk-dev] [PATCH] librte_log: add function to retrieve\r\n> >log_level\r\n> >>\r\n> >> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>\r\n> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>\r\n> >\r\n> >> ---\r\n> >> lib/librte_eal/common/eal_common_log.c | 7 +++++++\r\n> >> lib/librte_eal/common/include/rte_log.h | 6 ++++++\r\n> >> 2 files changed, 13 insertions(+)\r\n> >>\r\n> >> diff --git a/lib/librte_eal/common/eal_common_log.c\r\n> >> b/lib/librte_eal/common/eal_common_log.c\r\n> >> index e4df0b9..d979f28 100644\r\n> >> --- a/lib/librte_eal/common/eal_common_log.c\r\n> >> +++ b/lib/librte_eal/common/eal_common_log.c\r\n> >> @@ -176,6 +176,13 @@ rte_set_log_level(uint32_t level)\r\n> >> \trte_logs.level = (uint32_t)level;\r\n> >> }\r\n> >>\r\n> >> +/* Get global log level */\r\n> >> +uint32_t\r\n> >> +rte_get_log_level()\r\n> >> +{\r\n> >> +\treturn rte_logs.level;\r\n> >> +}\r\n> >> +\r\n> >> /* Set global log type */\r\n> >> void\r\n> >> rte_set_log_type(uint32_t type, int enable)\r\n> >> diff --git a/lib/librte_eal/common/include/rte_log.h\r\n> >> b/lib/librte_eal/common/include/rte_log.h\r\n> >> index 565415a..7f1c2f9 100644\r\n> >> --- a/lib/librte_eal/common/include/rte_log.h\r\n> >> +++ b/lib/librte_eal/common/include/rte_log.h\r\n> >> @@ -130,6 +130,12 @@ int rte_openlog_stream(FILE *f);\r\n> >> void rte_set_log_level(uint32_t level);\r\n> >>\r\n> >> /**\r\n> >> + * Get the global log level.\r\n> >> + *\r\n> >> + */\r\n> >> +uint32_t rte_get_log_level(void);\r\n> >> +\r\n> >> +/**\r\n> >> * Enable or disable the log type.\r\n> >> *\r\n> >> * @param type\r\n> >> --\r\n> >> 1.9.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DCE3B595B;\n\tMon, 15 Sep 2014 10:16:23 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 436FC2E81\n\tfor <dev@dpdk.org>; Mon, 15 Sep 2014 10:16:22 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 15 Sep 2014 01:21:52 -0700", "from irsmsx101.ger.corp.intel.com ([163.33.3.153])\n\tby fmsmga002.fm.intel.com with ESMTP; 15 Sep 2014 01:21:51 -0700", "from irsmsx108.ger.corp.intel.com (163.33.3.3) by\n\tIRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Mon, 15 Sep 2014 09:20:32 +0100", "from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by\n\tIRSMSX108.ger.corp.intel.com ([169.254.11.157]) with mapi id\n\t14.03.0195.001; Mon, 15 Sep 2014 09:20:32 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,526,1406617200\"; d=\"scan'208\";a=\"599620568\"", "From": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "To": "Matthew Hall <mhall@mhcomputing.net>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "Thread-Index": "AQHPz/bYFLbQpI9mL0OFr1ca9ijjPJwB2jcg///v1ICAABGkIA==", "Date": "Mon, 15 Sep 2014 08:20:32 +0000", "Message-ID": "<59AF69C657FD0841A61C55336867B5B0343F1631@IRSMSX103.ger.corp.intel.com>", "References": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>\n\t<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>\n\t<515e4bf4-8e68-4d46-bf05-677e02717768@email.android.com>", "In-Reply-To": "<515e4bf4-8e68-4d46-bf05-677e02717768@email.android.com>", "Accept-Language": "en-GB, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.182]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 781, "web_url": "http://patches.dpdk.org/comment/781/", "msgid": "<7acf8142-e89a-4535-8b54-00323cee406a@email.android.com>", "list_archive_url": "https://inbox.dpdk.org/dev/7acf8142-e89a-4535-8b54-00323cee406a@email.android.com", "date": "2014-09-15T08:24:41", "subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "submitter": { "id": 37, "url": "http://patches.dpdk.org/api/people/37/?format=api", "name": "Matthew Hall", "email": "mhall@mhcomputing.net" }, "content": "The real effort was the client-side cleanup. I had to get rid of pages of logs for every packet flowing through and I hate yanking out logs... but some of them call weird functions like memdump and pktmbuf_dump. There's no good way to clean those up without a function to check the current loglevel. And reaching into private structs to get it seemed like an uncivilized thing to do.\n\nGood news is, another couple weeks and some Coverity patches and I'll have shareable code to hand out.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CB14C68FD;\n\tMon, 15 Sep 2014 10:19:16 +0200 (CEST)", "from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])\n\tby dpdk.org (Postfix) with ESMTP id 951E8595B\n\tfor <dev@dpdk.org>; Mon, 15 Sep 2014 10:19:14 +0200 (CEST)", "from android-fb5fc4f6ed62fb42.attlocal.net\n\t(99-34-229-174.lightspeed.sntcca.sbcglobal.net [99.34.229.174])\n\tby mail.mhcomputing.net (Postfix) with ESMTPSA id 54A3880C764;\n\tMon, 15 Sep 2014 01:24:25 -0700 (PDT)" ], "User-Agent": "K-9 Mail for Android", "In-Reply-To": "<59AF69C657FD0841A61C55336867B5B0343F1631@IRSMSX103.ger.corp.intel.com>", "References": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>\n\t<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>\n\t<515e4bf4-8e68-4d46-bf05-677e02717768@email.android.com>\n\t<59AF69C657FD0841A61C55336867B5B0343F1631@IRSMSX103.ger.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain;\n charset=UTF-8", "From": "Matthew Hall <mhall@mhcomputing.net>", "Date": "Mon, 15 Sep 2014 01:24:41 -0700", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>,\n\t\"dev@dpdk.org\" <dev@dpdk.org>", "Message-ID": "<7acf8142-e89a-4535-8b54-00323cee406a@email.android.com>", "Subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 857, "web_url": "http://patches.dpdk.org/comment/857/", "msgid": "<3563815.8jcoVSoRJA@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/3563815.8jcoVSoRJA@xps13", "date": "2014-09-18T13:29:11", "subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "> > Signed-off-by: Matthew Hall <mhall@mhcomputing.net>\n> \n> Acked-by: Bruce Richardson <bruce.richardson@intel.com>\n\n> > +/* Get global log level */\n> > +uint32_t\n> > +rte_get_log_level()\n\nvoid is missing here\n\nApplied with fix and commit log which was sent later.\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F3EFFB3A6;\n\tThu, 18 Sep 2014 15:23:36 +0200 (CEST)", "from mail-wi0-f172.google.com (mail-wi0-f172.google.com\n\t[209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 14F2868C2\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 15:23:36 +0200 (CEST)", "by mail-wi0-f172.google.com with SMTP id hi2so214323wib.5\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 06:29:21 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tq13sm3002252wik.8.2014.09.18.06.29.20 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 18 Sep 2014 06:29:20 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=WQATyF1yocak4hgFxCCo8o6WocBUEEbLVzgqtL9bOz8=;\n\tb=hc9EDfTirPp/lN4t8fEIiIUw9F9aCRpRiSAnD4TRYcrzy5LeApxgetmpdNOI12fKVa\n\t8W3XJI9FwstKyK6G/LmCF+6Pe08s2SHl7tNkkC5qPHkj2rvIANLYvyZXBQjYN2zm3SVq\n\tn4pbDJQpa7MqSzKmOsZngPADadHusu01+NAmo3/8AfirxpURhKLs9LUfU/H2/SczywpI\n\tmMNwzoVVTWbSYgcME1x3on+cqe2A+zfNSP016aE2E2+hlZI+U2AVvSt50fDh31HG2Imn\n\t+7C8a4xeNWwPpsFiEBVUTXe93fTBwcFG9cMQ7OpDr7obUTtNMBSkCvDmfIUp7h7LeEC5\n\tS4uw==", "X-Gm-Message-State": "ALoCoQlm79drvqtGQvlApLqPDcQvXEI7eFJpWkQkIanbFGddVlXRCdY7/TNUR0+msoC2vQCdOwaP", "X-Received": "by 10.195.11.200 with SMTP id ek8mr4939244wjd.85.1411046961687; \n\tThu, 18 Sep 2014 06:29:21 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Matthew Hall <mhall@mhcomputing.net>", "Date": "Thu, 18 Sep 2014 15:29:11 +0200", "Message-ID": "<3563815.8jcoVSoRJA@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>", "References": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>\n\t<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 874, "web_url": "http://patches.dpdk.org/comment/874/", "msgid": "<20140918202537.GA24891@mhcomputing.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20140918202537.GA24891@mhcomputing.net", "date": "2014-09-18T20:25:37", "subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "submitter": { "id": 37, "url": "http://patches.dpdk.org/api/people/37/?format=api", "name": "Matthew Hall", "email": "mhall@mhcomputing.net" }, "content": "On Thu, Sep 18, 2014 at 03:29:11PM +0200, Thomas Monjalon wrote:\n> void is missing here\n\nAh yes, sorry for missing it.\n\nThanks for correcting and applying, glad to have it available upstream.\n\nMatthew.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 09B23B3A3;\n\tThu, 18 Sep 2014 22:20:17 +0200 (CEST)", "from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])\n\tby dpdk.org (Postfix) with ESMTP id C0E62B39B\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 22:20:13 +0200 (CEST)", "by mail.mhcomputing.net (Postfix, from userid 1000)\n\tid 30FA380C764; Thu, 18 Sep 2014 13:25:37 -0700 (PDT)" ], "Date": "Thu, 18 Sep 2014 13:25:37 -0700", "From": "Matthew Hall <mhall@mhcomputing.net>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Message-ID": "<20140918202537.GA24891@mhcomputing.net>", "References": "<1410683686-12389-1-git-send-email-mhall@mhcomputing.net>\n\t<59AF69C657FD0841A61C55336867B5B0343F15D6@IRSMSX103.ger.corp.intel.com>\n\t<3563815.8jcoVSoRJA@xps13>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<3563815.8jcoVSoRJA@xps13>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] librte_log: add function to retrieve\n\tlog_level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]