Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3741/?format=api
{ "id": 3741, "url": "http://patches.dpdk.org/api/patches/3741/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1424917922-1979-6-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1424917922-1979-6-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1424917922-1979-6-git-send-email-stephen@networkplumber.org", "date": "2015-02-26T02:32:01", "name": "[dpdk-dev,6/7] vmxnet3: support RSS and refactor offload", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "82c8dc43435ffc6649fa057e4b82c732e5e23a72", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1424917922-1979-6-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/3741/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/3741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C33AF5A6F;\n\tThu, 26 Feb 2015 03:32:16 +0100 (CET)", "from mail-ie0-f170.google.com (mail-ie0-f170.google.com\n\t[209.85.223.170]) by dpdk.org (Postfix) with ESMTP id CEFE05A44\n\tfor <dev@dpdk.org>; Thu, 26 Feb 2015 03:32:10 +0100 (CET)", "by iebtr6 with SMTP id tr6so10428707ieb.7\n\tfor <dev@dpdk.org>; Wed, 25 Feb 2015 18:32:10 -0800 (PST)", "from urahara.brocade.com\n\t(static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155])\n\tby mx.google.com with ESMTPSA id y5sm336741ign.7.2015.02.25.18.32.09\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 25 Feb 2015 18:32:09 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=xH2jj3yJe4iTlDZ+M9+oMu6yrxjlhprUdqxKsM3ueaM=;\n\tb=VsYCN19n6Sde6E3MhTgmsAzxO0E0+JoiU3c5CvOuBMnNoS/TuAxXp6xBFJZRi5aahg\n\tOKh3An36NXrD7EVEtTm8m0cS3uUdYw3GLD2ar7d76bQcQS9HsWUZlNQ5owHapppp9jB6\n\twJK0FxwF/gO4ZMsBQFg5not0Yco3dUxnAzQSL5sZ4SQdrrkPH+VfJv5DCKFOhbum91z+\n\tpwwCzpglHLv+uG31fJF2PSX2Fx0eRz1X196umN7G8MvVdOemx6vhDd0kR21hfmHSXgaP\n\t67ayiD+ae74W7iMWjGp29eBH97Rq1zbDx2kA22bbxoMIxj77IwncJdGa7t2dpRXj3Vk3\n\tB9Fw==", "X-Gm-Message-State": "ALoCoQmCg3Yo/RDITJJjNNO1RYKbMmKLrN7OGeVdGC+nAXVrJgfJdMwpgkpvDqmchCkQOZzFD0mQ", "X-Received": "by 10.43.20.71 with SMTP id qn7mr7386123icb.47.1424917930386;\n\tWed, 25 Feb 2015 18:32:10 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Yong Wang <yongwang@vmware.com>", "Date": "Wed, 25 Feb 2015 18:32:01 -0800", "Message-Id": "<1424917922-1979-6-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1424917922-1979-1-git-send-email-stephen@networkplumber.org>", "References": "<1424917922-1979-1-git-send-email-stephen@networkplumber.org>", "Cc": "dev@dpdk.org, Bill Hong <bhong@brocade.com>", "Subject": "[dpdk-dev] [PATCH 6/7] vmxnet3: support RSS and refactor offload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Refactor the logic to compute receive offload flags to a simpler\nfunction. And add support for putting RSS flow hash into packet.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Bill Hong <bhong@brocade.com>\n---\n lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 69 ++++++++++++++++++++---------------\n 1 file changed, 40 insertions(+), 29 deletions(-)", "diff": "diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c\nindex 884b57f..82bcae6 100644\n--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c\n+++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c\n@@ -505,6 +505,43 @@ vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t *rxq, uint8_t ring_id)\n \t\treturn i;\n }\n \n+\n+/* Receive side checksum and other offloads */\n+static void\n+vmxnet3_rx_offload(const Vmxnet3_RxCompDesc *rcd, struct rte_mbuf *rxm)\n+{\n+\t/* Check for hardware stripped VLAN tag */\n+\tif (rcd->ts) {\n+\t\trxm->ol_flags |= PKT_RX_VLAN_PKT;\n+\t\trxm->vlan_tci = rte_le_to_cpu_16((uint16_t)rcd->tci);\n+\t}\n+\n+\t/* Check for RSS */\n+\tif (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE) {\n+\t\trxm->ol_flags |= PKT_RX_RSS_HASH;\n+\t\trxm->hash.rss = rcd->rssHash;\n+\t}\n+\n+\t/* Check packet type, checksum errors, etc. Only support IPv4 for now. */\n+\tif (rcd->v4) {\n+\t\tstruct ether_hdr *eth = rte_pktmbuf_mtod(rxm, struct ether_hdr *);\n+\t\tstruct ipv4_hdr *ip = (struct ipv4_hdr *)(eth + 1);\n+\n+\t\tif (((ip->version_ihl & 0xf) << 2) > (int)sizeof(struct ipv4_hdr))\n+\t\t\trxm->ol_flags |= PKT_RX_IPV4_HDR_EXT;\n+\t\telse\n+\t\t\trxm->ol_flags |= PKT_RX_IPV4_HDR;\n+\n+\t\tif (!rcd->cnc) {\n+\t\t\tif (!rcd->ipc)\n+\t\t\t\trxm->ol_flags |= PKT_RX_IP_CKSUM_BAD;\n+\n+\t\t\tif ((rcd->tcp || rcd->udp) && !rcd->tuc)\n+\t\t\t\trxm->ol_flags |= PKT_RX_L4_CKSUM_BAD;\n+\t\t}\n+\t}\n+}\n+\n /*\n * Process the Rx Completion Ring of given vmxnet3_rx_queue\n * for nb_pkts burst and return the number of packets received\n@@ -605,17 +642,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\t\tgoto rcd_done;\n \t\t}\n \n-\t\t/* Check for hardware stripped VLAN tag */\n-\t\tif (rcd->ts) {\n-\t\t\tPMD_RX_LOG(DEBUG, \"Received packet with vlan ID: %d.\",\n-\t\t\t\t rcd->tci);\n-\t\t\trxm->ol_flags = PKT_RX_VLAN_PKT;\n-\t\t\t/* Copy vlan tag in packet buffer */\n-\t\t\trxm->vlan_tci = rte_le_to_cpu_16((uint16_t)rcd->tci);\n-\t\t} else {\n-\t\t\trxm->ol_flags = 0;\n-\t\t\trxm->vlan_tci = 0;\n-\t\t}\n \n \t\t/* Initialize newly received packet buffer */\n \t\trxm->port = rxq->port_id;\n@@ -624,25 +650,10 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\trxm->pkt_len = (uint16_t)rcd->len;\n \t\trxm->data_len = (uint16_t)rcd->len;\n \t\trxm->data_off = RTE_PKTMBUF_HEADROOM;\n+\t\trxm->ol_flags = 0;\n+\t\trxm->vlan_tci = 0;\n \n-\t\t/* Check packet type, checksum errors, etc. Only support IPv4 for now. */\n-\t\tif (rcd->v4) {\n-\t\t\tstruct ether_hdr *eth = rte_pktmbuf_mtod(rxm, struct ether_hdr *);\n-\t\t\tstruct ipv4_hdr *ip = (struct ipv4_hdr *)(eth + 1);\n-\n-\t\t\tif (((ip->version_ihl & 0xf) << 2) > (int)sizeof(struct ipv4_hdr))\n-\t\t\t\trxm->ol_flags |= PKT_RX_IPV4_HDR_EXT;\n-\t\t\telse\n-\t\t\t\trxm->ol_flags |= PKT_RX_IPV4_HDR;\n-\n-\t\t\tif (!rcd->cnc) {\n-\t\t\t\tif (!rcd->ipc)\n-\t\t\t\t\trxm->ol_flags |= PKT_RX_IP_CKSUM_BAD;\n-\n-\t\t\t\tif ((rcd->tcp || rcd->udp) && !rcd->tuc)\n-\t\t\t\t\trxm->ol_flags |= PKT_RX_L4_CKSUM_BAD;\n-\t\t\t}\n-\t\t}\n+\t\tvmxnet3_rx_offload(rcd, rxm);\n \n \t\trx_pkts[nb_rx++] = rxm;\n rcd_done:\n", "prefixes": [ "dpdk-dev", "6/7" ] }