Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3740/?format=api
{ "id": 3740, "url": "http://patches.dpdk.org/api/patches/3740/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1424917922-1979-5-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1424917922-1979-5-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1424917922-1979-5-git-send-email-stephen@networkplumber.org", "date": "2015-02-26T02:32:00", "name": "[dpdk-dev,5/7] vmxnet3: fix link state handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9f68b8a3d3497a7ab7470adb5b685d6a7e50def9", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1424917922-1979-5-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/3740/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/3740/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B58B25A67;\n\tThu, 26 Feb 2015 03:32:15 +0100 (CET)", "from mail-ie0-f171.google.com (mail-ie0-f171.google.com\n\t[209.85.223.171]) by dpdk.org (Postfix) with ESMTP id 9C5D35A54\n\tfor <dev@dpdk.org>; Thu, 26 Feb 2015 03:32:09 +0100 (CET)", "by iebtr6 with SMTP id tr6so10427068ieb.10\n\tfor <dev@dpdk.org>; Wed, 25 Feb 2015 18:32:09 -0800 (PST)", "from urahara.brocade.com\n\t(static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155])\n\tby mx.google.com with ESMTPSA id y5sm336741ign.7.2015.02.25.18.32.08\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 25 Feb 2015 18:32:08 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=UpAdEQJfFy8PVT/j3BR6+s6/I6+iSqrC0LKOY5PUxvk=;\n\tb=Vb8PeQsILtd/Ewe4zZtsf2rw9CItHEUFEykL8GKic/oWHc7KzkYEG9zaakDnKGNcsb\n\tko9r8ZnMg8i5ObUla6s5AkGS/SF0KrhPxRZUJcxvixdFTSA/TRp60t9Y4nWSG3eGQfIO\n\tbM3HvzmCtcquOgxXltJTY/6fzdwiiRjdmxahPhTSoWS3yu30szV8kjQ9AhGpSOM1cPen\n\t5KOOyNWXeYLFlgRHV9bZ7N837XRQ2zdhsJCI3Gs2hZH65tjlM9vPCBnoV9eGPj1fHHPm\n\tXHncbdDiVcYVfF9kpxvOHB0DFhSPvVMEB6HvZN9qUD9aaObbdpv/V46Fd/RgRCxudHsI\n\tyQqg==", "X-Gm-Message-State": "ALoCoQlq9bp7bS16x/3FLOW4YPrt5TdjYKqq9v5zPgNwakVkvMPeCTWdRAmVIfvntnK6E9XFe6ed", "X-Received": "by 10.42.71.194 with SMTP id l2mr7129899icj.71.1424917929168;\n\tWed, 25 Feb 2015 18:32:09 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Yong Wang <yongwang@vmware.com>", "Date": "Wed, 25 Feb 2015 18:32:00 -0800", "Message-Id": "<1424917922-1979-5-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1424917922-1979-1-git-send-email-stephen@networkplumber.org>", "References": "<1424917922-1979-1-git-send-email-stephen@networkplumber.org>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH 5/7] vmxnet3: fix link state handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The Intel version of VMXNET3 driver does not handle link state properly.\nThe VMXNET3 API returns 1 if connected and 0 if disconnected.\nAlso need to return correct value to indicate state change.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Yong Wang <yongwang@vmware.com>\n---\n lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 54 ++++++++++++++++++++++++---------\n 1 file changed, 39 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c\nindex 570565a..35bb561 100644\n--- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c\n+++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c\n@@ -157,9 +157,36 @@ gpa_zone_reserve(struct rte_eth_dev *dev, uint32_t size,\n * - On success, zero.\n * - On failure, negative value.\n */\n-static inline int\n-rte_vmxnet3_dev_atomic_write_link_status(struct rte_eth_dev *dev,\n-\t\t\t\tstruct rte_eth_link *link)\n+\n+static int\n+vmxnet3_dev_atomic_read_link_status(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_link *link)\n+{\n+\tstruct rte_eth_link *dst = link;\n+\tstruct rte_eth_link *src = &(dev->data->dev_link);\n+\n+\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n+\t\t\t\t*(uint64_t *)src) == 0)\n+\t\treturn -1;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * Atomically writes the link status information into global\n+ * structure rte_eth_dev.\n+ *\n+ * @param dev\n+ * - Pointer to the structure rte_eth_dev to write to.\n+ * - Pointer to the buffer to be saved with the link status.\n+ *\n+ * @return\n+ * - On success, zero.\n+ * - On failure, negative value.\n+ */\n+static int\n+vmxnet3_dev_atomic_write_link_status(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_link *link)\n {\n \tstruct rte_eth_link *dst = &(dev->data->dev_link);\n \tstruct rte_eth_link *src = link;\n@@ -391,6 +418,7 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)\n \tdevRead->misc.driverInfo.vmxnet3RevSpt = 1;\n \tdevRead->misc.driverInfo.uptVerSpt = 1;\n \n+\tdevRead->misc.mtu = rte_le_to_cpu_32(dev->data->mtu);\n \tdevRead->misc.queueDescPA = hw->queueDescPA;\n \tdevRead->misc.queueDescLen = hw->queue_desc_len;\n \tdevRead->misc.numTxQueues = hw->num_tx_queues;\n@@ -576,7 +604,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)\n \n \t/* Clear recorded link status */\n \tmemset(&link, 0, sizeof(link));\n-\trte_vmxnet3_dev_atomic_write_link_status(dev, &link);\n+\tvmxnet3_dev_atomic_write_link_status(dev, &link);\n }\n \n /*\n@@ -659,28 +687,24 @@ static int\n vmxnet3_dev_link_update(struct rte_eth_dev *dev, __attribute__((unused)) int wait_to_complete)\n {\n \tstruct vmxnet3_hw *hw = dev->data->dev_private;\n-\tstruct rte_eth_link link;\n+\tstruct rte_eth_link old, link;\n \tuint32_t ret;\n \n+\tmemset(&link, 0, sizeof(link));\n+\tvmxnet3_dev_atomic_read_link_status(dev, &old);\n+\n \tVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_LINK);\n \tret = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);\n \n-\tif (!ret) {\n-\t\tPMD_INIT_LOG(ERR, \"Link Status Negative : %s()\", __func__);\n-\t\treturn -1;\n-\t}\n-\n \tif (ret & 0x1) {\n \t\tlink.link_status = 1;\n \t\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n \t\tlink.link_speed = ETH_LINK_SPEED_10000;\n-\n-\t\trte_vmxnet3_dev_atomic_write_link_status(dev, &link);\n-\n-\t\treturn 0;\n \t}\n \n-\treturn -1;\n+\tvmxnet3_dev_atomic_write_link_status(dev, &link);\n+\n+\treturn (old.link_status == link.link_status) ? -1 : 0;\n }\n \n /* Updating rxmode through Vmxnet3_DriverShared structure in adapter */\n", "prefixes": [ "dpdk-dev", "5/7" ] }