Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/36069/?format=api
http://patches.dpdk.org/api/patches/36069/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/93ee478f82ef8e026e82d20f0f073a5c5d228c4f.1520953064.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<93ee478f82ef8e026e82d20f0f073a5c5d228c4f.1520953064.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/93ee478f82ef8e026e82d20f0f073a5c5d228c4f.1520953064.git.anatoly.burakov@intel.com", "date": "2018-03-13T17:42:36", "name": "[dpdk-dev,v6,2/6] eal: abstract away IPC socket path generation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9b0120c15bab89c7a456e5d0f31217fa72cd76ed", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/93ee478f82ef8e026e82d20f0f073a5c5d228c4f.1520953064.git.anatoly.burakov@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/36069/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/36069/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 37F964C8F;\n\tTue, 13 Mar 2018 18:42:48 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id F017C2BDF\n\tfor <dev@dpdk.org>; Tue, 13 Mar 2018 18:42:45 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Mar 2018 10:42:44 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga004.fm.intel.com with ESMTP; 13 Mar 2018 10:42:43 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw2DHgg2k003082; Tue, 13 Mar 2018 17:42:42 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w2DHggLl025237;\n\tTue, 13 Mar 2018 17:42:42 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w2DHggxn025233;\n\tTue, 13 Mar 2018 17:42:42 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.47,465,1515484800\"; d=\"scan'208\";a=\"37015583\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "jianfeng.tan@intel.com, keith.wiles@intel.com,\n\tkonstantin.ananyev@intel.com", "Date": "Tue, 13 Mar 2018 17:42:36 +0000", "Message-Id": "<93ee478f82ef8e026e82d20f0f073a5c5d228c4f.1520953064.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1520953064.git.anatoly.burakov@intel.com>", "<cover.1520953064.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1520953064.git.anatoly.burakov@intel.com>", "<cover.1520424998.git.anatoly.burakov@intel.com>\n\t<cover.1520953064.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v6 2/6] eal: abstract away IPC socket path\n\tgeneration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n\nNotes:\n v5: remove lock files, leaving only socket paths code\n \n v4: replace lock files with init files\n\n lib/librte_eal/common/eal_common_proc.c | 48 ++++++++++++++++-----------------\n 1 file changed, 23 insertions(+), 25 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex da7930f..1aab3ac 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -91,6 +91,17 @@ find_sync_request(const char *dst, const char *act_name)\n \treturn r;\n }\n \n+static void\n+create_socket_path(const char *name, char *buf, int len)\n+{\n+\tconst char *prefix = eal_mp_socket_path();\n+\n+\tif (strlen(name) > 0)\n+\t\tsnprintf(buf, len, \"%s_%s\", prefix, name);\n+\telse\n+\t\tsnprintf(buf, len, \"%s\", prefix);\n+}\n+\n int\n rte_eal_primary_proc_alive(const char *config_file_path)\n {\n@@ -290,8 +301,12 @@ mp_handle(void *arg __rte_unused)\n static int\n open_socket_fd(void)\n {\n+\tchar peer_name[PATH_MAX] = {0};\n \tstruct sockaddr_un un;\n-\tconst char *prefix = eal_mp_socket_path();\n+\n+\tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n+\t\tsnprintf(peer_name, sizeof(peer_name),\n+\t\t\t\t\"%d_%\"PRIx64, getpid(), rte_rdtsc());\n \n \tmp_fd = socket(AF_UNIX, SOCK_DGRAM, 0);\n \tif (mp_fd < 0) {\n@@ -301,13 +316,11 @@ open_socket_fd(void)\n \n \tmemset(&un, 0, sizeof(un));\n \tun.sun_family = AF_UNIX;\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\tsnprintf(un.sun_path, sizeof(un.sun_path), \"%s\", prefix);\n-\telse {\n-\t\tsnprintf(un.sun_path, sizeof(un.sun_path), \"%s_%d_%\"PRIx64,\n-\t\t\t prefix, getpid(), rte_rdtsc());\n-\t}\n+\n+\tcreate_socket_path(peer_name, un.sun_path, sizeof(un.sun_path));\n+\n \tunlink(un.sun_path); /* May still exist since last run */\n+\n \tif (bind(mp_fd, (struct sockaddr *)&un, sizeof(un)) < 0) {\n \t\tRTE_LOG(ERR, EAL, \"failed to bind %s: %s\\n\",\n \t\t\tun.sun_path, strerror(errno));\n@@ -342,20 +355,6 @@ unlink_sockets(const char *filter)\n \treturn 0;\n }\n \n-static void\n-unlink_socket_by_path(const char *path)\n-{\n-\tchar *filename;\n-\tchar *fullpath = strdup(path);\n-\n-\tif (!fullpath)\n-\t\treturn;\n-\tfilename = basename(fullpath);\n-\tunlink_sockets(filename);\n-\tfree(fullpath);\n-\tRTE_LOG(INFO, EAL, \"Remove socket %s\\n\", path);\n-}\n-\n int\n rte_mp_channel_init(void)\n {\n@@ -444,10 +443,9 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int type)\n \tif (snd < 0) {\n \t\trte_errno = errno;\n \t\t/* Check if it caused by peer process exits */\n-\t\tif (errno == ECONNREFUSED) {\n-\t\t\t/* We don't unlink the primary's socket here */\n-\t\t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\t\t\tunlink_socket_by_path(dst_path);\n+\t\tif (errno == ECONNREFUSED &&\n+\t\t\t\trte_eal_process_type() == RTE_PROC_PRIMARY) {\n+\t\t\tunlink(dst_path);\n \t\t\treturn 0;\n \t\t}\n \t\tif (errno == ENOBUFS) {\n", "prefixes": [ "dpdk-dev", "v6", "2/6" ] }{ "id": 36069, "url": "