Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35473/?format=api
{ "id": 35473, "url": "http://patches.dpdk.org/api/patches/35473/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/64b3f5748e9f99b141da323a837e151983f5cf5b.1519672713.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<64b3f5748e9f99b141da323a837e151983f5cf5b.1519672713.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/64b3f5748e9f99b141da323a837e151983f5cf5b.1519672713.git.anatoly.burakov@intel.com", "date": "2018-02-27T13:23:26", "name": "[dpdk-dev,v2,5/5] eal: don't hardcode socket filter value in IPC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6d9023cf3792539b7cecdbbaa924719fa8e3a5cd", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/64b3f5748e9f99b141da323a837e151983f5cf5b.1519672713.git.anatoly.burakov@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35473/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/35473/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 39FC95F2F;\n\tTue, 27 Feb 2018 14:23:34 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id E2C485B30\n\tfor <dev@dpdk.org>; Tue, 27 Feb 2018 14:23:30 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Feb 2018 05:23:29 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 27 Feb 2018 05:23:29 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw1RDNSJn023821; Tue, 27 Feb 2018 13:23:28 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w1RDNSiA016080;\n\tTue, 27 Feb 2018 13:23:28 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w1RDNR5c016015;\n\tTue, 27 Feb 2018 13:23:27 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.47,401,1515484800\"; d=\"scan'208\";a=\"23567455\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "jianfeng.tan@intel.com", "Date": "Tue, 27 Feb 2018 13:23:26 +0000", "Message-Id": "<64b3f5748e9f99b141da323a837e151983f5cf5b.1519672713.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<31f6d9ef676fb1eb0a664c06d62d66f32876dcb6.1519672713.git.anatoly.burakov@intel.com>", "<31f6d9ef676fb1eb0a664c06d62d66f32876dcb6.1519322682.git.anatoly.burakov@intel.com>" ], "References": [ "<31f6d9ef676fb1eb0a664c06d62d66f32876dcb6.1519672713.git.anatoly.burakov@intel.com>", "<31f6d9ef676fb1eb0a664c06d62d66f32876dcb6.1519322682.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v2 5/5] eal: don't hardcode socket filter value\n\tin IPC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, filter value is hardcoded and disconnected from actual\nvalue returned by eal_mp_socket_path(). Fix this to generate filter\nvalue by deriving it from eal_mp_socket_path() instead.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n v2: added this patch\n\n lib/librte_eal/common/eal_common_proc.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex 82ea4a7..bdea6d6 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -504,16 +504,17 @@ int\n rte_mp_channel_init(void)\n {\n \tchar thread_name[RTE_MAX_THREAD_NAME_LEN];\n-\tchar *path;\n+\tchar path[PATH_MAX];\n \tint dir_fd;\n \tpthread_t tid;\n \n-\tsnprintf(mp_filter, PATH_MAX, \".%s_unix_*\",\n-\t\t internal_config.hugefile_prefix);\n+\t/* create filter path */\n+\tcreate_socket_path(\"*\", path, sizeof(path));\n+\tsnprintf(mp_filter, sizeof(mp_filter), \"%s\", basename(path));\n \n-\tpath = strdup(eal_mp_socket_path());\n-\tsnprintf(mp_dir_path, PATH_MAX, \"%s\", dirname(path));\n-\tfree(path);\n+\t/* path may have been modified, so recreate it */\n+\tcreate_socket_path(\"*\", path, sizeof(path));\n+\tsnprintf(mp_dir_path, sizeof(mp_dir_path), \"%s\", dirname(path));\n \n \t/* lock the directory */\n \tdir_fd = open(mp_dir_path, O_RDONLY);\n", "prefixes": [ "dpdk-dev", "v2", "5/5" ] }