Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35358/?format=api
{ "id": 35358, "url": "http://patches.dpdk.org/api/patches/35358/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180222181910.23134-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180222181910.23134-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180222181910.23134-2-maxime.coquelin@redhat.com", "date": "2018-02-22T18:19:08", "name": "[dpdk-dev,RFC,1/3] vhost: invalidate vring addresses in cleanup_vq()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "27018ac78bab378022f06c8b2792e7d04bda6a31", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180222181910.23134-2-maxime.coquelin@redhat.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35358/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35358/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E97FC1B16F;\n\tThu, 22 Feb 2018 19:19:33 +0100 (CET)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id CA8C01B161\n\tfor <dev@dpdk.org>; Thu, 22 Feb 2018 19:19:32 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 44BC98182D0C;\n\tThu, 22 Feb 2018 18:19:32 +0000 (UTC)", "from localhost.localdomain (ovpn-112-33.ams2.redhat.com\n\t[10.36.112.33])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 21AF11055536;\n\tThu, 22 Feb 2018 18:19:29 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "jianfeng.tan@intel.com, stefanha@redhat.com, tiwei.bie@intel.com,\n\tjfreimann@redhat.com, dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 22 Feb 2018 19:19:08 +0100", "Message-Id": "<20180222181910.23134-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180222181910.23134-1-maxime.coquelin@redhat.com>", "References": "<20180222181910.23134-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.3", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.8]); Thu, 22 Feb 2018 18:19:32 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.8]); \n\tThu, 22 Feb 2018 18:19:32 +0000 (UTC) for IP:'10.11.54.3'\n\tDOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [RFC 1/3] vhost: invalidate vring addresses in\n\tcleanup_vq()", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When cleaning-up the virtqueue, we also need to invalidate its\naddresses to be sure outdated addresses won't be used later.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost.c | 6 ++++--\n lib/librte_vhost/vhost.h | 4 +++-\n lib/librte_vhost/vhost_user.c | 2 +-\n 3 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c\nindex f6f12a03b..e4281cf67 100644\n--- a/lib/librte_vhost/vhost.c\n+++ b/lib/librte_vhost/vhost.c\n@@ -69,12 +69,14 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,\n }\n \n void\n-cleanup_vq(struct vhost_virtqueue *vq, int destroy)\n+cleanup_vq(struct virtio_net *dev, struct vhost_virtqueue *vq, int destroy)\n {\n \tif ((vq->callfd >= 0) && (destroy != 0))\n \t\tclose(vq->callfd);\n \tif (vq->kickfd >= 0)\n \t\tclose(vq->kickfd);\n+\n+\tvring_invalidate(dev, vq);\n }\n \n /*\n@@ -89,7 +91,7 @@ cleanup_device(struct virtio_net *dev, int destroy)\n \tvhost_backend_cleanup(dev);\n \n \tfor (i = 0; i < dev->nr_vring; i++)\n-\t\tcleanup_vq(dev->virtqueue[i], destroy);\n+\t\tcleanup_vq(dev, dev->virtqueue[i], destroy);\n }\n \n void\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 58aec2e0d..4ebf84bec 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -241,6 +241,7 @@ struct virtio_net {\n \tstruct guest_page *guest_pages;\n \n \tint\t\t\tslave_req_fd;\n+\tuint8_t\t\tvirtio_status;\n } __rte_cache_aligned;\n \n \n@@ -362,7 +363,8 @@ void cleanup_device(struct virtio_net *dev, int destroy);\n void reset_device(struct virtio_net *dev);\n void vhost_destroy_device(int);\n \n-void cleanup_vq(struct vhost_virtqueue *vq, int destroy);\n+void cleanup_vq(struct virtio_net *dev, struct vhost_virtqueue *vq,\n+\t\t\t\tint destroy);\n void free_vq(struct vhost_virtqueue *vq);\n \n int alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx);\ndiff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 5c5361066..c256ebb06 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -219,7 +219,7 @@ vhost_user_set_features(struct virtio_net *dev, uint64_t features)\n \t\t\t\tcontinue;\n \n \t\t\tdev->virtqueue[dev->nr_vring] = NULL;\n-\t\t\tcleanup_vq(vq, 1);\n+\t\t\tcleanup_vq(dev, vq, 1);\n \t\t\tfree_vq(vq);\n \t\t}\n \t}\n", "prefixes": [ "dpdk-dev", "RFC", "1/3" ] }