Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35355,
    "url": "http://patches.dpdk.org/api/patches/35355/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180222172033.302037-1-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180222172033.302037-1-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180222172033.302037-1-bruce.richardson@intel.com",
    "date": "2018-02-22T17:20:33",
    "name": "[dpdk-dev] net/pcap: simplify dependency checking using meson",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "84058f78d5b76d8daf02de19b229654702aade4e",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 10,
        "url": "http://patches.dpdk.org/api/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180222172033.302037-1-bruce.richardson@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35355/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35355/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DD1DC29CB;\n\tThu, 22 Feb 2018 18:20:39 +0100 (CET)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 10BA029CA\n\tfor <dev@dpdk.org>; Thu, 22 Feb 2018 18:20:38 +0100 (CET)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Feb 2018 09:20:37 -0800",
            "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby fmsmga004.fm.intel.com with ESMTP; 22 Feb 2018 09:20:37 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.47,378,1515484800\"; d=\"scan'208\";a=\"32027176\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Bruce Richardson <bruce.richardson@intel.com>",
        "Date": "Thu, 22 Feb 2018 17:20:33 +0000",
        "Message-Id": "<20180222172033.302037-1-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.14.3",
        "Subject": "[dpdk-dev] [PATCH] net/pcap: simplify dependency checking using\n\tmeson",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Rather than trying to use meson's build-in detection for libpcap, and\nhaving to special-case cross-building, just check for the presence of\npcap.h and the pcap library.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/pcap/meson.build | 20 +++++---------------\n 1 file changed, 5 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/drivers/net/pcap/meson.build b/drivers/net/pcap/meson.build\nindex 8b81214e5..0c4e0201a 100644\n--- a/drivers/net/pcap/meson.build\n+++ b/drivers/net/pcap/meson.build\n@@ -1,22 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-if meson.is_cross_build()\n-\tpcap_dep = cc.find_library('pcap', required: false)\n-\tif pcap_dep.found()\n-\t\text_deps += pcap_dep\n-\telse\n-\t\tbuild = false\n-\tendif\n+pcap_dep = cc.find_library('pcap', required: false)\n+if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)\n+\tbuild = true\n else\n-\tpcap_dep = dependency('pcap', required: false)\n-\tif pcap_dep.found() == true\n-\t\text_deps += pcap_dep\n-\telif find_program('pcap-config', required: false).found() == true\n-\t\text_deps += cc.find_library('pcap')\n-\telse\n-\t\tbuild = false\n-\tendif\n+\tbuild = false\n endif\n sources = files('rte_eth_pcap.c')\n+ext_deps += pcap_dep\n pkgconfig_extra_libs += '-lpcap'\n",
    "prefixes": [
        "dpdk-dev"
    ]
}