Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35335/?format=api
{ "id": 35335, "url": "http://patches.dpdk.org/api/patches/35335/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180222025822.18421-1-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180222025822.18421-1-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180222025822.18421-1-somnath.kotur@broadcom.com", "date": "2018-02-22T02:58:22", "name": "[dpdk-dev] net/bnxt: Fix bug with duplicate filter pattern for flow director", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b033f4ed7b2c71296976c8f2466bb44b9d600d08", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180222025822.18421-1-somnath.kotur@broadcom.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35335/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35335/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6F0885598;\n\tThu, 22 Feb 2018 04:03:07 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n\t[192.19.211.62]) by dpdk.org (Postfix) with ESMTP id ACEA5324B\n\tfor <dev@dpdk.org>; Thu, 22 Feb 2018 04:03:06 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n\t(dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n\tby relay.smtp.broadcom.com (Postfix) with ESMTP id 83DE0280450\n\tfor <dev@dpdk.org>; Wed, 21 Feb 2018 19:03:05 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 83DE0280450", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1519268585;\n\tbh=8SFuPJidBmb1UJY+V34qowv01reGgnNeM67YlO3dBik=;\n\th=From:To:Subject:Date:From;\n\tb=j1GHRYezB1p+V0NGz6odfXEqbwS0kHxIXT64y6hwolcv1hwywoStIHu/ByYiu+Y4a\n\tXlzbIFxY4hOWYUqOOU5lYJXuAKVe0gslqUF6SbzbageJJGj+OPWfjeseegSYZ3Ckav\n\tcoXp4YO1XolDEZvNAqAMihl9mZ1Pyyl3/lsmHWEc=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Date": "Thu, 22 Feb 2018 08:28:22 +0530", "Message-Id": "<20180222025822.18421-1-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "Subject": "[dpdk-dev] [PATCH] net/bnxt: Fix bug with duplicate filter pattern\n\tfor flow director", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When user reissues same flow director cmd with a different queue\nupdate the existing filter to redirect flow to the new desired\nqueue as destination just like the other filters like 5 tuple and\ngeneric flow.\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 45 ++++++++++++++++++++++++++++++------------\n 1 file changed, 32 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 21c46f8..b47a2fb 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -2358,7 +2358,8 @@ bnxt_parse_fdir_filter(struct bnxt *bp,\n }\n \n static struct bnxt_filter_info *\n-bnxt_match_fdir(struct bnxt *bp, struct bnxt_filter_info *nf)\n+bnxt_match_fdir(struct bnxt *bp, struct bnxt_filter_info *nf,\n+\t\tstruct bnxt_vnic_info **mvnic)\n {\n \tstruct bnxt_filter_info *mf = NULL;\n \tint i;\n@@ -2396,8 +2397,11 @@ bnxt_match_fdir(struct bnxt *bp, struct bnxt_filter_info *nf)\n \t\t\t !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,\n \t\t\t\t sizeof(nf->dst_ipaddr)) &&\n \t\t\t !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,\n-\t\t\t\t sizeof(nf->dst_ipaddr_mask)))\n+\t\t\t\t sizeof(nf->dst_ipaddr_mask))) {\n+\t\t\t\tif (mvnic)\n+\t\t\t\t\t*mvnic = vnic;\n \t\t\t\treturn mf;\n+\t\t\t}\n \t\t}\n \t}\n \treturn NULL;\n@@ -2411,7 +2415,7 @@ bnxt_fdir_filter(struct rte_eth_dev *dev,\n \tstruct bnxt *bp = (struct bnxt *)dev->data->dev_private;\n \tstruct rte_eth_fdir_filter *fdir = (struct rte_eth_fdir_filter *)arg;\n \tstruct bnxt_filter_info *filter, *match;\n-\tstruct bnxt_vnic_info *vnic;\n+\tstruct bnxt_vnic_info *vnic, *mvnic;\n \tint ret = 0, i;\n \n \tif (filter_op == RTE_ETH_FILTER_NOP)\n@@ -2436,11 +2440,32 @@ bnxt_fdir_filter(struct rte_eth_dev *dev,\n \t\t\tgoto free_filter;\n \t\tfilter->filter_type = HWRM_CFA_NTUPLE_FILTER;\n \n-\t\tmatch = bnxt_match_fdir(bp, filter);\n+\t\tif (fdir->action.behavior == RTE_ETH_FDIR_REJECT)\n+\t\t\tvnic = STAILQ_FIRST(&bp->ff_pool[0]);\n+\t\telse\n+\t\t\tvnic =\n+\t\t\tSTAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]);\n+\n+\t\tmatch = bnxt_match_fdir(bp, filter, &mvnic);\n \t\tif (match != NULL && filter_op == RTE_ETH_FILTER_ADD) {\n-\t\t\tPMD_DRV_LOG(ERR, \"Flow already exists.\\n\");\n-\t\t\tret = -EEXIST;\n-\t\t\tgoto free_filter;\n+\t\t\tif (match->dst_id == vnic->fw_vnic_id) {\n+\t\t\t\tPMD_DRV_LOG(ERR, \"Flow already exists.\\n\");\n+\t\t\t\tret = -EEXIST;\n+\t\t\t\tgoto free_filter;\n+\t\t\t} else {\n+\t\t\t\tmatch->dst_id = vnic->fw_vnic_id;\n+\t\t\t\tret = bnxt_hwrm_set_ntuple_filter(bp,\n+\t\t\t\t\t\t\t\t match->dst_id,\n+\t\t\t\t\t\t\t\t match);\n+\t\t\t\tSTAILQ_REMOVE(&mvnic->filter, match,\n+\t\t\t\t\t bnxt_filter_info, next);\n+\t\t\t\tSTAILQ_INSERT_TAIL(&vnic->filter, match, next);\n+\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t\"Filter with matching pattern exist\\n\");\n+\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t\"Updated it to new destination q\\n\");\n+\t\t\t\tgoto free_filter;\n+\t\t\t}\n \t\t}\n \t\tif (match == NULL && filter_op == RTE_ETH_FILTER_DELETE) {\n \t\t\tPMD_DRV_LOG(ERR, \"Flow does not exist.\\n\");\n@@ -2448,12 +2473,6 @@ bnxt_fdir_filter(struct rte_eth_dev *dev,\n \t\t\tgoto free_filter;\n \t\t}\n \n-\t\tif (fdir->action.behavior == RTE_ETH_FDIR_REJECT)\n-\t\t\tvnic = STAILQ_FIRST(&bp->ff_pool[0]);\n-\t\telse\n-\t\t\tvnic =\n-\t\t\tSTAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]);\n-\n \t\tif (filter_op == RTE_ETH_FILTER_ADD) {\n \t\t\tret = bnxt_hwrm_set_ntuple_filter(bp,\n \t\t\t\t\t\t\t filter->dst_id,\n", "prefixes": [ "dpdk-dev" ] }