Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35331,
    "url": "http://patches.dpdk.org/api/patches/35331/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519222460-14605-9-git-send-email-tdu@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1519222460-14605-9-git-send-email-tdu@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1519222460-14605-9-git-send-email-tdu@semihalf.com",
    "date": "2018-02-21T14:14:20",
    "name": "[dpdk-dev,8/8] net/mrvl: add Tx queue start/stop",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "63754dbc59317e0f7f2985b967cd889f014e13be",
    "submitter": {
        "id": 846,
        "url": "http://patches.dpdk.org/api/people/846/?format=api",
        "name": "Tomasz Duszynski",
        "email": "tdu@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519222460-14605-9-git-send-email-tdu@semihalf.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35331/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35331/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6ADE41B2C0;\n\tWed, 21 Feb 2018 15:14:45 +0100 (CET)",
            "from mail-lf0-f68.google.com (mail-lf0-f68.google.com\n\t[209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 75EB41B1D9\n\tfor <dev@dpdk.org>; Wed, 21 Feb 2018 15:14:41 +0100 (CET)",
            "by mail-lf0-f68.google.com with SMTP id 37so2548801lfs.7\n\tfor <dev@dpdk.org>; Wed, 21 Feb 2018 06:14:41 -0800 (PST)",
            "from sh.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\te27sm5038177lff.89.2018.02.21.06.14.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 21 Feb 2018 06:14:40 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=VyQG7K2YJcdAGeubCYK6Xr2ft+lf5nicEsBP1v2iS3Y=;\n\tb=lkq6y7nIny4NTPQCpR70/SYqR8hyAyEUyqCAqGJvKTIgfmRt9wlvWtJyw3PXwkPe5i\n\tgFMqI5bdNGyfCqxa4lpeHKn0CBTOwtS9AFxnFEr4Sz2JRKJUxaop7E+5YEZBtLzqvE+Q\n\tv23rH2sFfrWtzv01PeDnM9CpqU1GoZK1zlYX+hknOcVEahkL+/hMfEzgeSXChdIi/K09\n\tRtwwnFtgo9M1864/MHOU8/iomMPLa2GRyxZ9dZvzjkFc3/vbYvGeH94+HLFNc/VHMIm0\n\tisv3AOf9HWGaSKi4mSqjiG9ZfQf+c9FtJBmlc/xv4PySCUws5Y9mtAZ8hLmcEMZ4Phff\n\tbsfQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=VyQG7K2YJcdAGeubCYK6Xr2ft+lf5nicEsBP1v2iS3Y=;\n\tb=hnrqMoh5yrEgeP7NkYppZzcRXiA1EGJ36HS+CCtM/UTCNnFL+DR/hUGwcqwMja2gCx\n\tStacQzMHRdg3yQyXOm/r+TdjjxUYc+cVibeYTpVA3nJedKMh15sAAYddber0m+J2nPM2\n\teUcFW9bZ+wC2qJuMlTG1NrBQ2SyDaRWr/RRTQc/iroCLcjHTlynwSBt6gRA8c4s1o1KJ\n\tK5nJ5gSp2p6zgn7W1kjV6/jG0wWEevhu8CtKLVJiWFcphAnEDncX3F3LiOSYSldXUJsI\n\tosuS+HnjQdSYYFScKetIh+t509yAbf/jrdqc2jmL9X5ZIRyLrdQQDwbEaEKozb6449o2\n\tjyPw==",
        "X-Gm-Message-State": "APf1xPBY47ArrIapIcngzGdJ64PKTJNCyov6dZ9ZniOCNIhvIP86CTEU\n\tsxXVhG8s9gh57qqO08NyOrtmgb/R8Mc=",
        "X-Google-Smtp-Source": "AH8x225BEWgOCbr/1uCGdM6XVf3nDe/cBHF5RYDl9tYdfN1D8gQdN1dHsOUvirPCy26bkeRdUWwpWA==",
        "X-Received": "by 10.25.16.197 with SMTP id 66mr2661025lfq.86.1519222480871;\n\tWed, 21 Feb 2018 06:14:40 -0800 (PST)",
        "From": "Tomasz Duszynski <tdu@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, jck@semihalf.com,\n\tTomasz Duszynski <tdu@semihalf.com>",
        "Date": "Wed, 21 Feb 2018 15:14:20 +0100",
        "Message-Id": "<1519222460-14605-9-git-send-email-tdu@semihalf.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1519222460-14605-1-git-send-email-tdu@semihalf.com>",
        "References": "<1519222460-14605-1-git-send-email-tdu@semihalf.com>",
        "Subject": "[dpdk-dev] [PATCH 8/8] net/mrvl: add Tx queue start/stop",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add Tx queue start/stop feature.\n\nSigned-off-by: Natalie Samsonov <nsamsono@marvell.com>\nSigned-off-by: Tomasz Duszynski <tdu@semihalf.com>\n---\n doc/guides/nics/mrvl.rst       |  1 +\n drivers/net/mrvl/mrvl_ethdev.c | 92 +++++++++++++++++++++++++++++++++++++++++-\n 2 files changed, 91 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst\nindex 550bd79..f9ec9d6 100644\n--- a/doc/guides/nics/mrvl.rst\n+++ b/doc/guides/nics/mrvl.rst\n@@ -73,6 +73,7 @@ Features of the MRVL PMD are:\n - Extended stats\n - QoS\n - RX flow control\n+- TX queue start/stop\n \n \n Limitations\ndiff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c\nindex 08c0b03..20b045a 100644\n--- a/drivers/net/mrvl/mrvl_ethdev.c\n+++ b/drivers/net/mrvl/mrvl_ethdev.c\n@@ -162,6 +162,7 @@ struct mrvl_txq {\n \tint port_id;\n \tuint64_t bytes_sent;\n \tstruct mrvl_shadow_txq shadow_txqs[RTE_MAX_LCORE];\n+\tint tx_deferred_start;\n };\n \n static int mrvl_lcore_first;\n@@ -487,6 +488,70 @@ mrvl_dev_set_link_down(struct rte_eth_dev *dev)\n }\n \n /**\n+ * DPDK callback to start tx queue.\n+ *\n+ * @param dev\n+ *   Pointer to Ethernet device structure.\n+ * @param queue_id\n+ *   Transmit queue index.\n+ *\n+ * @return\n+ *   0 on success, negative error value otherwise.\n+ */\n+static int\n+mrvl_tx_queue_start(struct rte_eth_dev *dev, uint16_t queue_id)\n+{\n+\tstruct mrvl_priv *priv = dev->data->dev_private;\n+\tint ret;\n+\n+\tif (!priv)\n+\t\treturn -EPERM;\n+\n+\t/* passing 1 enables given tx queue */\n+\tret = pp2_ppio_set_outq_state(priv->ppio, queue_id, 1);\n+\tif (ret) {\n+\t\tRTE_LOG(ERR, PMD, \"Failed to start txq %d\\n\", queue_id);\n+\t\treturn ret;\n+\t}\n+\n+\tdev->data->tx_queue_state[queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * DPDK callback to stop tx queue.\n+ *\n+ * @param dev\n+ *   Pointer to Ethernet device structure.\n+ * @param queue_id\n+ *   Transmit queue index.\n+ *\n+ * @return\n+ *   0 on success, negative error value otherwise.\n+ */\n+static int\n+mrvl_tx_queue_stop(struct rte_eth_dev *dev, uint16_t queue_id)\n+{\n+\tstruct mrvl_priv *priv = dev->data->dev_private;\n+\tint ret;\n+\n+\tif (!priv->ppio)\n+\t\treturn -EPERM;\n+\n+\t/* passing 0 disables given tx queue */\n+\tret = pp2_ppio_set_outq_state(priv->ppio, queue_id, 0);\n+\tif (ret) {\n+\t\tRTE_LOG(ERR, PMD, \"Failed to stop txq %d\\n\", queue_id);\n+\t\treturn ret;\n+\t}\n+\n+\tdev->data->tx_queue_state[queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\n+\treturn 0;\n+}\n+\n+/**\n  * DPDK callback to start the device.\n  *\n  * @param dev\n@@ -500,7 +565,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n {\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tchar match[MRVL_MATCH_LEN];\n-\tint ret = 0, def_init_size;\n+\tint ret = 0, i, def_init_size;\n \n \tsnprintf(match, sizeof(match), \"ppio-%d:%d\",\n \t\t priv->pp_id, priv->ppio_id);\n@@ -587,6 +652,24 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \t\tgoto out;\n \t}\n \n+\t/* start tx queues */\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct mrvl_txq *txq = dev->data->tx_queues[i];\n+\n+\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n+\n+\t\tif (!txq->tx_deferred_start)\n+\t\t\tcontinue;\n+\n+\t\t/*\n+\t\t * All txqs are started by default. Stop them\n+\t\t * so that tx_deferred_start works as expected.\n+\t\t */\n+\t\tret = mrvl_tx_queue_stop(dev, i);\n+\t\tif (ret)\n+\t\t\tgoto out;\n+\t}\n+\n \treturn 0;\n out:\n \tRTE_LOG(ERR, PMD, \"Failed to start device\\n\");\n@@ -1358,9 +1441,11 @@ static void mrvl_txq_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \t\t\t      struct rte_eth_txq_info *qinfo)\n {\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n+\tstruct mrvl_txq *txq = dev->data->tx_queues[tx_queue_id];\n \n \tqinfo->nb_desc =\n \t\tpriv->ppio_params.outqs_params.outqs_params[tx_queue_id].size;\n+\tqinfo->conf.tx_deferred_start = txq->tx_deferred_start;\n }\n \n /**\n@@ -1671,7 +1756,7 @@ mrvl_tx_queue_offloads_okay(struct rte_eth_dev *dev, uint64_t requested)\n  * @param socket\n  *   NUMA socket on which memory must be allocated.\n  * @param conf\n- *   Thresholds parameters.\n+ *   Tx queue configuration parameters.\n  *\n  * @return\n  *   0 on success, negative error value otherwise.\n@@ -1699,6 +1784,7 @@ mrvl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \ttxq->priv = priv;\n \ttxq->queue_id = idx;\n \ttxq->port_id = dev->data->port_id;\n+\ttxq->tx_deferred_start = conf->tx_deferred_start;\n \tdev->data->tx_queues[idx] = txq;\n \n \tpriv->ppio_params.outqs_params.outqs_params[idx].size = desc;\n@@ -2002,6 +2088,8 @@ static const struct eth_dev_ops mrvl_ops = {\n \t.rxq_info_get = mrvl_rxq_info_get,\n \t.txq_info_get = mrvl_txq_info_get,\n \t.vlan_filter_set = mrvl_vlan_filter_set,\n+\t.tx_queue_start = mrvl_tx_queue_start,\n+\t.tx_queue_stop = mrvl_tx_queue_stop,\n \t.rx_queue_setup = mrvl_rx_queue_setup,\n \t.rx_queue_release = mrvl_rx_queue_release,\n \t.tx_queue_setup = mrvl_tx_queue_setup,\n",
    "prefixes": [
        "dpdk-dev",
        "8/8"
    ]
}