Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35304,
    "url": "http://patches.dpdk.org/api/patches/35304/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519134742-22648-1-git-send-email-radu.nicolau@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1519134742-22648-1-git-send-email-radu.nicolau@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1519134742-22648-1-git-send-email-radu.nicolau@intel.com",
    "date": "2018-02-20T13:52:22",
    "name": "[dpdk-dev,v3] app/procinfo: fix strncpy count issue",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ea35de2074e09a8908f6e1de64ab2728e7313d28",
    "submitter": {
        "id": 743,
        "url": "http://patches.dpdk.org/api/people/743/?format=api",
        "name": "Radu Nicolau",
        "email": "radu.nicolau@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519134742-22648-1-git-send-email-radu.nicolau@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35304/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35304/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 73895A49A;\n\tTue, 20 Feb 2018 14:57:40 +0100 (CET)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 97E812C66;\n\tTue, 20 Feb 2018 14:57:38 +0100 (CET)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Feb 2018 05:57:37 -0800",
            "from silpixa00383879.ir.intel.com (HELO\n\tsilpixa00383879.ger.corp.intel.com) ([10.237.223.127])\n\tby orsmga002.jf.intel.com with ESMTP; 20 Feb 2018 05:57:35 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,539,1511856000\"; d=\"scan'208\";a=\"36068984\"",
        "From": "Radu Nicolau <radu.nicolau@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "john.mcnamara@intel.com, maryam.tahhan@intel.com, reshma.pattan@intel.com,\n\tbruce.richardson@intel.com, Radu Nicolau <radu.nicolau@intel.com>,\n\tstable@dpdk.org",
        "Date": "Tue, 20 Feb 2018 13:52:22 +0000",
        "Message-Id": "<1519134742-22648-1-git-send-email-radu.nicolau@intel.com>",
        "X-Mailer": "git-send-email 2.7.5",
        "In-Reply-To": "<1519131621-10053-1-git-send-email-radu.nicolau@intel.com>",
        "References": "<1519131621-10053-1-git-send-email-radu.nicolau@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3] app/procinfo: fix strncpy count issue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Replace strncpy with snprintf to avoid overwriting the last\nNULL character.\n\nFixes: 2deb6b5246d7 (\"app/procinfo: add collectd format and host id\")\nCoverity issue: 143252\n\nCc: stable@dpdk.org\n\nSigned-off-by: Radu Nicolau <radu.nicolau@intel.com>\n---\nv3: replaced strncpy with snprintf\n\n app/proc_info/main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/app/proc_info/main.c b/app/proc_info/main.c\nindex 2f53e3c..f90c144 100644\n--- a/app/proc_info/main.c\n+++ b/app/proc_info/main.c\n@@ -159,7 +159,7 @@ proc_info_preparse_args(int argc, char **argv)\n \t\t\t\tproc_info_usage(prgname);\n \t\t\t\treturn -1;\n \t\t\t}\n-\t\t\tstrncpy(host_id, argv[i+1], sizeof(host_id));\n+\t\t\tsnprintf(host_id, sizeof(host_id), \"%s\", argv[i+1]);\n \t\t}\n \t}\n \n",
    "prefixes": [
        "dpdk-dev",
        "v3"
    ]
}