Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35300/?format=api
{ "id": 35300, "url": "http://patches.dpdk.org/api/patches/35300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519128357-8987-1-git-send-email-radu.nicolau@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1519128357-8987-1-git-send-email-radu.nicolau@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1519128357-8987-1-git-send-email-radu.nicolau@intel.com", "date": "2018-02-20T12:05:57", "name": "[dpdk-dev] examples/exception_path: limit core count to 64", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c38416216b8965d3d9390a8df7997e4f2551e5fb", "submitter": { "id": 743, "url": "http://patches.dpdk.org/api/people/743/?format=api", "name": "Radu Nicolau", "email": "radu.nicolau@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519128357-8987-1-git-send-email-radu.nicolau@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35300/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A5D792BF1;\n\tTue, 20 Feb 2018 13:11:16 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id E32AA2BF1;\n\tTue, 20 Feb 2018 13:11:14 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Feb 2018 04:11:13 -0800", "from silpixa00383879.ir.intel.com (HELO\n\tsilpixa00383879.ger.corp.intel.com) ([10.237.223.127])\n\tby orsmga008.jf.intel.com with ESMTP; 20 Feb 2018 04:11:11 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,539,1511856000\"; d=\"scan'208\";a=\"19430235\"", "From": "Radu Nicolau <radu.nicolau@intel.com>", "To": "dev@dpdk.org", "Cc": "john.mcnamara@intel.com, thomas@monjalon.net,\n\tRadu Nicolau <radu.nicolau@intel.com>, stable@dpdk.org", "Date": "Tue, 20 Feb 2018 12:05:57 +0000", "Message-Id": "<1519128357-8987-1-git-send-email-radu.nicolau@intel.com>", "X-Mailer": "git-send-email 2.7.5", "Subject": "[dpdk-dev] [PATCH] examples/exception_path: limit core count to 64", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Application doesn't support more that 64 lcores due to command\nline limitation of using a coremask that is parsed as a 64bit\nvalue, so changed it to reflect this limitation.\n\nFixes: af75078fece3 (\"first public release\")\nCoverity issue: 30688\n\nCc: stable@dpdk.org\n\nSigned-off-by: Radu Nicolau <radu.nicolau@intel.com>\n---\n examples/exception_path/main.c | 18 ++++++++++++++----\n 1 file changed, 14 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c\nindex 3e5b1e7..dda391c 100644\n--- a/examples/exception_path/main.c\n+++ b/examples/exception_path/main.c\n@@ -41,13 +41,21 @@\n #include <rte_string_fns.h>\n #include <rte_cycles.h>\n \n+#ifndef APP_MAX_LCORE\n+#if (RTE_MAX_LCORE > 64)\n+#define APP_MAX_LCORE 64\n+#else\n+#define APP_MAX_LCORE RTE_MAX_LCORE\n+#endif\n+#endif\n+\n /* Macros for printing using RTE_LOG */\n #define RTE_LOGTYPE_APP RTE_LOGTYPE_USER1\n #define FATAL_ERROR(fmt, args...) rte_exit(EXIT_FAILURE, fmt \"\\n\", ##args)\n #define PRINT_INFO(fmt, args...) RTE_LOG(INFO, APP, fmt \"\\n\", ##args)\n \n /* Max ports than can be used (each port is associated with two lcores) */\n-#define MAX_PORTS (RTE_MAX_LCORE / 2)\n+#define MAX_PORTS (APP_MAX_LCORE / 2)\n \n /* Max size of a single packet */\n #define MAX_PACKET_SZ (2048)\n@@ -101,7 +109,7 @@ static uint64_t input_cores_mask = 0;\n static uint64_t output_cores_mask = 0;\n \n /* Array storing port_id that is associated with each lcore */\n-static uint16_t port_ids[RTE_MAX_LCORE];\n+static uint16_t port_ids[APP_MAX_LCORE];\n \n /* Structure type for recording lcore-specific stats */\n struct stats {\n@@ -111,7 +119,7 @@ struct stats {\n } __rte_cache_aligned;\n \n /* Array of lcore-specific stats */\n-static struct stats lcore_stats[RTE_MAX_LCORE];\n+static struct stats lcore_stats[APP_MAX_LCORE];\n \n /* Print out statistics on packets handled */\n static void\n@@ -330,7 +338,9 @@ setup_port_lcore_affinities(void)\n \tuint16_t rx_port = 0;\n \n \t/* Setup port_ids[] array, and check masks were ok */\n-\tRTE_LCORE_FOREACH(i) {\n+\tfor (i = 0; i < APP_MAX_LCORE; i++) {\n+\t\tif (!rte_lcore_is_enabled(i))\n+\t\t\tcontinue;\n \t\tif (input_cores_mask & (1ULL << i)) {\n \t\t\t/* Skip ports that are not enabled */\n \t\t\twhile ((ports_mask & (1 << rx_port)) == 0) {\n", "prefixes": [ "dpdk-dev" ] }