Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35253,
    "url": "http://patches.dpdk.org/api/patches/35253/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519112078-20113-78-git-send-email-arybchenko@solarflare.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1519112078-20113-78-git-send-email-arybchenko@solarflare.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1519112078-20113-78-git-send-email-arybchenko@solarflare.com",
    "date": "2018-02-20T07:34:35",
    "name": "[dpdk-dev,77/80] net/sfc/base: add outer IP ID parameter to TSOv2 descriptor",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "25491895ff74e8c603547ab69db22a11d615c76e",
    "submitter": {
        "id": 607,
        "url": "http://patches.dpdk.org/api/people/607/?format=api",
        "name": "Andrew Rybchenko",
        "email": "arybchenko@solarflare.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519112078-20113-78-git-send-email-arybchenko@solarflare.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35253/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/35253/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5A26F1B33A;\n\tTue, 20 Feb 2018 08:35:48 +0100 (CET)",
            "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id C5CB41B1C6\n\tfor <dev@dpdk.org>; Tue, 20 Feb 2018 08:35:23 +0100 (CET)",
            "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tD11706C0053 for <dev@dpdk.org>; Tue, 20 Feb 2018 07:35:22 +0000 (UTC)",
            "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 19 Feb 2018 23:35:16 -0800",
            "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 19 Feb 2018 23:35:16 -0800",
            "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw1K7ZFDA025298; Tue, 20 Feb 2018 07:35:15 GMT",
            "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw1K7ZBuT020529; Tue, 20 Feb 2018 07:35:15 GMT"
        ],
        "X-Virus-Scanned": "Proofpoint Essentials engine",
        "From": "Andrew Rybchenko <arybchenko@solarflare.com>",
        "To": "<dev@dpdk.org>",
        "CC": "Vijay Srivastava <vijays@solarflare.com>",
        "Date": "Tue, 20 Feb 2018 07:34:35 +0000",
        "Message-ID": "<1519112078-20113-78-git-send-email-arybchenko@solarflare.com>",
        "X-Mailer": "git-send-email 1.8.2.3",
        "In-Reply-To": "<1519112078-20113-1-git-send-email-arybchenko@solarflare.com>",
        "References": "<1519112078-20113-1-git-send-email-arybchenko@solarflare.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-MDID": "1519112123-iKM8zGi127cy",
        "Subject": "[dpdk-dev] [PATCH 77/80] net/sfc/base: add outer IP ID parameter to\n\tTSOv2 descriptor",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Vijay Srivastava <vijays@solarflare.com>\n\nSet outer_ip_id in the TX option descriptor for encapsulated packets.\n\nSigned-off-by: Vijay Srivastava <vijays@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_impl.h | 1 +\n drivers/net/sfc/base/ef10_tx.c   | 4 +++-\n drivers/net/sfc/base/efx.h       | 1 +\n drivers/net/sfc/base/efx_impl.h  | 2 +-\n drivers/net/sfc/base/efx_tx.c    | 4 +++-\n drivers/net/sfc/sfc_tso.c        | 3 ++-\n 6 files changed, 11 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/sfc/base/ef10_impl.h b/drivers/net/sfc/base/ef10_impl.h\nindex 20155f8..7089a60 100644\n--- a/drivers/net/sfc/base/ef10_impl.h\n+++ b/drivers/net/sfc/base/ef10_impl.h\n@@ -756,6 +756,7 @@ extern\tvoid\n ef10_tx_qdesc_tso2_create(\n \t__in\t\t\tefx_txq_t *etp,\n \t__in\t\t\tuint16_t ipv4_id,\n+\t__in\t\t\tuint16_t outer_ipv4_id,\n \t__in\t\t\tuint32_t tcp_seq,\n \t__in\t\t\tuint16_t tcp_mss,\n \t__out_ecount(count)\tefx_desc_t *edp,\ndiff --git a/drivers/net/sfc/base/ef10_tx.c b/drivers/net/sfc/base/ef10_tx.c\nindex 8ca0b55..7d27f71 100644\n--- a/drivers/net/sfc/base/ef10_tx.c\n+++ b/drivers/net/sfc/base/ef10_tx.c\n@@ -623,6 +623,7 @@ ef10_tx_qdesc_tso_create(\n ef10_tx_qdesc_tso2_create(\n \t__in\t\t\tefx_txq_t *etp,\n \t__in\t\t\tuint16_t ipv4_id,\n+\t__in\t\t\tuint16_t outer_ipv4_id,\n \t__in\t\t\tuint32_t tcp_seq,\n \t__in\t\t\tuint16_t tcp_mss,\n \t__out_ecount(count)\tefx_desc_t *edp,\n@@ -636,13 +637,14 @@ ef10_tx_qdesc_tso2_create(\n \n \tEFSYS_ASSERT(count >= EFX_TX_FATSOV2_OPT_NDESCS);\n \n-\tEFX_POPULATE_QWORD_5(edp[0].ed_eq,\n+\tEFX_POPULATE_QWORD_6(edp[0].ed_eq,\n \t\t\t    ESF_DZ_TX_DESC_IS_OPT, 1,\n \t\t\t    ESF_DZ_TX_OPTION_TYPE,\n \t\t\t    ESE_DZ_TX_OPTION_DESC_TSO,\n \t\t\t    ESF_DZ_TX_TSO_OPTION_TYPE,\n \t\t\t    ESE_DZ_TX_TSO_OPTION_DESC_FATSO2A,\n \t\t\t    ESF_DZ_TX_TSO_IP_ID, ipv4_id,\n+\t\t\t    ESF_DZ_TX_TSO_OUTER_IPID, outer_ipv4_id,\n \t\t\t    ESF_DZ_TX_TSO_TCP_SEQNO, tcp_seq);\n \tEFX_POPULATE_QWORD_4(edp[1].ed_eq,\n \t\t\t    ESF_DZ_TX_DESC_IS_OPT, 1,\ndiff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 4af1591..0d84108 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -2295,6 +2295,7 @@ extern\tvoid\n efx_tx_qdesc_tso2_create(\n \t__in\t\t\tefx_txq_t *etp,\n \t__in\t\t\tuint16_t ipv4_id,\n+\t__in\t\t\tuint16_t outer_ipv4_id,\n \t__in\t\t\tuint32_t tcp_seq,\n \t__in\t\t\tuint16_t tcp_mss,\n \t__out_ecount(count)\tefx_desc_t *edp,\ndiff --git a/drivers/net/sfc/base/efx_impl.h b/drivers/net/sfc/base/efx_impl.h\nindex ca22e0b..a1bd03d 100644\n--- a/drivers/net/sfc/base/efx_impl.h\n+++ b/drivers/net/sfc/base/efx_impl.h\n@@ -117,7 +117,7 @@ typedef struct efx_tx_ops_s {\n \t\t\t\t\t\tuint32_t, uint8_t,\n \t\t\t\t\t\tefx_desc_t *);\n \tvoid\t\t(*etxo_qdesc_tso2_create)(efx_txq_t *, uint16_t,\n-\t\t\t\t\t\tuint32_t, uint16_t,\n+\t\t\t\t\t\tuint16_t, uint32_t, uint16_t,\n \t\t\t\t\t\tefx_desc_t *, int);\n \tvoid\t\t(*etxo_qdesc_vlantci_create)(efx_txq_t *, uint16_t,\n \t\t\t\t\t\tefx_desc_t *);\ndiff --git a/drivers/net/sfc/base/efx_tx.c b/drivers/net/sfc/base/efx_tx.c\nindex f8b9801..da37580 100644\n--- a/drivers/net/sfc/base/efx_tx.c\n+++ b/drivers/net/sfc/base/efx_tx.c\n@@ -625,6 +625,7 @@ efx_tx_qdesc_tso_create(\n efx_tx_qdesc_tso2_create(\n \t__in\t\t\tefx_txq_t *etp,\n \t__in\t\t\tuint16_t ipv4_id,\n+\t__in\t\t\tuint16_t outer_ipv4_id,\n \t__in\t\t\tuint32_t tcp_seq,\n \t__in\t\t\tuint16_t mss,\n \t__out_ecount(count)\tefx_desc_t *edp,\n@@ -636,7 +637,8 @@ efx_tx_qdesc_tso2_create(\n \tEFSYS_ASSERT3U(etp->et_magic, ==, EFX_TXQ_MAGIC);\n \tEFSYS_ASSERT(etxop->etxo_qdesc_tso2_create != NULL);\n \n-\tetxop->etxo_qdesc_tso2_create(etp, ipv4_id, tcp_seq, mss, edp, count);\n+\tetxop->etxo_qdesc_tso2_create(etp, ipv4_id, outer_ipv4_id,\n+\t    tcp_seq, mss, edp, count);\n }\n \n \tvoid\ndiff --git a/drivers/net/sfc/sfc_tso.c b/drivers/net/sfc/sfc_tso.c\nindex ba8496d..effe985 100644\n--- a/drivers/net/sfc/sfc_tso.c\n+++ b/drivers/net/sfc/sfc_tso.c\n@@ -164,7 +164,8 @@ sfc_efx_tso_do(struct sfc_efx_txq *txq, unsigned int idx,\n \trte_memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t));\n \tsent_seq = rte_be_to_cpu_32(sent_seq);\n \n-\tefx_tx_qdesc_tso2_create(txq->common, packet_id, sent_seq, m->tso_segsz,\n+\tefx_tx_qdesc_tso2_create(txq->common, packet_id, 0, sent_seq,\n+\t\t\t\t m->tso_segsz,\n \t\t\t\t *pend, EFX_TX_FATSOV2_OPT_NDESCS);\n \n \t*pend += EFX_TX_FATSOV2_OPT_NDESCS;\n",
    "prefixes": [
        "dpdk-dev",
        "77/80"
    ]
}