Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35237/?format=api
{ "id": 35237, "url": "http://patches.dpdk.org/api/patches/35237/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519112078-20113-38-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1519112078-20113-38-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1519112078-20113-38-git-send-email-arybchenko@solarflare.com", "date": "2018-02-20T07:33:55", "name": "[dpdk-dev,37/80] net/sfc/base: retrieve number of MAC stats from NIC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "78eaff73917c99a2000034eabe4150d54c3146ef", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519112078-20113-38-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35237/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/35237/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4155C1B2DF;\n\tTue, 20 Feb 2018 08:35:38 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 77CA01B026\n\tfor <dev@dpdk.org>; Tue, 20 Feb 2018 08:35:20 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t64758400056 for <dev@dpdk.org>; Tue, 20 Feb 2018 07:35:19 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 19 Feb 2018 23:35:15 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 19 Feb 2018 23:35:14 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw1K7ZDfY025064; Tue, 20 Feb 2018 07:35:13 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw1K7ZBtn020529; Tue, 20 Feb 2018 07:35:13 GMT" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Andy Moreton <amoreton@solarflare.com>", "Date": "Tue, 20 Feb 2018 07:33:55 +0000", "Message-ID": "<1519112078-20113-38-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1519112078-20113-1-git-send-email-arybchenko@solarflare.com>", "References": "<1519112078-20113-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1519112120-XcqvCjYBtQqw", "Subject": "[dpdk-dev] [PATCH 37/80] net/sfc/base: retrieve number of MAC stats\n\tfrom NIC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Andy Moreton <amoreton@solarflare.com>\n\nThis reports the number of stats (and hence the DMA buffer size)\nfor MAC stats. If MC_GET_CAPABABILITIES_V4 is not supported then\nuse the legacy Siena-compatible MC_CMD_MAC_NSTATS value.\n\nSigned-off-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_nic.c | 14 ++++++++++++--\n drivers/net/sfc/base/efx.h | 2 ++\n drivers/net/sfc/base/siena_nic.c | 2 ++\n 3 files changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_nic.c b/drivers/net/sfc/base/ef10_nic.c\nindex 66ea353..a23cf63 100644\n--- a/drivers/net/sfc/base/ef10_nic.c\n+++ b/drivers/net/sfc/base/ef10_nic.c\n@@ -996,7 +996,7 @@ ef10_get_datapath_caps(\n \tefx_nic_cfg_t *encp = &(enp->en_nic_cfg);\n \tefx_mcdi_req_t req;\n \tuint8_t payload[MAX(MC_CMD_GET_CAPABILITIES_IN_LEN,\n-\t\t\t MC_CMD_GET_CAPABILITIES_V2_OUT_LEN)];\n+\t\t\t MC_CMD_GET_CAPABILITIES_V4_OUT_LEN)];\n \tefx_rc_t rc;\n \n \tif ((rc = ef10_mcdi_get_pf_count(enp, &encp->enc_hw_pf_count)) != 0)\n@@ -1008,7 +1008,7 @@ ef10_get_datapath_caps(\n \treq.emr_in_buf = payload;\n \treq.emr_in_length = MC_CMD_GET_CAPABILITIES_IN_LEN;\n \treq.emr_out_buf = payload;\n-\treq.emr_out_length = MC_CMD_GET_CAPABILITIES_V2_OUT_LEN;\n+\treq.emr_out_length = MC_CMD_GET_CAPABILITIES_V4_OUT_LEN;\n \n \tefx_mcdi_execute_quiet(enp, &req);\n \n@@ -1175,6 +1175,16 @@ ef10_get_datapath_caps(\n \t\tencp->enc_tunnel_config_udp_entries_max = 0;\n \t}\n \n+\t/* Check if firmware supports extended MAC stats. */\n+\tif (req.emr_out_length_used >= MC_CMD_GET_CAPABILITIES_V4_OUT_LEN) {\n+\t\t/* Extended stats buffer supported */\n+\t\tencp->enc_mac_stats_nstats = MCDI_OUT_WORD(req,\n+\t\t GET_CAPABILITIES_V4_OUT_MAC_STATS_NUM_STATS);\n+\t} else {\n+\t\t/* Use Siena-compatible legacy MAC stats */\n+\t\tencp->enc_mac_stats_nstats = MC_CMD_MAC_NSTATS;\n+\t}\n+\n #undef CAP_FLAGS1\n #undef CAP_FLAGS2\n \ndiff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 2c7e932..fd02af1 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -1232,6 +1232,8 @@ typedef struct efx_nic_cfg_s {\n \tuint32_t\t\tenc_max_pcie_link_gen;\n \t/* Firmware verifies integrity of NVRAM updates */\n \tuint32_t\t\tenc_nvram_update_verify_result_supported;\n+\t/* Firmware support for extended MAC_STATS buffer */\n+\tuint32_t\t\tenc_mac_stats_nstats;\n } efx_nic_cfg_t;\n \n #define\tEFX_PCI_FUNCTION_IS_PF(_encp)\t((_encp)->enc_vf == 0xffff)\ndiff --git a/drivers/net/sfc/base/siena_nic.c b/drivers/net/sfc/base/siena_nic.c\nindex c051c59..f518a54 100644\n--- a/drivers/net/sfc/base/siena_nic.c\n+++ b/drivers/net/sfc/base/siena_nic.c\n@@ -156,6 +156,8 @@ siena_board_cfg(\n \n \tencp->enc_nvram_update_verify_result_supported = B_FALSE;\n \n+\tencp->enc_mac_stats_nstats = MC_CMD_MAC_NSTATS;\n+\n \treturn (0);\n \n fail2:\n", "prefixes": [ "dpdk-dev", "37/80" ] }