Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35233,
    "url": "http://patches.dpdk.org/api/patches/35233/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519112078-20113-39-git-send-email-arybchenko@solarflare.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1519112078-20113-39-git-send-email-arybchenko@solarflare.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1519112078-20113-39-git-send-email-arybchenko@solarflare.com",
    "date": "2018-02-20T07:33:56",
    "name": "[dpdk-dev,38/80] net/sfc/base: improve robustness of MAC stats get via MCDI",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f53db7b4495dade5ff7e82198262ec9425a612e2",
    "submitter": {
        "id": 607,
        "url": "http://patches.dpdk.org/api/people/607/?format=api",
        "name": "Andrew Rybchenko",
        "email": "arybchenko@solarflare.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519112078-20113-39-git-send-email-arybchenko@solarflare.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35233/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/35233/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 996591B2C3;\n\tTue, 20 Feb 2018 08:35:34 +0100 (CET)",
            "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id AC66A1B026\n\tfor <dev@dpdk.org>; Tue, 20 Feb 2018 08:35:19 +0100 (CET)",
            "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tA10F1400056 for <dev@dpdk.org>; Tue, 20 Feb 2018 07:35:18 +0000 (UTC)",
            "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 19 Feb 2018 23:35:15 -0800",
            "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 19 Feb 2018 23:35:14 -0800",
            "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw1K7ZDKP025066; Tue, 20 Feb 2018 07:35:13 GMT",
            "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw1K7ZBto020529; Tue, 20 Feb 2018 07:35:13 GMT"
        ],
        "X-Virus-Scanned": "Proofpoint Essentials engine",
        "From": "Andrew Rybchenko <arybchenko@solarflare.com>",
        "To": "<dev@dpdk.org>",
        "CC": "Andy Moreton <amoreton@solarflare.com>",
        "Date": "Tue, 20 Feb 2018 07:33:56 +0000",
        "Message-ID": "<1519112078-20113-39-git-send-email-arybchenko@solarflare.com>",
        "X-Mailer": "git-send-email 1.8.2.3",
        "In-Reply-To": "<1519112078-20113-1-git-send-email-arybchenko@solarflare.com>",
        "References": "<1519112078-20113-1-git-send-email-arybchenko@solarflare.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-MDID": "1519112119-25NkTf2lKtam",
        "Subject": "[dpdk-dev] [PATCH 38/80] net/sfc/base: improve robustness of MAC\n\tstats get via MCDI",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Andy Moreton <amoreton@solarflare.com>\n\nPreviously the code relied on the callers of efx_mcdi_mac_stats\nto provide a DMA buffer or NULL depnding on the action. Fix\nthis so that the DMA buffer is only passed in the request when\nneeded, and that an error is reported for a missing DMA buffer.\n\nSigned-off-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx_mcdi.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/sfc/base/efx_mcdi.c b/drivers/net/sfc/base/efx_mcdi.c\nindex 3352b08..a593b3f 100644\n--- a/drivers/net/sfc/base/efx_mcdi.c\n+++ b/drivers/net/sfc/base/efx_mcdi.c\n@@ -1814,9 +1814,15 @@ efx_mcdi_mac_stats(\n \t    MAC_STATS_IN_PERIODIC_NOEVENT, !events,\n \t    MAC_STATS_IN_PERIOD_MS, (enable | events) ? period_ms : 0);\n \n-\tif (esmp != NULL) {\n+\tif (enable || events || upload) {\n \t\tuint32_t bytes = MC_CMD_MAC_NSTATS * sizeof (uint64_t);\n \n+\t\t/* Periodic stats or stats upload require a DMA buffer */\n+\t\tif (esmp == NULL) {\n+\t\t\trc = EINVAL;\n+\t\t\tgoto fail1;\n+\t\t}\n+\n \t\tEFX_STATIC_ASSERT(MC_CMD_MAC_NSTATS * sizeof (uint64_t) <=\n \t\t    EFX_MAC_STATS_SIZE);\n \n@@ -1827,8 +1833,6 @@ efx_mcdi_mac_stats(\n \t\tMCDI_IN_SET_DWORD(req, MAC_STATS_IN_DMA_ADDR_HI,\n \t\t\t    EFSYS_MEM_ADDR(esmp) >> 32);\n \t\tMCDI_IN_SET_DWORD(req, MAC_STATS_IN_DMA_LEN, bytes);\n-\t} else {\n-\t\tEFSYS_ASSERT(!upload && !enable && !events);\n \t}\n \n \t/*\n@@ -1846,12 +1850,14 @@ efx_mcdi_mac_stats(\n \t\tif ((req.emr_rc != ENOENT) ||\n \t\t    (enp->en_rx_qcount + enp->en_tx_qcount != 0)) {\n \t\t\trc = req.emr_rc;\n-\t\t\tgoto fail1;\n+\t\t\tgoto fail2;\n \t\t}\n \t}\n \n \treturn (0);\n \n+fail2:\n+\tEFSYS_PROBE(fail2);\n fail1:\n \tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n \n",
    "prefixes": [
        "dpdk-dev",
        "38/80"
    ]
}