Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35207/?format=api
{ "id": 35207, "url": "http://patches.dpdk.org/api/patches/35207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180216213700.3415-8-pbhagavatula@caviumnetworks.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180216213700.3415-8-pbhagavatula@caviumnetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180216213700.3415-8-pbhagavatula@caviumnetworks.com", "date": "2018-02-16T21:36:57", "name": "[dpdk-dev,07/10] event/octeontx: optimize timer adapter resolution parameters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b92724805794ddbe54a87d052e30af3bed40d366", "submitter": { "id": 768, "url": "http://patches.dpdk.org/api/people/768/?format=api", "name": "Pavan Nikhilesh", "email": "pbhagavatula@caviumnetworks.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180216213700.3415-8-pbhagavatula@caviumnetworks.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35207/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/35207/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DA1881B331;\n\tFri, 16 Feb 2018 22:37:53 +0100 (CET)", "from NAM01-BY2-obe.outbound.protection.outlook.com\n\t(mail-by2nam01on0043.outbound.protection.outlook.com [104.47.34.43])\n\tby dpdk.org (Postfix) with ESMTP id E33991B321\n\tfor <dev@dpdk.org>; Fri, 16 Feb 2018 22:37:51 +0100 (CET)", "from localhost.localdomain (111.93.218.67) by\n\tDM5PR07MB3467.namprd07.prod.outlook.com (2603:10b6:4:67::22) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18;\n\tFri, 16 Feb 2018 21:37:48 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=YRl+02uCO5MkOcn4jJTeLVtuQU6dMvyF8G/WqqUFXpE=;\n\tb=EWBWCHyk5pQ2X4VobkNv0iI0DX5LHYz5/K1WPRBjynp9n1b+/rZftfCo/0Mjh+g6bAHDQZG1PoA+eewQEW7PELfogzZ4mY7kKLy3JhcDzL2w0i6XPOYq/yKWsux2J/LMp09AvvIe2v4IPbooxc/qC67M5v4kAt1XcTgXttSo/Zk=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Pavan.Bhagavatula@cavium.com; ", "From": "Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>", "To": "jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,\n\terik.g.carrillo@intel.com", "Cc": "dev@dpdk.org,\n\tPavan Nikhilesh <pbhagavatula@caviumnetworks.com>", "Date": "Sat, 17 Feb 2018 03:06:57 +0530", "Message-Id": "<20180216213700.3415-8-pbhagavatula@caviumnetworks.com>", "X-Mailer": "git-send-email 2.16.1", "In-Reply-To": "<20180216213700.3415-1-pbhagavatula@caviumnetworks.com>", "References": "<20180216213700.3415-1-pbhagavatula@caviumnetworks.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[111.93.218.67]", "X-ClientProxiedBy": "SG2PR01CA0090.apcprd01.prod.exchangelabs.com\n\t(2603:1096:3:15::16) To DM5PR07MB3467.namprd07.prod.outlook.com\n\t(2603:10b6:4:67::22)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "163d4d11-be54-4fe9-8553-08d57585878c", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020);\n\tSRVR:DM5PR07MB3467; ", "X-Microsoft-Exchange-Diagnostics": [ "1; DM5PR07MB3467;\n\t3:lPeTDDuYisCdxKi2X7zd8WFmRw7lIARniL77CYViM6rwrdjY8Ib6RBd5lt6b8Qrt762ttv6luP8CrNrK5MXOKvSLPXEuvpMLxlhsbQi61KsPO2b79wfmhJj5kH5cEFuFALArksjo2Ku1s9XrxDK6hlwrV4xgILJl1QdLOgYIHdgOSakEZsmET/UTKzHv2+LZBmmyMkIoUpZXzD/Qg+CrXoZHTO/MwSSH3//Iz4ycxQA/Qv8I9gCvNSZWEwpNR05P;\n\t25:LHEdAruWwxYvWoMMzkQ9Te/BPVcRhdNkNkyK1gBpjj75Z12Z2s4JDwMSprntQTL0g6B8CtVIrghywJqj9eu8ko7orzPwfDX9kiSj5wbnqFBoLAW2AZZHnwK+MrNj5v8Ap6cusVTwVPE2PavNngBE1JTj9yBl25A0iisYbKGhfmONOYGRG+JBxL6qZ6Eq6v71tsttyI3AOHMUf7d1AkQqEPu+PabqqJMn0HwDcc7Nie2X2KJXNoN18i54nhsz0+5VfgIRVN/u9lwJ6D7kIfwTBNgB6RLWU5wo+XufzHzYHEirprFetqK6OIEtJ53sWmldCdR5ptiH2oC85/tU63fv/w==;\n\t31:7k7JctGMlsIgvKVI8G9k+PoEkuUTZXA1e+AiLQxO8VkQPcJA05BeEsEMj/SagzEThi0E8ktWIs6zTzwcveNx3Gxw/2yNXJODDR3JJnJO7HwG/6EHK8eqxBr2vPqL/pTLjA+qIMkVJgMAn37KqTKebkr3RzpvjQRKQE236hBx39Yuuv6l9H3z/M2YjTRnbuMWq/ZLa09MllO4wIv0S9/SlEewnSzNlFn7+uDqPfMA3yM=", "1; DM5PR07MB3467;\n\t20:rL8p1T2Il8mtcFmS8ZYpoRJdTs+Gjn4KPViLqGIwlRhRr67t/AqdGrX6kOtJgPu5GwsASD2DPLIfT39UEonprhVjqGfh5aDLQcv2JT4dsDkUdDAdACHBxF6Jwwy6K4xorOq005H4drdMKIgoa5Wg0+AsUXMJcOxUE957/mBx/axGnZzfOM5DhiJ3D3ll+qmjjC/vZIs2z0L/2qllw+a5OLo3R+9aTjrTGr45NqdRcXYebKoOwijg5GzZayk2zW79k9gAP0+ASkBY54bMt8PDZgczxqahDg7NHJqwG+IJTW9GQvqyv+VuoeeN7IxO/Apxd+6F+V4+r3UyrgiAv8eaTQT3xau1dEx9/PfZOnFmuZK7byjgemtmU7rEVCXalF1W0TxsIGTnvA0G5IOD7jwRzaBcdppF4rEl3d0gIewJlH1SsW9isQIEoJRSFfOy8BgS+rTfFemN+2o+ocg2qLzGrFxvMEdDZnb+Z0IhUbzBTaVp9sPFq/VruSQ+56W+5j4xoFzfABwMnAoZAh24C5Q34djcaRj/5SMvxydIbg6n2L0NFgsgSABOUTS/ics+RbhzcuWWVGSBjJiFrI12u3UMOmGgjV+cC9WCM2ooK27VZ28=;\n\t4:YJ82T1W/5lwHFsrWH9EjB32ptUsY1yKH5UG5G/EzwwOyTbtgXpiQB1hyr5Scd8TO49O+rOwMOvuWfhB6c7L/4Kv5WVjndDoHqoI+PYiPKkb7fiiRJgjg/ANuuK/Bu0oXvR80AQ3VGi3ZC18uGofQptOJ2jz6iMs/GtBEBcl/OpWuambA51KH8nWssvlOioJoVwMka7Enuh5oZXYhngcQw4U49nb+jCY6ffMtNH2zpkjEU2/yFeTES4GXfWUhjXQ7BoEtx5xUtwp3esv6N+JyYQ==", "=?us-ascii?Q?1; DM5PR07MB3467;\n\t23:JxAsG99xztjt/W+vCr2FlAiEjmD9XT6KnV7B+844x?=\n\tMZpmLd8gjgo47sulgvbQmGP218+ZmNgEQxUbsrWFcbFgwIC9c0kIz2mzelQP8IBWKWhFmAqytGsOJHdky7aa1+FCinC2TAH3ROcSSPLwCMdY4QAhLJKtpKArYmPr+QhpZnbF0Gt++/q+z402trseu9a4QZOPkHAVCfxUgsb3Dw4EKxFNgPlR3C2TdW1/uu1ED6XLGrOSKKN1+McReE79bwDDOUjWtzArIGGOS6w0hllaAjhslc3BeiapxyyTtuG4iWyAy0N5Ro4+/7qvmHdXyB0Ip0HB32F+knuVX5SW80LwamyPn/MUAFC0Hma7i8A9euet9//J6cOhBFCcoPIIicFSCTgXeAn6zfoBnpJCkf13EJnBGtw6Hz4GiY1pnVOaepZO3bMH99oHRPEbBwUNJUqTbTwrrh3wxpNYuvPcby6kUlf8I4X10bi6OmyJW8qAkkdio+gJv9btpM6afYR7XdZm3beqHhGbKOI27KFHnnT9H1Q3HyhsCC1snVnh7f9PXWJfGd9Z/xZDTEX1hCD9Kr0923xyNMotdpSqbXRQhKvsHtkBGTLzuLXGwir2saV8OObf+xyZnx0ZFvlgkLGvTSSrBXbEb8YDesaNViZ/It5OfP74z1jSxDycRFP5Ho2EyQNsxCP7mmDHAZKQhAHJIcCZAKk9wZ3Kf/41nAj2RHZsrZ95jCzrNg2AD/aACWiNOFCJrnG425XsyKI0chD8cTXKR8D2mkTo4wsUkC8U4WVlWCh8s570qpZHT/FmX0cqdhXfo18bc3s5c3XLSkCo4Hlv/OkBFwFNakz5PwMqN6ODUvOO5P0E/BOlO3SBxtbRe88Lmp4HeeCeKm5Ny3Oq2xxkC5VsjL56iPBE/7aqG6ddZqQOemGtWo5MUW24C8AOIwsrzP4jCYURsnuW9FnhxPoeBGkeA8QrrnzkVwQbTcZhbs6OlXEmPEPUs9gH1s7EPx107jWwASiTj2djGm7aab0DXNcf91h3ns4D22hSUp353rkEOfC7JCUtQVYI2QEgWd1CA5W8ntV3ujWgWFM0bMwMJdrGwN7ZmVlW2MO/lSqehKx7meQTw2yg8QGVuvnRyWG8sT8DhLCqDi5oLICFSf0drgj07j2gESFaDxQYmR6Bbpv3gRLT2h0RGrrma9zV2qKBOWoyrom0l7NkOEDswcMuTDPmJYyJv1+V/nKA9yWCW7nFK7pJmTSqB04RJq2Z8M=", "1; DM5PR07MB3467;\n\t6:zVNuU/ltP0py7/h1w+EtmdT8LQ9DMnrk3Xc4v+mjc/Ghizlrb2MRcIRUp0RzVKcAjSwQz9o25Y3Rx7vyjVS0eoLUxww4eXIqUbL2JgtOvOlKUr5U8NHBeTEzCbW3pLT91tJlCyzl1x9YPoW4nFobHxYZGbd4XX/iKJgl2qCVwK2jevhua8C0HSNNhnXChppvsGSW07VHqo/hoWna3yOEUyAYJ7vdg0scDjGJ+6YnO5hzMe3209Cu1lZBiRyp9l8p7xN44i33Zxbc2Pip5+2s3sGSk1PlYWEzYfSuCJnqvdnoWKsOBY3ldc8mlyIBzO/dZ5DswpxJ/TLGVND4qe5oX1M3VKL2kRSAkgFok4fE+vg=;\n\t5:sV1jw1vjkk2ikgLmF35xKP0c2RBShDzf6dC1PoAZQU4J/chp2C8Bq8xWhBa1AArX9bm5X4zmQZK7YEZR1F2epMICpZgE/kru2tysmQNeoAmbLabQw/NSPnAV1TZimtQMyGsCZtY+Bkvjd6EjBrHg5Q+tq7P6xN9FfbUF4b54vVw=;\n\t24:PuFatwsGe6w0jiRY/zApE89IlvFVznbiWLDdNAJ+fbNAGSOrssVAo/fz04PbbDFgQCT3MgZ3g+osXt6XVy47IDOA4hD0XnGvZ8F+5PPoTGY=;\n\t7:zqPiAIiaPTslDxCIa6OzwtnpMXOCByjyB4lsz8jZukZbBc6bAZ/3SxrEDlmibEbLm0Sogk7/b1M1P3uiSGxBGJRl9gip32W4y1c94I0m4S0nQfgrGWFQLYuxyTrjcQIbleBKDjnBTUMnVunn96e+gNyvoM9pfsvIx1A4brQUAoBiJQWLxR4bhe/zzb+XMbLH1+0xIf5JQxZ6qTFsOYiRdWDfOhKETd6ctF3w02N/cLRTK+ogZXmCFYZVbk+0UqHt" ], "X-MS-TrafficTypeDiagnostic": "DM5PR07MB3467:", "X-Microsoft-Antispam-PRVS": "<DM5PR07MB34675134A6FF87D47D94BA4780CB0@DM5PR07MB3467.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(944501161)(93006095)(3002001)(6041288)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011);\n\tSRVR:DM5PR07MB3467; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3467; ", "X-Forefront-PRVS": "0585417D7B", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(6069001)(346002)(366004)(396003)(39860400002)(39380400002)(376002)(189003)(199004)(6486002)(25786009)(2950100002)(386003)(6506007)(53936002)(42882006)(5009440100003)(4326008)(107886003)(6666003)(59450400001)(6512007)(16586007)(106356001)(316002)(105586002)(36756003)(478600001)(2906002)(47776003)(6116002)(76176011)(3846002)(1076002)(97736004)(66066001)(8676002)(51416003)(50466002)(48376002)(81156014)(5660300001)(68736007)(8936002)(52116002)(16526019)(26005)(305945005)(1857600001)(72206003)(81166006)(50226002)(7736002)(42262002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3467; H:localhost.localdomain;\n\tFPR:; \n\tSPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "caviumnetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 Feb 2018 21:37:48.9589\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "163d4d11-be54-4fe9-8553-08d57585878c", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM5PR07MB3467", "Subject": "[dpdk-dev] [PATCH 07/10] event/octeontx: optimize timer adapter\n\tresolution parameters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When application sets `RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES` flag\nwhile creating adapter underlying driver is free to optimize the\nresolution for best possible configuration.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>\n---\n drivers/event/octeontx/timvf_evdev.c | 51 +++++++++++++++++++++++++++++++++++-\n drivers/event/octeontx/timvf_evdev.h | 6 +++++\n 2 files changed, 56 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/event/octeontx/timvf_evdev.c b/drivers/event/octeontx/timvf_evdev.c\nindex 6cf5d4846..ffdfbb387 100644\n--- a/drivers/event/octeontx/timvf_evdev.c\n+++ b/drivers/event/octeontx/timvf_evdev.c\n@@ -82,6 +82,48 @@ timvf_get_start_cyc(uint64_t *now, uint8_t ring_id)\n \treturn octeontx_ssovf_mbox_send(&hdr, NULL, 0, now, sizeof(uint64_t));\n }\n \n+#define ALIGN_CEIL(a, b) \\\n+\t\t(((a + (typeof(a)) b - 1) / ((typeof(a)) b)) * (typeof(a))b)\n+\n+static int\n+optimize_bucket_parameters(struct timvf_ring *timr)\n+{\n+\tuint32_t hbkts;\n+\tuint32_t lbkts;\n+\tuint64_t tck_nsec;\n+\n+\thbkts = rte_align32pow2(timr->meta.nb_bkts);\n+\ttck_nsec = ALIGN_CEIL(timr->max_tout / (hbkts - 1), 10);\n+\n+\tif ((tck_nsec < 1000 || hbkts > TIM_MAX_BUCKETS))\n+\t\thbkts = 0;\n+\n+\tlbkts = rte_align32lowpow2(timr->meta.nb_bkts);\n+\ttck_nsec = ALIGN_CEIL((timr->max_tout / (lbkts - 1)), 10);\n+\n+\tif ((tck_nsec < 1000 || hbkts > TIM_MAX_BUCKETS))\n+\t\tlbkts = 0;\n+\n+\tif (!hbkts && !lbkts)\n+\t\treturn 0;\n+\n+\tif (!hbkts) {\n+\t\ttimr->meta.nb_bkts = lbkts;\n+\t\tgoto end;\n+\t} else if (!lbkts) {\n+\t\ttimr->meta.nb_bkts = hbkts;\n+\t\tgoto end;\n+\t}\n+\n+\ttimr->meta.nb_bkts = (hbkts - timr->meta.nb_bkts) <\n+\t\t(timr->meta.nb_bkts - lbkts) ? hbkts : lbkts;\n+end:\n+\ttimr->meta.get_target_bkt = bkt_and;\n+\ttimr->tck_nsec = ALIGN_CEIL((timr->max_tout /\n+\t\t\t\t(timr->meta.nb_bkts - 1)), 10);\n+\treturn 1;\n+}\n+\n static int\n timvf_ring_start(const struct rte_event_timer_adapter *adptr)\n {\n@@ -215,7 +257,7 @@ timvf_ring_create(struct rte_event_timer_adapter *adptr)\n \t}\n \n \ttimr->tim_ring_id = adptr->data->id;\n-\ttimr->tck_nsec = rcfg->timer_tick_ns;\n+\ttimr->tck_nsec = ALIGN_CEIL(rcfg->timer_tick_ns, 10);\n \ttimr->max_tout = rcfg->max_tmo_ns;\n \ttimr->meta.nb_bkts = (timr->max_tout / timr->tck_nsec) + 1;\n \ttimr->vbar0 = octeontx_timvf_bar(timr->tim_ring_id, 0);\n@@ -225,6 +267,13 @@ timvf_ring_create(struct rte_event_timer_adapter *adptr)\n \n \ttimr->nb_chunks = nb_timers / nb_chunk_slots;\n \n+\t/* Try to optimize the bucket parameters. */\n+\tif ((rcfg->flags & RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES)\n+\t\t\t&& !rte_is_power_of_2(timr->meta.nb_bkts)) {\n+\t\toptimize_bucket_parameters(timr);\n+\t\ttimvf_log_info(\"Optimizing configured values\");\n+\t}\n+\n \tif (rcfg->flags & RTE_EVENT_TIMER_ADAPTER_F_SP_PUT) {\n \t\tmp_flags = MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET;\n \t\ttimvf_log_info(\"Using single producer mode\");\ndiff --git a/drivers/event/octeontx/timvf_evdev.h b/drivers/event/octeontx/timvf_evdev.h\nindex b5db233bb..5e526a36a 100644\n--- a/drivers/event/octeontx/timvf_evdev.h\n+++ b/drivers/event/octeontx/timvf_evdev.h\n@@ -184,6 +184,12 @@ bkt_mod(uint32_t rel_bkt, uint32_t nb_bkts)\n \treturn rel_bkt % nb_bkts;\n }\n \n+static __rte_always_inline uint32_t __hot\n+bkt_and(uint32_t rel_bkt, uint32_t nb_bkts)\n+{\n+\treturn rel_bkt & (nb_bkts - 1);\n+}\n+\n int timvf_timer_adapter_caps_get(const struct rte_eventdev *dev, uint64_t flags,\n \t\tuint32_t *caps, const struct rte_event_timer_adapter_ops **ops);\n int timvf_timer_reg_brst(const struct rte_event_timer_adapter *adptr,\n", "prefixes": [ "dpdk-dev", "07/10" ] }