Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/352/?format=api
http://patches.dpdk.org/api/patches/352/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1410441347-22840-12-git-send-email-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1410441347-22840-12-git-send-email-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1410441347-22840-12-git-send-email-bruce.richardson@intel.com", "date": "2014-09-11T13:15:45", "name": "[dpdk-dev,v2,11/13] mbuf: move l2_len and l3_len to second cache line", "commit_ref": "", "pull_url": "", "state": "accepted", "archived": true, "hash": "37ba4a46a1e33c00debc5561f450fa0b0a86a8b3", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1410441347-22840-12-git-send-email-bruce.richardson@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/352/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/352/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\r\n\tby dpdk.org (Postfix) with ESMTP id AA268B3C4;\r\n\tThu, 11 Sep 2014 15:11:37 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\r\n\tby dpdk.org (Postfix) with ESMTP id CAE48B3B7\r\n\tfor <dev@dpdk.org>; Thu, 11 Sep 2014 15:11:34 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\r\n\tby fmsmga102.fm.intel.com with ESMTP; 11 Sep 2014 06:16:47 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\r\n\tby fmsmga002.fm.intel.com with ESMTP; 11 Sep 2014 06:15:51 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\r\n\t[10.237.217.46])\r\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\r\n\ts8BDFnUS002158; Thu, 11 Sep 2014 14:15:50 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\r\n\tby sivswdev02.ir.intel.com with ESMTP id s8BDFn9o023682;\r\n\tThu, 11 Sep 2014 14:15:49 +0100", "(from bricha3@localhost)\r\n\tby sivswdev02.ir.intel.com with id s8BDFnIo023678;\r\n\tThu, 11 Sep 2014 14:15:49 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,505,1406617200\"; d=\"scan'208\";a=\"598051486\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 11 Sep 2014 14:15:45 +0100", "Message-Id": "<1410441347-22840-12-git-send-email-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1410441347-22840-1-git-send-email-bruce.richardson@intel.com>", "References": "<1409759378-10113-1-git-send-email-bruce.richardson@intel.com>\r\n\t<1410441347-22840-1-git-send-email-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 11/13] mbuf: move l2_len and l3_len to second\r\n\tcache line", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The l2_len and l3_len fields are used for TX offloads and so should be\nput on the second cache line, along with the other fields only used on\nTX.\n\nUpdates in V2:\n* The l2 and l3 lengths can be accessed as a single uint16_t for\n performance, as well as individually.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_mbuf/rte_mbuf.h | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\r\nindex 508021b..1c6e115 100644\r\n--- a/lib/librte_mbuf/rte_mbuf.h\r\n+++ b/lib/librte_mbuf/rte_mbuf.h\r\n@@ -159,13 +159,7 @@ struct rte_mbuf {\r\n \tuint16_t reserved2; /**< Unused field. Required for padding */\r\n \tuint16_t data_len; /**< Amount of data in segment buffer. */\r\n \tuint32_t pkt_len; /**< Total pkt len: sum of all segments. */\r\n-\tunion {\r\n-\t\tuint16_t l2_l3_len; /**< combined l2/l3 lengths as single var */\r\n-\t\tstruct {\r\n-\t\t\tuint16_t l3_len:9; /**< L3 (IP) Header Length. */\r\n-\t\t\tuint16_t l2_len:7; /**< L2 (MAC) Header Length. */\r\n-\t\t};\r\n-\t};\r\n+\tuint16_t reserved;\r\n \tuint16_t vlan_tci; /**< VLAN Tag Control Identifier (CPU order) */\r\n \tunion {\r\n \t\tuint32_t rss; /**< RSS hash result if RSS enabled */\r\n@@ -181,6 +175,14 @@ struct rte_mbuf {\r\n \tstruct rte_mempool *pool; /**< Pool from which mbuf was allocated. */\r\n \tstruct rte_mbuf *next; /**< Next segment of scattered packet. */\r\n \r\n+\t/* fields to support TX offloads */\r\n+\tunion {\r\n+\t\tuint16_t l2_l3_len; /**< combined l2/l3 lengths as single var */\r\n+\t\tstruct {\r\n+\t\t\tuint16_t l3_len:9; /**< L3 (IP) Header Length. */\r\n+\t\t\tuint16_t l2_len:7; /**< L2 (MAC) Header Length. */\r\n+\t\t};\r\n+\t};\r\n } __rte_cache_aligned;\r\n \r\n /**\r\n", "prefixes": [ "dpdk-dev", "v2", "11/13" ] }{ "id": 352, "url": "