Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35186/?format=api
{ "id": 35186, "url": "http://patches.dpdk.org/api/patches/35186/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/16c653c55e2144291ce92c9696ffaa829a70a028.1518684427.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<16c653c55e2144291ce92c9696ffaa829a70a028.1518684427.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/16c653c55e2144291ce92c9696ffaa829a70a028.1518684427.git.nelio.laranjeiro@6wind.com", "date": "2018-02-15T08:47:28", "name": "[dpdk-dev,2/2] net/mlx5: fix link status to use wait to complete", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7f21a1a228a8706b028243ca1528030e6af283b3", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/16c653c55e2144291ce92c9696ffaa829a70a028.1518684427.git.nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35186/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/35186/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1DDDE1B37D;\n\tThu, 15 Feb 2018 09:46:54 +0100 (CET)", "from mail-wr0-f194.google.com (mail-wr0-f194.google.com\n\t[209.85.128.194]) by dpdk.org (Postfix) with ESMTP id A20C61B321\n\tfor <dev@dpdk.org>; Thu, 15 Feb 2018 09:46:49 +0100 (CET)", "by mail-wr0-f194.google.com with SMTP id m5so2498381wrg.1\n\tfor <dev@dpdk.org>; Thu, 15 Feb 2018 00:46:49 -0800 (PST)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\t42sm3965186wrx.92.2018.02.15.00.46.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 15 Feb 2018 00:46:48 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=3tC0HyRGo+TeCO1Uejm9dy0E4q0AnrDJTBX1ZiDtTvA=;\n\tb=S2NrkXflNqtv+B7sTWPLB8hPLiw9BprnlQlqyJIr8ayj7FApnXAgZwY9SPIAoyaflq\n\tJpOP1l9yfPQKTqxBh/Uy0xFNHjf6cUTLPaJenka13J5iWDSHvTK//TlcoFFGjG5FAIM8\n\tz4x4llTgD3icZlS4olNY+4ElzTiAQNH+ODwaGrot3+aJNuvqMiLGzr55na0V6ICcnO7F\n\tk6k17qpmg28HRPL0rlTKZ59HL4Q3xZ1hOwdnKWhfljPGsvgdxbID+W3tMCB5B0cLubF4\n\tELxBYVD7rvFmxlIiKeJs86zo/ywz40Sl2ygP/OTvAMv4oy/itvoQPv/Vu2ObF6QsL3Kp\n\t8f1g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=3tC0HyRGo+TeCO1Uejm9dy0E4q0AnrDJTBX1ZiDtTvA=;\n\tb=W/kb+dmp3ByPDyTbtVBZ+mLhOpYBtzBpNYAUWVNCr8qv4kuuFn5nfzAa7xVy0kKBUl\n\trQkAQjxjFRWKLdo/D2tZXM8TwPL5oFIKWHZ8N5/bQ9L2suAKUvsOImDotUxYHI/bGMsZ\n\t40exG01+sSUBFiqd5W/T/ihwilU3foGZfWXACWR0sfIDOvJ7UEHxaW5vtF4+sEe6gmM6\n\tzKNwbyjDO83XbytOWVJK300sS+9E5m9hMrJaIeC1NoCNhE4NcuVkRveeKrAEUroTK/tO\n\tan33S4XHpVL2lFlIHBzsyp3A91zACm+Xt5ZiXaUB4/y4/YGKXDNUDA3dSqHl5EYWimNi\n\tyudA==", "X-Gm-Message-State": "APf1xPCdCRT7+yUwxEPPiX/e0/7iy+RRoIuL7wHJJpx+sIC0rF/lhftx\n\t6RBXQFJqUpRGRGlmVoqlUx5HaFIRPQ==", "X-Google-Smtp-Source": "AH8x224cQKN1BTmjizlR8Mci1uPsQiaSz450bBxEQoKK1i8I1F5iHlRVCPoJTkl+WKm5LNGbIY0X2g==", "X-Received": "by 10.223.192.72 with SMTP id c8mr1797196wrf.145.1518684409132; \n\tThu, 15 Feb 2018 00:46:49 -0800 (PST)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tYongseok Koh <yskoh@mellanox.com>", "Date": "Thu, 15 Feb 2018 09:47:28 +0100", "Message-Id": "<16c653c55e2144291ce92c9696ffaa829a70a028.1518684427.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": [ "<21fb91002768a627d9c7f3d81e0c8a12fbf6811f.1518684427.git.nelio.laranjeiro@6wind.com>", "<21fb91002768a627d9c7f3d81e0c8a12fbf6811f.1518684427.git.nelio.laranjeiro@6wind.com>" ], "References": [ "<21fb91002768a627d9c7f3d81e0c8a12fbf6811f.1518684427.git.nelio.laranjeiro@6wind.com>", "<21fb91002768a627d9c7f3d81e0c8a12fbf6811f.1518684427.git.nelio.laranjeiro@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH 2/2] net/mlx5: fix link status to use wait to\n\tcomplete", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Wait to complete is present to let the application get a correct status\nwhen it requires it, it should not be ignored.\n\nFixes: cb8faed7dde8 (\"mlx5: support link status update\")\nCc: adrien.mazarguil@6wind.com\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_ethdev.c | 35 +++++++++++++++++++++--------------\n 1 file changed, 21 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 0ce9f438a..112cc2a40 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -502,11 +502,12 @@ mlx5_dev_supported_ptypes_get(struct rte_eth_dev *dev)\n *\n * @param dev\n * Pointer to Ethernet device structure.\n- * @param wait_to_complete\n- * Wait for request completion (ignored).\n+ *\n+ * @return\n+ * 0 on success, -1 otherwise.\n */\n static int\n-mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, int wait_to_complete)\n+mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tstruct ethtool_cmd edata = {\n@@ -518,7 +519,6 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, int wait_to_complete)\n \n \t/* priv_lock() is not taken to allow concurrent calls. */\n \n-\t(void)wait_to_complete;\n \tif (priv_ifreq(priv, SIOCGIFFLAGS, &ifr)) {\n \t\tWARN(\"ioctl(SIOCGIFFLAGS) failed: %s\", strerror(errno));\n \t\treturn -1;\n@@ -568,11 +568,9 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, int wait_to_complete)\n *\n * @param dev\n * Pointer to Ethernet device structure.\n- * @param wait_to_complete\n- * Wait for request completion (ignored).\n */\n static int\n-mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete)\n+mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tstruct ethtool_link_settings gcmd = { .cmd = ETHTOOL_GLINKSETTINGS };\n@@ -580,7 +578,6 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete)\n \tstruct rte_eth_link dev_link;\n \tuint64_t sc;\n \n-\t(void)wait_to_complete;\n \tif (priv_ifreq(priv, SIOCGIFFLAGS, &ifr)) {\n \t\tWARN(\"ioctl(SIOCGIFFLAGS) failed: %s\", strerror(errno));\n \t\treturn -1;\n@@ -708,6 +705,9 @@ priv_link_stop(struct priv *priv)\n * Pointer to private structure.\n * @param wait_to_complete\n * Wait for request completion (ignored).\n+ *\n+ * @return\n+ * 0 on success, negative value otherwise.\n */\n int\n priv_link_update(struct priv *priv, int wait_to_complete)\n@@ -720,10 +720,16 @@ priv_link_update(struct priv *priv, int wait_to_complete)\n \t\tcurrent_version >= KERNEL_VERSION(4, 9, 0) :\n \t\t0;\n \n-\tif (use_new_api)\n-\t\tret = mlx5_link_update_unlocked_gset(dev, wait_to_complete);\n-\telse\n-\t\tret = mlx5_link_update_unlocked_gs(dev, wait_to_complete);\n+\tdo {\n+\t\tif (use_new_api)\n+\t\t\tret = mlx5_link_update_unlocked_gset(dev);\n+\t\telse\n+\t\t\tret = mlx5_link_update_unlocked_gs(dev);\n+\t\tif (ret == -1)\n+\t\t\treturn -EAGAIN;\n+\t} while(wait_to_complete && !ret);\n+\tif (ret == -EAGAIN)\n+\t\treturn ret;\n \t/* If lsc interrupt is disabled, should always be ready for traffic. */\n \tif (!dev->data->dev_conf.intr_conf.lsc) {\n \t\tpriv_link_start(priv);\n@@ -755,10 +761,11 @@ int\n priv_force_link_status_change(struct priv *priv, int status)\n {\n \tint try = 0;\n+\tint ret = 0;\n \n \twhile (try < MLX5_MAX_LINK_QUERY_ATTEMPTS) {\n-\t\tpriv_link_update(priv, 0);\n-\t\tif (priv->dev->data->dev_link.link_status == status)\n+\t\tret = priv_link_update(priv, 0);\n+\t\tif (!ret && priv->dev->data->dev_link.link_status == status)\n \t\t\treturn 0;\n \t\ttry++;\n \t\tsleep(1);\n", "prefixes": [ "dpdk-dev", "2/2" ] }