Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35175,
    "url": "http://patches.dpdk.org/api/patches/35175/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180214145330.4679-5-zhiyong.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180214145330.4679-5-zhiyong.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180214145330.4679-5-zhiyong.yang@intel.com",
    "date": "2018-02-14T14:53:30",
    "name": "[dpdk-dev,4/4] net/vhost: add memory checking to support client mode",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "c41c0d230af77555bdead4dd62297eb400a6cf5b",
    "submitter": {
        "id": 540,
        "url": "http://patches.dpdk.org/api/people/540/?format=api",
        "name": "Yang, Zhiyong",
        "email": "zhiyong.yang@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180214145330.4679-5-zhiyong.yang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35175/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/35175/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9B47E1B365;\n\tWed, 14 Feb 2018 15:53:44 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 7A9E21B360\n\tfor <dev@dpdk.org>; Wed, 14 Feb 2018 15:53:42 +0100 (CET)",
            "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Feb 2018 06:53:42 -0800",
            "from unknown (HELO dpdk5.bj.intel.com) ([172.16.182.198])\n\tby fmsmga007.fm.intel.com with ESMTP; 14 Feb 2018 06:53:40 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,512,1511856000\"; d=\"scan'208\";a=\"17661449\"",
        "From": "Zhiyong Yang <zhiyong.yang@intel.com>",
        "To": "dev@dpdk.org, yliu@fridaylinux.org, maxime.coquelin@redhat.com,\n\tjianfeng.tan@intel.com, tiwei.bie@intel.com, zhihong.wang@intel.com",
        "Cc": "dong1.wang@intel.com,\n\tZhiyong Yang <zhiyong.yang@intel.com>",
        "Date": "Wed, 14 Feb 2018 22:53:30 +0800",
        "Message-Id": "<20180214145330.4679-5-zhiyong.yang@intel.com>",
        "X-Mailer": "git-send-email 2.13.3",
        "In-Reply-To": "<20180214145330.4679-1-zhiyong.yang@intel.com>",
        "References": "<20180214145330.4679-1-zhiyong.yang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 4/4] net/vhost: add memory checking to support\n\tclient mode",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When vhost user PMD works in client mode to connect/reconnect virtio\nuser in server mode, new thread sometimes may run to new_device before\nqueue_setup has been done, So have to wait until memory allocation\nis done.\n\nSigned-off-by: Zhiyong Yang <zhiyong.yang@intel.com>\n---\n drivers/net/vhost/rte_eth_vhost.c | 9 +++++++++\n 1 file changed, 9 insertions(+)",
    "diff": "diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 3aae01c39..cd67bc7c5 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -580,6 +580,15 @@ new_device(int vid)\n \t\teth_dev->data->numa_node = newnode;\n #endif\n \n+\t/* The thread may run here before eth_dev->data->rx_queues or\n+\t * eth_dev->data->tx_queues have gotten valid memory, so have to\n+\t * wait until memory allocation is done.\n+\t */\n+\twhile (!eth_dev->data->rx_queues ||\n+\t       !eth_dev->data->tx_queues) {\n+\t\t;\n+\t}\n+\n \tfor (i = 0; i < eth_dev->data->nb_rx_queues; i++) {\n \t\tvq = eth_dev->data->rx_queues[i];\n \t\tif (vq == NULL)\n",
    "prefixes": [
        "dpdk-dev",
        "4/4"
    ]
}