Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35171,
    "url": "http://patches.dpdk.org/api/patches/35171/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1518619646-23990-1-git-send-email-matan@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1518619646-23990-1-git-send-email-matan@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1518619646-23990-1-git-send-email-matan@mellanox.com",
    "date": "2018-02-14T14:47:26",
    "name": "[dpdk-dev,v2] net/failsafe: fix Rx interrupt reinstallation",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fe61d24b116652aa00726b72796918bf6151fa4f",
    "submitter": {
        "id": 796,
        "url": "http://patches.dpdk.org/api/people/796/?format=api",
        "name": "Matan Azrad",
        "email": "matan@mellanox.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1518619646-23990-1-git-send-email-matan@mellanox.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35171/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35171/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B40F01B2B8;\n\tWed, 14 Feb 2018 15:47:44 +0100 (CET)",
            "from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-ve1eur01on0043.outbound.protection.outlook.com [104.47.1.43])\n\tby dpdk.org (Postfix) with ESMTP id BDB611B016\n\tfor <dev@dpdk.org>; Wed, 14 Feb 2018 15:47:43 +0100 (CET)",
            "from mellanox.com (37.142.13.130) by\n\tAM4PR0501MB2657.eurprd05.prod.outlook.com (2603:10a6:200:59::19) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18;\n\tWed, 14 Feb 2018 14:47:41 +0000"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=HxrcJR0yfSIVSelxqCWot/MJnldyluaxWrr6hxYn/B8=;\n\tb=a1GwPBG5/TjLwCQEgpjWLLEeWE/HuPMa3t3vUZpkKoTYhS6sdxpt90H3vebiN7Q0d3B0gWCmMklRlrXJprCHEge1OUBBCFA4dLV7biqT/duYYKVTr4/TCyBJdZpw9D+5vkJyfjupZZL8gl8ovFZNRinC9HgmuIW7Wo4lj/LjAro=",
        "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=matan@mellanox.com; ",
        "From": "Matan Azrad <matan@mellanox.com>",
        "To": "Gaetan Rivet <gaetan.rivet@6wind.com>",
        "Cc": "dev@dpdk.org",
        "Date": "Wed, 14 Feb 2018 14:47:26 +0000",
        "Message-Id": "<1518619646-23990-1-git-send-email-matan@mellanox.com>",
        "X-Mailer": "git-send-email 1.9.5",
        "In-Reply-To": "<1518562772-29823-1-git-send-email-matan@mellanox.com>",
        "References": "<1518562772-29823-1-git-send-email-matan@mellanox.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[37.142.13.130]",
        "X-ClientProxiedBy": "DB6PR0402CA0016.eurprd04.prod.outlook.com\n\t(2603:10a6:4:91::26) To AM4PR0501MB2657.eurprd05.prod.outlook.com\n\t(2603:10a6:200:59::19)",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-Office365-Filtering-HT": "Tenant",
        "X-MS-Office365-Filtering-Correlation-Id": "8e129f61-0859-4a9e-1c54-08d573b9e6e5",
        "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);\n\tSRVR:AM4PR0501MB2657; ",
        "X-Microsoft-Exchange-Diagnostics": [
            "1; AM4PR0501MB2657;\n\t3:9yACl3cYkFle/orCfVTma4gmX15Ir4NNDyIX85BNVL9nNoQ3xEF9oCapR4pR/l7l5aJS1Tx0EiO2KMrvMrUhYalcAAzxR770Q68gcZnqhmA8EsiqIsE2s/W4F9LmwCa9uJxfBgw60i43x4EqXdiPWDH9dFJU7cSWDBuUuAp0QpxaCpHHvXqJxrONwIZW1Kc+V+BdpTEStCEzQ+9t65AU036OsIAFnDfom0rQmT3uNFNcjvj2saqn/JeGSz5PqKzF;\n\t25:BWYDMo4tbJ8B9KbLAJOoqZzTKUFRp/IXRxPni/tNdSf/v5/VuG8b8DgV5AK7g3lW+BQ31bgoI+9TJSTtUs4fhtDSjRt/dzk756BtdrNLY1ChlDbZZ0G12z8drgqbgmNq6Z8f+GQhI2iYHAUwyZzOacLXI8KXVSPIwTcaDkVM5WpTrISG8t1Phj5t5bd86ziSnpMEHOvRZXgMknx+IyiUeomT65dGDQCYbsT55n/aEqp8a15WzgKvVhUtnp4ILC+zFGxGVfRyFVAgRjVFeYP3yRd7XrwjCQQimoSt19JIEtqT6RWJgr8ay4yl4OQGPx7skN8Myn2oChGkpWejophV1A==;\n\t31:L8hsetMIUjoLS7WS8YcHIKumcUDDQlBx752kQV1Kq9CLPLsAk/mQA0jf07lle6fI9kZ2rGa7tqq0aJu2UEzQe+OLhCbAfdIoC5oi1aw/UKB7QxQYns3sN/X1O7ONxMKZXTc9I5DEGGeCz5hsaeTdUoVBHp5XaTiPF6YU2X9r1TouhhBJe3OCizp62W6xDw8M+68Ugnj+9zxy/7AXbmsEvtO+zibw69Z3ulUQKLrLhBw=",
            "1; AM4PR0501MB2657;\n\t20:e21k3KJRc/JQ/tY1FbEH93cr9L6pqGsJ3rPly1Ev1HqIMgLG9+MJ03TdkgpDfVhOoeA2iS6BsAnT+9sR/SXkrpnqfs9MVo+91A8lJakpMmWEGW6GmvJnPVtm0ywFwFuHDEjSB7VZU+pPGu22ZKcp1qEODQ+hGLCvZ40rjSh+boIKTossWlQ/xjn6ADZzdXf9LOjRjY9q6tO5jUOmI8oj8xwMtvbCa7zOloNgxyg+2XTBUZd13lJWzQj+avE+4HwocUk7026zSmH1u/mXrpPNKneMWVilm9iOgctpvfYrl3+ZU+yQm935RVC1i3kA7P7bGzAZp/uikDwSNc+ZSNRzzlLIy0Jd/hEB5NinIoKPSPUwGJ+Du/TFNAnel9mHNaW64ebxhinNNBzYEBs3qoQ4SqEhHrDOZwfBZmaoC0gNLgxd9a1t6JgbS9RhkpSP1c4dGujsV5GnpGbEoY4m2Az/KiOG/G7kCAA9lhbB4A+Dh8Ht59X6bFBtwuunpAhMNabP;\n\t4:PSzMB1+kL/74tPf8ud5y1JekRM2OtOEHKyg7quJOU1XNpChaT+8TAO//XrHsIbsAq64ml8wa/3MnEBQ/SQC6Xf+STrHRgGB7rraFCx25ofNdNMl98HqpUZfbEgDyVfrWPubhXr4BdY39V+OwZByudYZ1trndJ/K+NiHvF/7U2YiF4+v570D0x5zvXcEFR3U02gojsOIeo6zkc6dbyzgmAB/AkvkVbH8riHohSn6husgv+gSpCi1Fs9x5IA1apwEIAffJcC3t7+y4L3/UmAxAbw==",
            "=?us-ascii?Q?1; AM4PR0501MB2657;\n\t23:qIYqZ5mNnaJGYvbf1lH+PpRYDn9xZnNol5Cs5bs?=\n\t0/HOG5dmE+cKFtzY1r1dyXpjrCIlvBJYtIdVvxq5WYuKbt+qVrRHyNhOYQYyyyILlhjgwkLUcqRUW+i8Hzm0LNLXMwS4dPqngz4dVrL4u2kjd4s3XdlI919uc7b061TeYhQYnzT6ba59LL0SBiy7jwLo+KIkAsA/jh9ieeRQjRnLMBCfZXjJ+FJWZVolRPYFIds47DSe2eMKtPIOD2p2zagtMJ6bFF03IgK1GtefbRc9Y4VK5wvJ83BpKpfF4L2xS3hN5blQDHzfjzvtj5ZsQAX6Mq3hZAJ2zCtVODTBwVVWLNKOYRgMUqZ8uLpeBwO3fwhd4Bu+L75sjG5DcF5ZQe0IWjehdS+TpuTUQg9AskS+CJ+ZMQAAiFBHI5FONVKISIPxCjlZGMmKaQGTHbdkvHwT7yFdj6xev0CQBc/tc6xllMxuNBSBeJUEnKK3hELVp0V0kps28d7xNtw6exmvUB97SU6GQvg1CatKqAx3lRwgk/NP33QG3KV2PT2EJWlmsAuTXgvdACvdc6ttVae5YWoQhvVOs3SXIR5Bks9S1Ng5dfld803Ztd02sHS4Ra5aCdUIcVl8Ky1oC0d+ZwpUUJPfAjI+cOv0i/+qoafQTVjp0g11nN/KuJgnP8TQyRIqZhdDcBKTXsUoBJpqm8qQAySu5SkCxpOnuNDKCrF9bTqxk79381IGdWuyiBA7c1JBXNO9M9ZFzw72oiwhvzFFvYZT1BkmLFWvNxHJHuvfW6fxUKOXFTiyvu4OJfYaMRZXneg/gpUk+lf4MptCSfomDlFxC6r5M+85046mGYGHJdNIKsj22Yf9PPcS48uA33ZoymDfzQCre2nzmUXgC5bGryyhMQOqessjOSQS/pVspgEbsj3v7Hm9Dmn//U/HsLqOf6Vcac1Jdg9l7Vl9dk8YoaMLhNtB1RJhHyd5sSMtixRkM3UFrK2/yt7pJVAe64vHc+BYRX01y7EhP3ROAV5jX/lvSJeh92TgJgFVMpS/Qzm+EBzzgRiftQvhEdqiUe7YVdaSB/z+oAYVbNBbMwJ4gipT8qXmB/yATNE//8lk/FMNb26v/sxPRlulykQt8LWTcknxIvVh6KxuVpEaCYW0/oNqJT+GpTykUDr/0MVk99L+0AWRnT5WO05vewaELX+csax4=",
            "1; AM4PR0501MB2657;\n\t6:Vz39U9k/Dfztui58ey1lE2IvJvE/ILy9DqpgrdJ9u00WKChcegXNFrbKD/lEVZeUxDje9m6hHisnET6kixdF/QqwwdFwIwwV7jItrmxzmiPY07aSWYCX+co9bJv9DXJf0l8+CDJy0QatNvpyqDOstLIxpRlpO0t46uD3fnbrLX/VcxFR545tpyi9DcyRTIfDAkZGG1thW6LERgJWemmUrzq8lejEjJokQp32QTN+H8AjqlNyZWyW+Lo1ZySkUjD8wq1h12IoNV3WEiiWLSdoO9ru7H2/ji1LLqMzLkZ7EB5Y4H38HabWPr0l7obcUj3h5/rGraNUoxWVj128z8zWKJZWnc1SFVkD27OhtSZyWks=;\n\t5:w4as8HHGQUygk3JiLvbzAed2/D0CZl1gJFe8z/jTKHsFONVfa5VdCS8Q3GhHgRONl/FoSdngvDR2O+gt/Nn+y8iSle2wXGJNlrZyoNvLnNA7vodop4Dq357J2VvDANLxtu+LILhsQ87SXa3wNvy+APapPVGq3UtX/FrM16j0xy8=;\n\t24:qTmk9b5xFmLnKyNyG3gDEm7Q28uHHLMpJd1uWHNq5FbemQIA7knRgEu+vTdD2wGkE4C4STA5ZV8+3STmve0dnifS/ekRKZUUMmDzd6ZSkoA=;\n\t7:Mg4ibBfxyFk3wEIKlk0AbOjilfOfyieDOitvrgVHBMs+x0cxjSZa+ZMJsd68tIIh0iXt2diM97GcZulQbzaq8OlWecSpp0wqqDAsuvt6HJcyRFoqLwkfcpkU3SiO0ZNbUJzrLQZ+eBY6kI1zdS1qK6ssEndZwbslb88j87TueQ05re3T0fPmviwLZnXfmRSPeX3ClEGKGREh5wI+unplTIWBesc9vjH72vCK1DtSB4dAG9G5ByFkLf8CFE1Ecc9F"
        ],
        "X-MS-TrafficTypeDiagnostic": "AM4PR0501MB2657:",
        "X-Microsoft-Antispam-PRVS": "<AM4PR0501MB265754C33DAA3CD681082984D2F50@AM4PR0501MB2657.eurprd05.prod.outlook.com>",
        "X-Exchange-Antispam-Report-Test": "UriScan:;",
        "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231101)(944501161)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);\n\tSRVR:AM4PR0501MB2657; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2657; ",
        "X-Forefront-PRVS": "0583A86C08",
        "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(39380400002)(39860400002)(376002)(396003)(346002)(189003)(199004)(53936002)(7696005)(36756003)(305945005)(76176011)(21086003)(7736002)(97736004)(55016002)(478600001)(33026002)(16586007)(2906002)(186003)(16526019)(26005)(59450400001)(2950100002)(6916009)(6666003)(386003)(81166006)(81156014)(50466002)(105586002)(48376002)(8936002)(25786009)(8676002)(4326008)(316002)(106356001)(3846002)(6116002)(86362001)(52116002)(66066001)(69596002)(68736007)(5660300001)(51416003)(47776003)(50226002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2657; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ",
        "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)",
        "SpamDiagnosticOutput": "1:99",
        "SpamDiagnosticMetadata": "NSPM",
        "X-OriginatorOrg": "Mellanox.com",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Feb 2018 14:47:41.6930\n\t(UTC)",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "8e129f61-0859-4a9e-1c54-08d573b9e6e5",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR0501MB2657",
        "Subject": "[dpdk-dev] [PATCH v2] net/failsafe: fix Rx interrupt reinstallation",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fail-safe dev_start() operation can be called by both the application\nand the hot-plug alarm mechanism.\n\nThe installation of Rx interrupt are triggered from dev_start() in any\ntime it is called while actually the Rx interrupt should be installed\nonly by the application calls.\n\nSo, each plug-in event causes reinstallation which causes memory leak\nand spoils the fail-safe Rx interrupt mechanism.\n\nTrigger the Rx interrupt installation only when it does not exist.\n\nFixes: 9e0360aebf23 (\"net/failsafe: register as Rx interrupt mode\")\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/failsafe/failsafe_intr.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/failsafe/failsafe_intr.c b/drivers/net/failsafe/failsafe_intr.c\nindex f6ff04d..6b7f9c1 100644\n--- a/drivers/net/failsafe/failsafe_intr.c\n+++ b/drivers/net/failsafe/failsafe_intr.c\n@@ -523,7 +523,7 @@ void failsafe_rx_intr_uninstall_subdevice(struct sub_device *sdev)\n \tconst struct rte_intr_conf *const intr_conf =\n \t\t\t&priv->dev->data->dev_conf.intr_conf;\n \n-\tif (intr_conf->rxq == 0)\n+\tif (intr_conf->rxq == 0 || dev->intr_handle != NULL)\n \t\treturn 0;\n \tif (fs_rx_intr_vec_install(priv) < 0)\n \t\treturn -rte_errno;\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}