Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35156,
    "url": "http://patches.dpdk.org/api/patches/35156/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180213225430.15556-1-3chas3@gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180213225430.15556-1-3chas3@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180213225430.15556-1-3chas3@gmail.com",
    "date": "2018-02-13T22:54:30",
    "name": "[dpdk-dev] net/bonding: fix link properties with autoneg",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "3b4ccb97e8b21944b79c2fcea900439619383086",
    "submitter": {
        "id": 341,
        "url": "http://patches.dpdk.org/api/people/341/?format=api",
        "name": "Chas Williams",
        "email": "3chas3@gmail.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180213225430.15556-1-3chas3@gmail.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35156/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35156/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ED23D1B2B8;\n\tTue, 13 Feb 2018 23:54:37 +0100 (CET)",
            "from mail-qk0-f195.google.com (mail-qk0-f195.google.com\n\t[209.85.220.195]) by dpdk.org (Postfix) with ESMTP id B3D0D1B1B3\n\tfor <dev@dpdk.org>; Tue, 13 Feb 2018 23:54:36 +0100 (CET)",
            "by mail-qk0-f195.google.com with SMTP id n198so167716qke.7\n\tfor <dev@dpdk.org>; Tue, 13 Feb 2018 14:54:36 -0800 (PST)",
            "from monolith.home (pool-173-79-224-159.washdc.fios.verizon.net.\n\t[173.79.224.159]) by smtp.gmail.com with ESMTPSA id\n\tw201sm915632qkb.52.2018.02.13.14.54.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 13 Feb 2018 14:54:35 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=WgRzJdERXbHGmPacs/NtKhN4rt43Adj44PzhC+OgZu4=;\n\tb=IlCHbDn629UwZ2XcdHNwSDqiGjojmqzb5BgO3E9cnGLtEwgFasroEVp+R9mjH2HyCP\n\t2WIvwYL7szq51tDoVA514gVBc+VsHEg+qOy4vsUn0Ccs29f7lL4yHFPf7o6bP2lkucTB\n\teDan5mGEVA1NcCGinsJPndXxiE8cxn66aW8Xz04a/AZ1nw/WrlgXeg0pxEbvxgl7zunN\n\tZ3HImYqmXESh74hYtI8ADbbURM+HBIqRl0o/pi/m1d5izn66qw5Piu6Wd+AYnyTo2kML\n\t2nwtXXHU0yI/gJXMBreKivOsjjeOQMAdOvzvFsDK6/Jc/d6xCyKsYbSAj9N45qIeIk/a\n\tyIVQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=WgRzJdERXbHGmPacs/NtKhN4rt43Adj44PzhC+OgZu4=;\n\tb=Kl28ls8ba9ZJW30jns5I6W18nV+URRO3jDcA6O4BxX9IVNwgUT3tw5tS+pc13ztJRf\n\tWmzBpf03bUsi0znIjxBC8GESuoCz8wJVbUP1M+Hxrqr4ZNy+EBlWfpEuINdqfaZWvHz/\n\t/iFVYxNiVKupKE3jTPjOBwuPThcuAejSZDxTIQcEE1vsjfrakaArFTJkfUCL5Kw+YZfi\n\tZ4uITsjiNOiiIXuuDfSgbN21C+JmXowZRDVsI+P1HHplyzGctOy6JiihqKX+iCtxbQSf\n\tVws9krpO9N1jeFbOYuuwhssSB983m0ghBjkBVmZida0VYYlHmR5L91QlGGWHJAG/a818\n\tImkw==",
        "X-Gm-Message-State": "APf1xPDSfQGRIdww6xb3fjAVC6pJ5pxf1L7c1KJc2y+Q6dSmTXult5BK\n\tiSow3xSXDOwJw9/6elGorfjGpQ==",
        "X-Google-Smtp-Source": "AH8x224Z4vffZn3qL3g16iso//2JfM+wRKTS2QBFnpSqZEZ46otIYiAHawX8TxIJniVnuuTmYWrDuA==",
        "X-Received": "by 10.55.168.80 with SMTP id r77mr4565932qke.157.1518562475953; \n\tTue, 13 Feb 2018 14:54:35 -0800 (PST)",
        "From": "Chas Williams <3chas3@gmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "declan.doherty@intel.com,\n\tChas Williams <chas3@att.com>",
        "Date": "Tue, 13 Feb 2018 17:54:30 -0500",
        "Message-Id": "<20180213225430.15556-1-3chas3@gmail.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "Subject": "[dpdk-dev] [PATCH] net/bonding: fix link properties with autoneg",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Chas Williams <chas3@att.com>\n\nIf a link is carrier down and using autonegotiation, then the PMD may not\nhave detected a speed yet.  In this case the best we can do is ignore the\nlink speed and duplex since they aren't valid.  To be completely correct,\nthere should be additional checks to prevent a slave that negotiates a\ndifferent speed from being activated.\n\nSigned-off-by: Chas Williams <chas3@att.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 92ad688..5559879 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1545,9 +1545,10 @@ link_properties_valid(struct rte_eth_dev *ethdev,\n \tif (bond_ctx->mode == BONDING_MODE_8023AD) {\n \t\tstruct rte_eth_link *bond_link = &bond_ctx->mode4.slave_link;\n \n-\t\tif (bond_link->link_duplex != slave_link->link_duplex ||\n-\t\t\tbond_link->link_autoneg != slave_link->link_autoneg ||\n-\t\t\tbond_link->link_speed != slave_link->link_speed)\n+\t\tif (bond_link->link_autoneg != slave_link->link_autoneg ||\n+\t\t    (bond_link->link_autoneg != ETH_LINK_AUTONEG &&\n+\t\t     (bond_link->link_duplex != slave_link->link_duplex ||\n+\t\t      bond_link->link_speed != slave_link->link_speed)))\n \t\t\treturn -1;\n \t}\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}