Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35154/?format=api
{ "id": 35154, "url": "http://patches.dpdk.org/api/patches/35154/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180213221324.24524-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180213221324.24524-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20180213221324.24524-1-thomas@monjalon.net", "date": "2018-02-13T22:13:24", "name": "[dpdk-dev,v2] net/failsafe: fix FreeBSD build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7bf88da49bfd352c3c29cf4ab779429c0d7feb0b", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180213221324.24524-1-thomas@monjalon.net/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35154/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C49B51B1D3;\n\tTue, 13 Feb 2018 23:13:38 +0100 (CET)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n\t[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 7A6BD160\n\tfor <dev@dpdk.org>; Tue, 13 Feb 2018 23:13:37 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 0351621564;\n\tTue, 13 Feb 2018 17:13:37 -0500 (EST)", "from frontend2 ([10.202.2.161])\n\tby compute1.internal (MEProxy); Tue, 13 Feb 2018 17:13:37 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 534F6246AC;\n\tTue, 13 Feb 2018 17:13:36 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tcc:date:from:in-reply-to:message-id:references:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=/O3Q06MbWbsIS6\n\tEwmI5TlnUHeKWcMttEHR3RIKEqJb0=; b=Sd82r+7wk7oagQabXtg8SfJug65XDB\n\t5agrNYKXPXES/EpT9Ppj+djUUXLjf/6QaRSea340QK6gRIkf4Y74bVi7erHpUjEJ\n\tsIHGlMZi8Ma12qkoFj09gNPeGjb3TK6Ho4j7e8TWzUr3i8y0Y6Pw2DzgDp6AQ/u3\n\tkdHZBBGc821Uw=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm2; bh=/O3Q06MbWbsIS6EwmI5TlnUHeKWcMttEHR3RIKEqJb0=; b=AhsxsrI/\n\t/WLXn9t6Q1+XLI1UN1SnCoc30PduA1IdTTwg0buZz/quay0tYVDh9vU9wWi2G/ry\n\timf/i4QI3d3pzOjRwgKYM4J1vVmO5HZW8LNFDsWotksTjq+KWBa6dJf7U/HgQESq\n\t0C6jx+6obVAaq99ooNlg/HKCdimAy2EayPdRrtJ/w6B75wt3Wg0/Y+ftdJF3U9Sx\n\tTn3UlXeK9Oou1q/zPNgn/BIW1TIAMLC0rvZ11IkYAzOvg9Gw5Q9xVJewAjNhoURO\n\tSQw1OKj/uGBIuH1HXcKfqsfkTKfN/1d32FSn78ZRBzsOC5peUGm+ynBbLli42LqV\n\tQoy0pa4sOWRsTw==" ], "X-ME-Sender": "<xms:EGODWoRDsZP3iqs4oaJZY_GJhfTyp23-d-m0KylxRwrF0KLwo-tPtg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "matan@mellanox.com", "Cc": "dev@dpdk.org,\n\tgaetan.rivet@6wind.com", "Date": "Tue, 13 Feb 2018 23:13:24 +0100", "Message-Id": "<20180213221324.24524-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20180213213312.22225-1-thomas@monjalon.net>", "References": "<20180213213312.22225-1-thomas@monjalon.net>", "Subject": "[dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The type pthread_t is not portable because it is freely defined.\nOn Linux, it is an unsigned long int which can be printed with %l.\nOn FreeBSD, it is a pointer which can be printed with %p.\n\nThat's why there was this error:\ndrivers/net/failsafe/failsafe_private.h:377:53: error:\n\tformat specifies type 'unsigned long' but the argument has\n\ttype 'pthread_t' (aka 'struct pthread *')\n\nFixes: 655fcd68c7d2 (\"net/failsafe: fix hotplug races\")\n\nReported-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\nv2: adapt printing to BSD and Linux\n---\n drivers/net/failsafe/failsafe_private.h | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h\nindex 5b84db905..2d16ba4ca 100644\n--- a/drivers/net/failsafe/failsafe_private.h\n+++ b/drivers/net/failsafe/failsafe_private.h\n@@ -318,6 +318,14 @@ extern int mac_from_arg;\n \t &((struct txq *)((s)->fs_dev->data->tx_queues[i]))->refcnt[(s)->sid] \\\n \t)\n \n+#ifdef RTE_EXEC_ENV_BSDAPP\n+#define FS_THREADID_TYPE void*\n+#define FS_THREADID_FMT \"p\"\n+#else\n+#define FS_THREADID_TYPE unsigned long\n+#define FS_THREADID_FMT \"lu\"\n+#endif\n+\n #define LOG__(level, m, ...) \\\n \tRTE_LOG(level, PMD, \"net_failsafe: \" m \"%c\", __VA_ARGS__)\n #define LOG_(level, ...) LOG__(level, __VA_ARGS__, '\\n')\n@@ -374,7 +382,8 @@ fs_lock(struct rte_eth_dev *dev, unsigned int is_alarm)\n \t\t\treturn ret;\n \t\t}\n \t}\n-\tDEBUG(\"Hot-plug mutex was locked by thread %lu%s\", pthread_self(),\n+\tDEBUG(\"Hot-plug mutex was locked by thread %\" FS_THREADID_FMT \"%s\",\n+\t (FS_THREADID_TYPE)pthread_self(),\n \t PRIV(dev)->alarm_lock ? \" by the hot-plug alarm\" : \"\");\n \treturn ret;\n }\n@@ -397,8 +406,8 @@ fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)\n \tif (ret)\n \t\tERROR(\"Cannot unlock hot-plug mutex(%s)\", strerror(ret));\n \telse\n-\t\tDEBUG(\"Hot-plug mutex was unlocked by thread %lu%s\",\n-\t\t pthread_self(),\n+\t\tDEBUG(\"Hot-plug mutex was unlocked by thread %\" FS_THREADID_FMT \"%s\",\n+\t\t (FS_THREADID_TYPE)pthread_self(),\n \t\t prev_alarm_lock ? \" by the hot-plug alarm\" : \"\");\n }\n \n", "prefixes": [ "dpdk-dev", "v2" ] }