Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35153/?format=api
{ "id": 35153, "url": "http://patches.dpdk.org/api/patches/35153/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180213213312.22225-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180213213312.22225-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20180213213312.22225-1-thomas@monjalon.net", "date": "2018-02-13T21:33:12", "name": "[dpdk-dev] net/failsafe: fix FreeBSD build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a69896ed3054ea68e8fa0cda33090d87ea053e66", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180213213312.22225-1-thomas@monjalon.net/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35153/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/35153/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 663D61B327;\n\tTue, 13 Feb 2018 22:33:49 +0100 (CET)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n\t[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E21751B321\n\tfor <dev@dpdk.org>; Tue, 13 Feb 2018 22:33:47 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 2F00421855;\n\tTue, 13 Feb 2018 16:33:46 -0500 (EST)", "from frontend2 ([10.202.2.161])\n\tby compute1.internal (MEProxy); Tue, 13 Feb 2018 16:33:46 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 5F97A246AC;\n\tTue, 13 Feb 2018 16:33:45 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tcc:date:from:message-id:subject:to:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=mesmtp; bh=63w0H9R8RQKnwlyHGhg0dAZvGPOsgImvQrs8VR\n\tX0WQs=; b=OmVfq8LmDme0aMx8esPc+czRX6rpOKGxlUj+aga6H1ItxscSBXWWZg\n\tipbYTdW3uTcMALUYCoDf2/USZujntEuGwVj8nPDWBqra6KPYYos/627xPJqJ+qAE\n\tZZSSOwyb8pFuU7vfnny2BHl9eJQNb5KgxcagkNJEIUix5cH/Zbm1k=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=63w0H9R8RQKnwlyHG\n\thg0dAZvGPOsgImvQrs8VRX0WQs=; b=K3jRmhnxxLH8OPyEeAa4o2ob38XOhloXE\n\tIjCtntPTFWIoJNwhi2LSJe+3ttCHPa970RnbA8S/Xc2e2EAFSt+NegwU52O7c0DM\n\tLq5ZLZXdWOfO0pexanWi9kIl9JfCTHBmtOCAmXQRl7Pp4jDnm/sIcJq+CFoan/Ak\n\tQqLKX0ZSELf0BvbcDm2lXYf3S0kSrzrhCqi37AiN+9oOwP4C44e5YWNjP7EFYcOd\n\tA6zyZYNeBw+qTRqY0mLWooXDoTAqKnowXlLiToH14XV8R6so1etRL99/jWrZ5gjs\n\tJcbB6eJRh4i67tVbINMoJJK3/vMXFTKz96ARuq90cbhbLloCZoHfQ==" ], "X-ME-Sender": "<xms:ulmDWuKRFs8--DADl1CVgFe2z9SWFGNmvfvpYGMTwzMnZWNa0qe36w>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "matan@mellanox.com", "Cc": "dev@dpdk.org,\n\tgaetan.rivet@6wind.com", "Date": "Tue, 13 Feb 2018 22:33:12 +0100", "Message-Id": "<20180213213312.22225-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.15.1", "Subject": "[dpdk-dev] [PATCH] net/failsafe: fix FreeBSD build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The type pthread_t is not portable because it is freely defined.\nOn Linux, it is an unsigned long int which can be printed with %l.\n\nThe debug printing of the thread id is restricted to Linux only.\n\nFixes: 655fcd68c7d2 (\"net/failsafe: fix hotplug races\")\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/failsafe/failsafe_private.h | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h\nindex 5b84db905..86ade029f 100644\n--- a/drivers/net/failsafe/failsafe_private.h\n+++ b/drivers/net/failsafe/failsafe_private.h\n@@ -374,8 +374,10 @@ fs_lock(struct rte_eth_dev *dev, unsigned int is_alarm)\n \t\t\treturn ret;\n \t\t}\n \t}\n+#ifdef RTE_EXEC_ENV_LINUXAPP\n \tDEBUG(\"Hot-plug mutex was locked by thread %lu%s\", pthread_self(),\n \t PRIV(dev)->alarm_lock ? \" by the hot-plug alarm\" : \"\");\n+#endif\n \treturn ret;\n }\n \n@@ -387,7 +389,6 @@ static inline void\n fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)\n {\n \tint ret;\n-\tunsigned int prev_alarm_lock = PRIV(dev)->alarm_lock;\n \n \tif (is_alarm) {\n \t\tRTE_ASSERT(PRIV(dev)->alarm_lock == 1);\n@@ -396,10 +397,14 @@ fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)\n \tret = pthread_mutex_unlock(&PRIV(dev)->hotplug_mutex);\n \tif (ret)\n \t\tERROR(\"Cannot unlock hot-plug mutex(%s)\", strerror(ret));\n-\telse\n+#ifdef RTE_EXEC_ENV_LINUXAPP\n+\telse {\n+\t\tunsigned int prev_alarm_lock = PRIV(dev)->alarm_lock;\n \t\tDEBUG(\"Hot-plug mutex was unlocked by thread %lu%s\",\n \t\t pthread_self(),\n \t\t prev_alarm_lock ? \" by the hot-plug alarm\" : \"\");\n+\t}\n+#endif\n }\n \n /*\n", "prefixes": [ "dpdk-dev" ] }