Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35146/?format=api
{ "id": 35146, "url": "http://patches.dpdk.org/api/patches/35146/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180213123155.44183-1-shahafs@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180213123155.44183-1-shahafs@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180213123155.44183-1-shahafs@mellanox.com", "date": "2018-02-13T12:31:55", "name": "[dpdk-dev] net/mlx5: revert multicast rule Verbs flow type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fe7a7cf0e527500318e9cdf78b8730e44776b905", "submitter": { "id": 634, "url": "http://patches.dpdk.org/api/people/634/?format=api", "name": "Shahaf Shuler", "email": "shahafs@mellanox.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180213123155.44183-1-shahafs@mellanox.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35146/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35146/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 45FAD1B1C1;\n\tTue, 13 Feb 2018 13:32:14 +0100 (CET)", "from EUR01-DB5-obe.outbound.protection.outlook.com\n\t(mail-db5eur01on0043.outbound.protection.outlook.com [104.47.2.43])\n\tby dpdk.org (Postfix) with ESMTP id 4F4061B1B6;\n\tTue, 13 Feb 2018 13:32:13 +0100 (CET)", "from mellanox.com (141.226.120.58) by\n\tDB6PR05MB3144.eurprd05.prod.outlook.com (2603:10a6:6:1a::18) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10;\n\tTue, 13 Feb 2018 12:32:08 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=dUTD3WDqA0dEzlwFdECCE0RvbxB2Goa0ryqlIk8MVzk=;\n\tb=OlNqPwwpbbNSk/x61mUutGkoMyAKCV+mDLuEjrAXxd5HLWu7pORJI1Ug0c76aFvNStkRtrb0YZsJmFj6UciLvAVfR3RgLcYNu/FCaohRZ7L9sCEwa46AgrFar761apwFlyY3wAeS6LfHj2uvmAZJGBgekp2Y2SKIVTpT5fmxuX4=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shahafs@mellanox.com; ", "From": "Shahaf Shuler <shahafs@mellanox.com>", "To": "adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,\n\tyskoh@mellanox.com, thomas@monjalon.net", "Cc": "dev@dpdk.org,\n\trasland@mellanox.com,\n\tstable@dpdk.org", "Date": "Tue, 13 Feb 2018 14:31:55 +0200", "Message-Id": "<20180213123155.44183-1-shahafs@mellanox.com>", "X-Mailer": "git-send-email 2.12.0", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[141.226.120.58]", "X-ClientProxiedBy": "LO2P265CA0050.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:600:60::14) To DB6PR05MB3144.eurprd05.prod.outlook.com\n\t(2603:10a6:6:1a::18)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "de42065a-c0c2-43a9-088f-08d572ddccf7", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);\n\tSRVR:DB6PR05MB3144; ", "X-Microsoft-Exchange-Diagnostics": [ "1; DB6PR05MB3144;\n\t3:DI6x4IEsXnVK/9hFenyUtCKik5QgrT7ce8CIaxvMgLsAO3tcoJiMJ8x2l/imYpVMT5Fn5Un4a3N9JPuFZkL0NEar9ms8naMMJT0mjWnihAhjbq4Uh28B5NqSjbZatykrrS9T+TDEmEqpPsnsFTyoqDSZPBqAvUo9M2myt0GFJFRGWcH46z55ria388E2Xek5UBE6KMhwl4CGTHc5Nw4H7K+QcLEotTXkbUPUtHG58gEYqh+EPZzcXrJ1CdQ19K/g;\n\t25:cDptitYunxhL53N2WSFiRWuevJWoM14gc0cMPWC2GUM5MhQTV+s0VtY/bIBdaHucPhimFUjWEpMz0pTWD7dExP3r5EVALx7aST5YYX4JdNtNAD0fvaC6NPnhMXYbLwSphI73t5YMgsVBMmQtAnHfQwNX4sYhaDfAfmvGtLIIzp/pZOxIE/el4ms8E5lquSmvuaWZkrF2kB/IT0K/p9SGsBYPf2brj91akYci5A14BdviyifOepicuARtby7iHXun6qZqIYghKcuwYryOUK5+ygPadA6zIBgP+jCk1i/DqAUmwu0beLDxI+Mgg0e82JhGVxvBlm+F2Fg/j7DoWW84Mg==;\n\t31:4kx6F5GiEnXzL3JcJ7Xj545jc7ZBHE4VrupGwvd27ExN4WU+SDVQ9PY6zBwgegytuAKugWshnOLkYulWuea4tkqT/OuS1oT831YY2jjVISHEOx+cMqA+pCnA14ImW0KdkRIdxaiFEK83tu20dgf+GY0VU2tqtrHuv3N5hFzb7wxNp/JmpoojU4m0If+OeL3WCdzAGPZIM+uhzC6huyekvTk2A5x5NAy/oBBA0npRKQE=", "1; DB6PR05MB3144;\n\t20:RWTpdqHGGfNpIYnCUoYk8sTQvJ6N3z8cyOy6c5yuiquPUHgkcy85oKhb2WPxeS90AFqbxn1csENfoNGmJlZlSg5ZW01ljHc4s9m7KD4KwcFZKDcSZyuZbHorx+XZe2U0iP1ZTHV7pjZ71r0I3l7SNZRfYPRFw0lnzm04Xa3STfTLQ0Fv3LrCkvPMGWtQXc9ubOjR30pr2uYBmtMgTimP+fHiRmnajWlofjHJB3OvV4TauR9kVo6NNsrTHg8gO7jr+7hbeu1N2m3/Dq/+RmtJhN5JScvpETHk22hN2tm28CI2NpdRDqbHmYgPdMehpIYT0EA1yIhEWh8j/3zOqnbjfP559WXfBHwK1BHE+cY7aS+7Nc/Sd/KdaFg/032G7+9Iy1kzzEY5bFJprH4SNmUfAkHcaB+TL7L7enhNewybuAC2p/QbbWmX2E/2h6EQYZEuK0MfPbcx0307oyOsQXlBRH3tj6hJMI5Zw6xtYZbj62/GyD+B0zeuDtWtm6Q2IslP;\n\t4:8kbRvz+0yY2+fOYhQxUCgsrksqFPDG1vEBc97cN0PECAFZg/ubFiXruYUGpzlSu6CUT0ZcJuv6ekdMlU4FTV2YAZAzD49gEZWdjlcKKez5+qrs9LajKEX28mUCEJZLlRhi4ydUUL2/25de8Y6WX/YgEeBbuI/BwQoYG5TY9pTbyCDP5SXNTBMJ163Xd6WMK3cuUH2G280VvSDcexCekR4+irVLGeMtUnUNQ41fc/ni42775fK95uYqimHw+bPWgcWiKnN6aEKmFBpkjOBIFUGQ==", "=?us-ascii?Q?1; DB6PR05MB3144;\n\t23:fguBYYK8G9pBvKi0gGYVI7u/WzAh9gbHmnhlHB48A?=\n\tqo3dAPeNGGWXlir1K0+aZJcpZ+Wre9PKwUDS1jGmAoIJQUPjqC8guY77lvktLAYAsE85XknVJia7lsBxdEdyQ1gmCefnGAAxV8DFKM1epk8sVUV9kQRnfiwEbymLCx5hibShJ0tD4B2JutVreJ1DqvRaAIwGVoNy8Y9mZTVE6jwIOeg5NvqYNnYFXRJ6MWdQFd3ZG2Sgj1o59w8UreOiHnuLsUogflfxL7UbIjhz/rs+XUCnqSV677Iuei4VfYD4mqJMzPg7ArFK535so+jm3MAuew9L9mkwHp0wuuDfOjlPl5NzsoLYhkegXzChUaEy1Tw/uk3jeIijnq32QPdMgMFGV/YPgxDTAsZX6bAhEcL6YQl1FSaZ98JAFjR0nzac6q9QcGot1zedlO7R6L/o8uk72ZpToIMWz/xzoSGrzwsF3LBzr7N9K6V2br4qcObCcHW5hoOaa5awRSvM5UdTu0bEkG38jSx7abiY5P5FfZtJqsv3Nm1S+d9yBcDo1cGoGX4cLpkJCGF5161os5VDYVdNEo+FqcyIFfKHp31X2OiXfakkxFyLaV8LmxRMqoXx354Ho/AlF584tdN3tD9sqn7l4JsEyKUOmYq4sXKXz6Pze10y4rGN/CpPnvhQsApvbBSB/ws4GxPNwq2JhZMPz/K6C96b4MKt5G50GZ2RGMcSBkklwKqBaqyTIdZhQtM8W20tyy4NQuY0Jovupb/DKjtq83Jr8vi9HxVI14LZKf6vNilNHSVhB1OQDPrQs4UwGdUxTU1k8+mxpK8N3tsKlEwXbjkJmB0CHeP2GZZfkucy57h8+fV3tLzpj3db1btYbdjxfDWyp9KyHpq67Woh2d6ebZk4ZsHKkh0NqJNNMEALzu990tWioGRlV6ddOPKPQJXRpRkE8Ec7jBmFb4YuXTPQ3mkB0L8qeDIg93m3Goh47Ni4JlpWjaNkdl5vQNjCk/hZbozQHxRVvdEPKCzQblxVf3urU5CQSPJ2Ziqd7DLfXVcbZlcTSHKi8ND+vUQCGIE7QYOvwF4SyJ8m3hHy5Vk+2Z3KYtmUUxujOVnsh31AnXz5PO1tiwgJCqFgirWJ9njcoZilxKfq6qWnLglTxiW", "1; DB6PR05MB3144;\n\t6:f+UrS9PTzsk/kJzGQFBoWXs4ltn8MOISxO8N+SgzUGeB/JAjsKR7wi+sYHkIVFxHB4clXOKftsiWYtgRWIkGO2rnPp8nZkgGVsWXUCUtGhKoJ8lmTLG6C6DAA+/w7FL+tbU1LNVB2zZigrucrbjOeOSY9mKLHnLlUFRy+vLZ2PVk5xBvAMgC5nHGdtrlk35JaRmhn76qfN9CC1ePXlE/r7B0/7T3xBn0VBjG3B41hvdb4GbM3y4iopN5I7SaZ3mQN2lrK97VWnmjAjLFHJcvDiyjFnLAlm65//RN25IAkaZD0+eLyheZ7GmsmnEY98ynNcqxi3iM2EMLZkx8CHUoZrcdKN05y6rzRaIzLr9nPkw=;\n\t5:J8JF7WruqhiV0+EMvV1CqjY0snRz5bELt/hpe4Y4zTWcqaKrSx1rikvGELsq17rT+i3k98bsK3MnVAWaGwN5SAP80t/8Fvh0FLkRXtf4xK6BTMWZAP0VtzZ96RMxw50HMclO5qGq0ClosCQpwE3mYGgkSa15YAMH0tGHS7MKbqI=;\n\t24:+cdoyZZI8RXF7cLkIjvAw2aJcN5RuaCqYWfJ5cWf2BODQvqihj19Udqwx4C/IHDETLSGJnNUTpLYwYDIr9bstH19jxL/iDJh5uhth2W7FAw=;\n\t7:L6lhIhqhbSWMRNAwMLOpe9FCucQ0ZvmhCiC2/8g4r/7coqR0sEp+imE3xjchxwYsI1NZ2w5fPL+X5uKs5tgBHU363iCABQf9wiGHFIgx6HshM20fqeHvbxB6hk7d64offmsvYZEpckW42iv8XIPR5Sl+JnKCF+kE1L6vtC5kSKU4X200jNSjECZlWTRuGjhCKdaIpQtofwcvdTZEIdsxHSG+F40ks4DM2Q2uSOigM/mv+7OznE7bBTP5H60K8iBo" ], "X-MS-TrafficTypeDiagnostic": "DB6PR05MB3144:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-Microsoft-Antispam-PRVS": "<DB6PR05MB314474D2FCBAD235C933DD53C3F60@DB6PR05MB3144.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);\n\tSRVR:DB6PR05MB3144; BCL:0; PCL:0; RULEID:; SRVR:DB6PR05MB3144; ", "X-Forefront-PRVS": "0582641F53", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(366004)(39380400002)(376002)(39860400002)(346002)(199004)(189003)(53936002)(25786009)(86362001)(51416003)(48376002)(105586002)(50226002)(68736007)(16526019)(8936002)(21086003)(5660300001)(52116002)(3846002)(55016002)(7696005)(316002)(386003)(97736004)(47776003)(26005)(478600001)(66066001)(2906002)(16586007)(36756003)(186003)(59450400001)(106356001)(1857600001)(81166006)(69596002)(6666003)(8676002)(50466002)(1076002)(81156014)(6116002)(4326008)(7736002)(305945005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3144; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Feb 2018 12:32:08.6904\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "de42065a-c0c2-43a9-088f-08d572ddccf7", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB6PR05MB3144", "Subject": "[dpdk-dev] [PATCH] net/mlx5: revert multicast rule Verbs flow type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is to revert the following commits:\ncommit da646bd93888 (\"net/mlx5: fix all multi verification code position\")\ncommit 0a40a1363a4d (\"net/mlx5: fix flow type for allmulti rules\")\n\nThe last one introduced a bug in the following diff:\n@ -1262,6 +1274,7 @@ struct ibv_spec_header {\n eth.val.ether_type &= eth.mask.ether_type;\n }\n mlx5_flow_create_copy(parser, ð, eth_size);\n+ parser->allmulti = eth.val.dst_mac[0] & 1;\n return 0;\n }\n\nAs broadcast rules will be considered of type allmulti as well.\n\nThe patch was originally intended to enable VF to receive all multicast\ntraffic by using the IBV_FLOW_ATTR_MC_DEFAULT flow type.\nSince the support was removed from the kernel there is no point with\nfixing this issue, hence the revert.\n\nCc: nelio.laranjeiro@6wind.com\nCc: rasland@mellanox.com\nCc: stable@dpdk.org\n\nSigned-off-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 13 -------------\n 1 file changed, 13 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex f88ece123..323dab723 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -391,7 +391,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {\n /** Structure to pass to the conversion function. */\n struct mlx5_flow_parse {\n \tuint32_t inner; /**< Set once VXLAN is encountered. */\n-\tuint32_t allmulti:1; /**< Set once allmulti dst MAC is encountered. */\n \tuint32_t create:1;\n \t/**< Whether resources should remain after a validate. */\n \tuint32_t drop:1; /**< Target is a drop queue. */\n@@ -1128,17 +1127,6 @@ priv_flow_convert(struct priv *priv,\n \t\t\tattr->priority +\n \t\t\thash_rxq_init[parser->layer].flow_priority;\n \t}\n-\tif (parser->allmulti &&\n-\t parser->layer == HASH_RXQ_ETH) {\n-\t\tfor (i = 0; i != hash_rxq_init_n; ++i) {\n-\t\t\tif (!parser->queue[i].ibv_attr)\n-\t\t\t\tcontinue;\n-\t\t\tif (parser->queue[i].ibv_attr->num_of_specs != 1)\n-\t\t\t\tbreak;\n-\t\t\tparser->queue[i].ibv_attr->type =\n-\t\t\t\t\t\tIBV_FLOW_ATTR_MC_DEFAULT;\n-\t\t}\n-\t}\n exit_free:\n \t/* Only verification is expected, all resources should be released. */\n \tif (!parser->create) {\n@@ -1246,7 +1234,6 @@ mlx5_flow_create_eth(const struct rte_flow_item *item,\n \t\teth.val.ether_type &= eth.mask.ether_type;\n \t}\n \tmlx5_flow_create_copy(parser, ð, eth_size);\n-\tparser->allmulti = eth.val.dst_mac[0] & 1;\n \treturn 0;\n }\n \n", "prefixes": [ "dpdk-dev" ] }