Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35139/?format=api
{ "id": 35139, "url": "http://patches.dpdk.org/api/patches/35139/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1518468702-16719-2-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1518468702-16719-2-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1518468702-16719-2-git-send-email-matan@mellanox.com", "date": "2018-02-12T20:51:40", "name": "[dpdk-dev,v7,1/3] net/failsafe: fix hotplug alarm cancel", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "085ebc75e9a29dde7f9cf4ffb6f7bce432cef3d9", "submitter": { "id": 796, "url": "http://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1518468702-16719-2-git-send-email-matan@mellanox.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35139/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0A4EF1B388;\n\tMon, 12 Feb 2018 21:52:05 +0100 (CET)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-ve1eur01on0081.outbound.protection.outlook.com [104.47.1.81])\n\tby dpdk.org (Postfix) with ESMTP id 1EC831B2E5;\n\tMon, 12 Feb 2018 21:52:02 +0100 (CET)", "from mellanox.com (37.142.13.130) by\n\tDB6PR0501MB2664.eurprd05.prod.outlook.com (2603:10a6:4:80::22) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10;\n\tMon, 12 Feb 2018 20:51:59 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=/kc4voP6j35mQuIhbZeEv3vQQqAwBEse8x+vUTmyNsE=;\n\tb=pHq9D/35I5Fk0xYeIhb0hdC9nJ5dx57pOk8pnk4mZLiVIV9wjRz5CVg7cEaotALWfC7w/2OYkf4YyaTAv5vwqmyfyhC8R0igBMIjjTAAM72++nzs0Yo+1fs4nllrWHHioJC1zM9GLatf97z4TlX/waSItC4h9lsiZ7ophmhgvZw=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=matan@mellanox.com; ", "From": "Matan Azrad <matan@mellanox.com>", "To": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Mon, 12 Feb 2018 20:51:40 +0000", "Message-Id": "<1518468702-16719-2-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.9.5", "In-Reply-To": "<1518468702-16719-1-git-send-email-matan@mellanox.com>", "References": "<1518369872-12324-1-git-send-email-matan@mellanox.com>\n\t<1518468702-16719-1-git-send-email-matan@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[37.142.13.130]", "X-ClientProxiedBy": "HE1P191CA0004.EURP191.PROD.OUTLOOK.COM\n\t(2603:10a6:3:cf::14)\n\tTo DB6PR0501MB2664.eurprd05.prod.outlook.com\n\t(2603:10a6:4:80::22)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "c5ada4fb-de1a-4c99-ddf8-08d5725a76b2", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);\n\tSRVR:DB6PR0501MB2664; ", "X-Microsoft-Exchange-Diagnostics": [ "1; DB6PR0501MB2664;\n\t3:KmFJ7XoUZQb28oKNb5vUVjFJczeGtiahmXki8NBnTJtr7oDBtuouzeDFNJuPtlvrDCLGOTUVWxIWTy1Adqvo3xp7KSM+zAGgcagu/e6gb51wslCwkab15S8zzLMzCS0jdtYFXuOCBW7WzlHzo3oq3llR704tgoQpusr+4mQEF+w/T3xwYdLho+DF99RUWEMmxfWVSPuwb85GTIfRegASbjDrxURN89eGhzUjVZ22dmiNeCBvQxm/ELKmQ6cCYk8Y;\n\t25:BnIntToB5mYGH7mjREIpSgp5rnouWeWB8FYzInwH+gyNg6QUXEuhmd2FfQU4r4gm8Ru4PcoW0zmz8ZoxEhE9iJb084simcB0bAYSF+rlUq10Yhp5+Jis/wwt8vo086+QpuZVj3uPh4PVVrJWUSwlr5oTl/JI66EaaEBbfJPhq8GzXnzkyeSfViXtL5sZC11LI3Ss/HhUu7RKiNA2zN0+5Vy3usUmOZMYuSjGhc/5yYishyJsQAsjA/MNl3WgbztNme+QZ5xJktt+G1wa+bLXE6JQIK1gVn2hCekDN92v7ZBmNnYfKPrN5DF3Lr8VHimQ5GFrOUQ0+jPgtE7fW7igoQ==;\n\t31:7yR3Ll2XVD51jZG4NGTT4L/ABIOTtHS0G3ybQlTsisY2wOhwtO9ONz5FCbin2+Ew3Nky50lFXSrqbvgLjZrVKr80mym43FtgQB2tiMm5Oail36TK1H4fJyRXqrjyhBNllQt+sZjg//nA4es0Ru3po3bC6E/iAv1fdNwvQBVUK4YmoSbbZHzXMpsrZeh+UDDODhVmCFj15tkX8J5l1JtN8sH4JEVdyW7z7eqCUQWJYhc=", "1; DB6PR0501MB2664;\n\t20:3hrjn969XtNV33JKDa0/BS+Pgx6szGNOAoPLo6ax2FO7OCch8BGTl1u+a/1X1/0Q8sajzKQvc9plXC+YzBcB6tdYe7p66DGXl5HJ/GcOuUzeJXWjwgGW1FfNpOlpI72UkKcrAoJZhlUtSJ1LP5C2SYJcBjfzIdAwGfn0eKqXCwe1TY6e3asmiu4Lhp+TJmxGA3vQy+TLBGmTXoEO+oHuqAlzJ8f6C5fnhb4Ud+ouSaroxfa78oBO4MrT4/kuo3O+bqWq/8y7x0QifKvnrVdNvAV+5GpiYVYEQ0v8WiY1EPf8hLpCI1np8ULcMc1Vl8RlbyAIskzEzO2/w7xas48+65tv6x/28saMaFWxUHNKSn4uZflC+DXZVpkv68VzBEddOY2E0pCbqVgIFBzjCBEJXe3f/jiMxXlD9WQaVosoJTc0hAKUQ7W6ZkFAVMcyF5g4ZmeqyDjHYg8wZQCAy8I9wvIU9m0hXNJF7NmAZEyXm1LY6Wm93F66vWImy1Skhgt6;\n\t4:kv1UcyHGTL6X0fvh4r8kslHGi0jJkMpIrNzhMEl617w5marwALbgMgcpYvrI87qcKhikWdI98SD0N2wpiTxDCJeOVk9h1fVLbglstN3YA0qfajIM57utA41QaPf86OybInIcXChpWEWnD952Ot/X4SjDmVOFU34tBbAoRvk4Ti/GF/0KPSMnhJWqrF/QYtY+Z5DduVvbzWd9kB95xO9tvmS9V6jpHbexZ0NKG6zJYn56S2zoZDj9bPvDahq9VSYYkLxF460YatMef0e5GglD+w==", "=?us-ascii?Q?1; DB6PR0501MB2664;\n\t23:q08fCdLdOVvOYXwYvSkcEReI9y13yJ9EoWJiM4I?=\n\t394IMJyeVlYRrL6AnKq0AM5QhA8aiOyhLIW0+foEHxNvtHTmhzE7uyQSqHmoLMCNs/97heUWaQsJH64/PQEUX5NcNeBib8P/2xtwgkNSy0kjETgHf6Z0bE8ENhQpYfuh2vC2kbOYZc0oXrnH+baKlM0nVevkuYUZG72oqjNIRwK7WAwU5kK1RfgJKe99wHCjJDn7f6SwmcMp3hjMnK/1uwSmTUA3/cT0caY1L4QQlrpfM+fD3iMSsWYgn3tSPMek8YDav28MwmYBLwsUYAD6xqiuxf/lQ3kGJ1KD/pGbHiQa8iXtoyTGhgg41y6llciyDn6SuJXNN8/F/eddcM5srrVb6flgiBA6J5ap++JT8bnD2DI3acFx/GFOFV2wmTpV4ktc4YdljhMBxYZnkFU56T5hXTKwDvyU19I6PPmrARJB7a2NdhCmyRcGL/45qxjNQuoxZ/D5/0Wa7FJnMaFBWxz0cmadfKuut8X5UV/h/mv8rwNPuDgqQAaRo7430nVxmwOOTRVGvCcW9FfXDZteqPW8Sb1+XCuBjb0e7B8SXK3fWG9ARnlO1/NSBPzUcQmArLyXEwb1tQiIeDgBcMMBgZy7T1CptYeB+9eynyc5NozImBdZdxt2+lylDT1tO+7jKu06Ez3QuMJd1a+9S2bwwr/AJflEhaGXYfGNba97VNeGRhB/YIEZASFL6pO/2qcAaNnNHl+6G1tv/uFh7XmKOD1kouKLYBogTlRQU1OKeju+mzR5fOOpj9L9XMaKl+jrj0wYQILVIqgRaAL+u/IO5jZ7IoqFgrEM0PfPkV0WcmQVBr+G3D40MGN8SU3qi+kZW5FIY+bedezkGsVfZe3ulI8aOTdObrGQzLpjzAjG6pwJNgP0GwUKXmn3WnVOzxy8xB8wuEgEUoOaDZME6Ah9hv0ZWaUFc/eUaFB3pLCjLqFiinW1b7Cx+4PpT39yWyXkaNKcy6mdyOyYxg42cgkfeR+6Cm4Eu0yQu8+B9fNCAHcGHVwdhEqfCn9HUkJ2dWfqVSYucNZZBJCcUp3sN2yDCA/3rVESfGI76tqtLww/3Tmj7KW0Fk2KC1qbwWHhOweAH4hkPMd9nxIZebOsBNSEVrq51U8FHUQ/SZcVAchVIIY02+xAOP973CUiyXDyrXDzNz5s=", "1; DB6PR0501MB2664;\n\t6:6K1ktT/HtATj/5uweyUIQ6l26GYLKnFbBDNjTONixZjtaABz2QWTFzVV6MQbIOUUC89HK+iI7GVWNzqp5kKvO8Sorifm6G4oeI3USyPvDVPQB/JC9kCTe6BDc+37JemGJtx0hNZcfOHGacBSPNWUspo01QnE/dMBRJHhb2IbvQ7/pQYUHUDmxhOnHLVox3YTCk1lymi3QLsPRMExBQtaI2stg6+C5fewEoyY5GyISb0d/FxGmzJ/6G0QJD5c/Uxu7L3tRIE5UaQGWx+9Q/DdWYkdcBsKVtaJvSfG14u7PcVyw+35+ENF53BtVuDd8pWCwJ3WJRtj+qIquJnD2nShI09kJmjDwnecxDjFzMkukWs=;\n\t5:8++qGt7Rx1JReGWtk1a3fuQfMA/1lN42sEmiCHSr/aRONLOUpErm2D59N8wF9pHDD6eTu6x2S6fAfg7ayWxt5G2YsB4A8F98hEpgiaDx4F2Pe7sEL/OzUvfDXGZTJIn+pq5M7X6u5MvlEg7+w+pqKHqoqMzT6s9FnfCXH9McdyM=;\n\t24:9awxNAC3+8m1upaUMe/QlBxpnt4UJ7hcepSXrZP7BsWkefLQnAwEYVhwOMzWzmiVuoSEct88ral/VyO2Ujf738XDxwAmeMhlqcnfEthAQU0=;\n\t7:AZ2um+LvZ5vF3fZ7tAWfV40kPOjiieN1IUxUsSmzwhum7E3kpKq1fIUKHxCFlsSNeydj3m4kqciCslNQXkDnifg8TyIrj72MDbXbGzD0xHfhKPoMdeOXQ+K8ahohjHsbzWXpUF/eE1TdkCDgS0VR26eG76O+/HsshJV/KBdMts/lxxu0vD/8Ed8CXULl4dhVuQGiCMc+ix4UcQKpTsWF9RFOCXk5P1qYGxGvodf+uIBvRZfFcjAI3P1eZB9dCe2X" ], "X-MS-TrafficTypeDiagnostic": "DB6PR0501MB2664:", "X-Microsoft-Antispam-PRVS": "<DB6PR0501MB26645193482922A716D499CDD2F70@DB6PR0501MB2664.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231101)(944501161)(6055026)(6041288)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);\n\tSRVR:DB6PR0501MB2664; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2664; ", "X-Forefront-PRVS": "0581B5AB35", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(39860400002)(396003)(39380400002)(366004)(376002)(189003)(199004)(478600001)(8936002)(6666003)(81166006)(81156014)(50226002)(76176011)(68736007)(6916009)(69596002)(8676002)(2950100002)(305945005)(7736002)(33026002)(316002)(36756003)(21086003)(16586007)(48376002)(105586002)(26005)(55016002)(25786009)(4326008)(186003)(53936002)(97736004)(66066001)(16526019)(106356001)(47776003)(52116002)(51416003)(5660300001)(59450400001)(7696005)(2906002)(386003)(86362001)(6116002)(50466002)(3846002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2664; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Feb 2018 20:51:59.7318\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "c5ada4fb-de1a-4c99-ddf8-08d5725a76b2", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB6PR0501MB2664", "Subject": "[dpdk-dev] [PATCH v7 1/3] net/failsafe: fix hotplug alarm cancel", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The hot-plug alarm mechanism of fail-safe PMD is responsible for\nhandling removed devices during a plug-out event and to restore them\nback to activity following a plug-in event.\n\nFail-safe sets a flag called \"pending_alarm\" to validate that only one\nalarm callback is pending at any time. While this flag is required to\navoid simultaneous initiations of the alarm thread - it should not be\nconsidered during alarm thread cancellation.\n\nSo, when failsafe_hotplug_alarm_cancel() was called while the alarm\ncallback was being executed the alarm mechanism was not stopped.\n\nSkip checking the \"pending_alarm\" flag to allow alarm thread\ncancellation all the times.\n\nFixes: ebea83f899d8 (\"net/failsafe: add plug-in support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/failsafe/failsafe.c | 18 ++++++++----------\n 1 file changed, 8 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex 2665a39..7b2cdbb 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -85,16 +85,14 @@ failsafe_hotplug_alarm_cancel(struct rte_eth_dev *dev)\n {\n \tint ret = 0;\n \n-\tif (PRIV(dev)->pending_alarm) {\n-\t\trte_errno = 0;\n-\t\trte_eal_alarm_cancel(fs_hotplug_alarm, dev);\n-\t\tif (rte_errno) {\n-\t\t\tERROR(\"rte_eal_alarm_cancel failed (errno: %s)\",\n-\t\t\t strerror(rte_errno));\n-\t\t\tret = -rte_errno;\n-\t\t} else {\n-\t\t\tPRIV(dev)->pending_alarm = 0;\n-\t\t}\n+\trte_errno = 0;\n+\trte_eal_alarm_cancel(fs_hotplug_alarm, dev);\n+\tif (rte_errno) {\n+\t\tERROR(\"rte_eal_alarm_cancel failed (errno: %s)\",\n+\t\t strerror(rte_errno));\n+\t\tret = -rte_errno;\n+\t} else {\n+\t\tPRIV(dev)->pending_alarm = 0;\n \t}\n \treturn ret;\n }\n", "prefixes": [ "dpdk-dev", "v7", "1/3" ] }