Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35132,
    "url": "http://patches.dpdk.org/api/patches/35132/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1518446598-24238-1-git-send-email-ophirmu@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1518446598-24238-1-git-send-email-ophirmu@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1518446598-24238-1-git-send-email-ophirmu@mellanox.com",
    "date": "2018-02-12T14:43:18",
    "name": "[dpdk-dev,v1] net/tap: fix CRC stripping capability report",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2e75e9b2ded4c92a3e7d7dc9c0d4e208e49e7577",
    "submitter": {
        "id": 793,
        "url": "http://patches.dpdk.org/api/people/793/?format=api",
        "name": "Ophir Munk",
        "email": "ophirmu@mellanox.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1518446598-24238-1-git-send-email-ophirmu@mellanox.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35132/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35132/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8E3DC1B367;\n\tMon, 12 Feb 2018 15:43:36 +0100 (CET)",
            "from EUR03-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr50057.outbound.protection.outlook.com [40.107.5.57])\n\tby dpdk.org (Postfix) with ESMTP id 663061B352;\n\tMon, 12 Feb 2018 15:43:35 +0100 (CET)",
            "from mellanox.com (37.142.13.130) by\n\tVI1PR0502MB3887.eurprd05.prod.outlook.com (52.134.6.12) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.485.10; Mon, 12 Feb 2018 14:43:32 +0000"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=7IJzQcsoeeTpDR9F0EIoH1KwZuP3VAFQHV3USiJG8gY=;\n\tb=hvod1dVIkXWiIsr7VfEPwIw4MUtUcBPaj6ccj8uqB3agq54YmIrc5xuVDkKiAryIe5SmbPPpwFPSXW9gjCkMrjPxH5bmi6h3TAf2aMerzse6DI1n6vnrO8jb5I2Z+XFyPb+BkojoOoL3zHcjMkGyRJGftwCejRWGVbNTIK/mT0k=",
        "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=ophirmu@mellanox.com; ",
        "From": "Ophir Munk <ophirmu@mellanox.com>",
        "To": "dev@dpdk.org,\n\tPascal Mazon <pascal.mazon@6wind.com>",
        "Cc": "Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>, \n\tOphir Munk <ophirmu@mellanox.com>, stable@dpdk.org",
        "Date": "Mon, 12 Feb 2018 14:43:18 +0000",
        "Message-Id": "<1518446598-24238-1-git-send-email-ophirmu@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[37.142.13.130]",
        "X-ClientProxiedBy": "VI1PR0701CA0055.eurprd07.prod.outlook.com (10.168.131.145)\n\tTo VI1PR0502MB3887.eurprd05.prod.outlook.com (52.134.6.12)",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-Office365-Filtering-HT": "Tenant",
        "X-MS-Office365-Filtering-Correlation-Id": "433c607d-0364-41a9-1e63-08d57226fd7f",
        "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);\n\tSRVR:VI1PR0502MB3887; ",
        "X-Microsoft-Exchange-Diagnostics": [
            "1; VI1PR0502MB3887;\n\t3:Dnkr+liQRTtYaf1y6/0GBcjSI+sqUzJCv9qQr/c9sQwPIZPO6d9Hrn88sR33EdM0Q+tRb6f/Z0ErZRvSYeIn8asE/Tqba27q0T2jLb931dlXNbbxXxUHDLRyaTTnJEDC9BaapMN2510e43Kgqb13W1tVonBCaO4oCv9mIWv1RTjxnBVyBfWm4G58B1o0UcrODLgyZ3mqUDVGcYjrYvkRwStmV5FEB8wxAoIcBtcg+Xni3iK5XIYn0GDANC1OziQP;\n\t25:xjPf7YDyI14sRnNOAdhmrhx8ORnS5PBKXCyOfP1wWVzuFw0tXHGnf23mirbmHM9/Lw5+zkJ/VMD5nI+gm5Gsj5Do/IilsUuQzxAauT3K6E18Ky9F2AgYAiEmuNosBU1qcOlh02/iLpMXUhbEklnFecyO1pokabwvawPvV6P6ZRDUiMyr1+76d+CTnBrnmpP9mh/b1/jwVxh8qUEko4CUos3b8+Xs8PZPjvTvJ14Bjt3WgNTVIbS2nDi7inT1SCJUSxKpqNqm3W6pz8GnDo0hwJnguGTIuFaduSYkc90sUUsEQmiY12aYaaaFb9zrbuWxIemM/kavM/u+VXIPea31jA==;\n\t31:0b3GU3QZIXFOe0Q3vJZGTMYuZvc53cPw2xO/HN2iQ0IGlYLI9jBeGaFLVTfX4GaHcizAhl87WEBuGQgR0VgHR50XcHaqP9WcD5T3Uw/8tb2u7DjM1zPuPb+iGR/hCJ8Uyd5bUATA8tpiSVvtobwm7VF1sV7RP34WEplsj1oqPqaEVJbHl6IjcMHwXX/8rRd164bKxonj3RY9bHHCKxofr5sqlWMihGDOQpGohUcBp34=",
            "1; VI1PR0502MB3887;\n\t20:EoJh4w44e77lwwCzjt24PysHqdwaImCmC+rkPX31r7/NCRH8lG7jQbMHhT+VIbZFMS2HjQXzvEZ58Wluj7f2dzKoGYj2qWkd0DoYdYBFwrk24uv+0ejpyaBTRmt4rcufmM3fukJ3i7/AOwQbkfTUpem5RJ2s0n0eZjluyC/juEouks8SIHSClI0RkRjMCGZDx+30YKzkmGZP6sc5dpVInZpZAjNt3NfEGb+fPvEdWjhGIiXeLSWmKOMs1Aa3Q/e3RLlV5MgdFC8cg1NRMDoCm6d2c07PA7lXtVL2MaKoToUnRPGDgCXCOdaH1P++A2KFG0Xja9fQiW8mYv26JgHy3k53xZKjt2dRvsdnSbDt3jbyjKFubKYYCG1PgIVtp2mHlcVptDh2h3wgsQrEaqlDKNZpVmQdG6FLm6qCwba5ciaOzCRIA1BTltchNc+DQhBtcIJtoihscoW/HcgTZqoFZ1nI/jVDfqupW5tnIhYcxc+kl7j3TS6NLEO2oaoc3ZjB;\n\t4:MvIuu3TxjIV9Kav6wQhnMHqB1eYYXgmWrXXgOw1XW/+vBUUan6uIfR2AUJnIOmkYljI9yY+k2ldfXUTLS40jfMeRTr10IpOLl9EGlcrKC185bNWSk9ELIgBnYyKix3XPI082pJm6dp0HYPxt8POfxZ7QEQYUZkqZsu797w8/TgZSKL9rv6aGrDDYhH8VOYTYn6O+6VAXFWbn5Sdw815kf+Okdv3Mbka/RA2erQ4T3mN28CPlNXQ6GAa2qaa62EOUPiR4JAcyT8yE1dP3viiAXqmG+uCy5iESE/Ur4jrvZLrLdLjgWQVqg/QaZ8yoIVNr",
            "=?us-ascii?Q?1; VI1PR0502MB3887;\n\t23:Mk7NKG3K3oRdbBbQIP47SOOOR6octnI8dQHTRba?=\n\tyv+2rubLvqFt6PMIb7yU5P0LvlaS442NO9EJfo+5AyBCcjifn2YpZhOpa4tWbSy0zSKjk/lXpxZXSPTQ052srJhFxMvaIAcXDrUP1wJeyqhxkCkmmwdKJvqbZbf5A+b2Q1XqMOVWZ+08zHA/bBcfW5HC8M5FjF1gsY1mjE5g65b9DHqO7ocxPKPHwq+42qSpJE7DJl7nArQNWaXMZ9RNEc+ScS8IgsEi0/XNiiEs7whaRGF22hbyeu63wCk+CzHrYAj/JiBjBTEBAnMr7CaVdsR69FzAHsV+m8jl62LmReHkn24V24J+JRLV2pXl+oYMjKOWqHBJmZMvBt+WgfiIgD3x0Vw2bFKLvw+iCjtL4I6VbXGPOWQ5YvapQk1NCDzaJLqlpW0zWCH0Xed5qQ+53K7GtgM1w/YFt4Q638h0arPhci/M3lgWhfcwV3ykN/h8w3YAJD/GI05u3x4n+NBmMzr3Rd4lMBP2AsfbbXDtOaS3617QHru8E9uNm8sSu13o+Y0lPbRkDa3uiV8ko7Ohvygm2Mu9LQhg7O/0Aad8eVn6BxHui8Q002yZQTDv3IJFpWF2Hh+SBLPDHTfph3qMIU5flcc1g7GBBWBRCL+c04IichChrepdOhKWxHer5BQpH7PlEkcK03QuQQGi3R51GFR+LqZ1CXwZ8bmcW9Bgm8XL+HwxuYGHpxXtBIxgVrf1dsP10wkB50raF5D6y89BZupUPaNXgPowgGG0vZP+e1xy4TGTh0UYZNcKfsDwl+1nvIt3SDBKZFwLEVFc6rlwWqSCGqnq5s+sqMv5g5x+7VbRCgy6NhEG3v05hHK1DAzRmzJAWh5YXdbGLMBZ97vKtqAxD3H1i6GLmbA86dpDhRRFbNVdCQxNArASzuz0TSegKL2rdThZLxr9enOD8Mdt0cNKBF0pCiM124RtLy0ip/K9VOJd9U/+KH1wbeONqhT8lOjRwJDjxe7RvmH1wXpzKEZc05K7ZeYxbQJ1gHAhKRhaajKoXRFBOGJ3wbA0e3Ag5g8sMMKQPaO/W+ce6D7jo4DMHtdHHe3JcWegnTAKCO9J8ob46R6RcEWkGNxu4dLbIqaAME6HfOhUQ+Ew/EinPQ5h6GIafbyofmUjSFV9KZE0KQpJFCGw3EraX63rmm62v1abg8f0JrEA00GFnKKOela7g",
            "1; VI1PR0502MB3887;\n\t6:tXQYbxLjMnG1M2z/qXeDgS2qbEdka8392S65CNqAqnAaBqxUf4PbQOBGx9neXJdjFB9+OSBKphxeqcrLZnp5LowqYernx/yFtoVX8PMmgGp2lEic3mF7+AB51QeTls1MVRtfjRusuQotZXjJLFMcc83O1IW9Kw5hkfPJq/ZNAk1xbmWOs8tT4uq1rPjqGn3LL/QI5dbGdXHbyBf0+ookTnqQPaKCMwDSRNuPoRUerFOj3aZ3y9n7TXZsCmVz6/OlLvBRA1qhIJw2QE1Fo/1DaqP/B79aTCEsbS6XyLqa0RyQsrzvq/ZweVHSnPBKgi6pu7QS8rrANJSi97IXYCmgEtCfcgKnv2/NFyPVu7BNJw8=;\n\t5:hmhbVaD//mTz/V/WkrqihWIsU2cLQN0Qt2pGMS56QpgdbsI4n5Ua3urP4Vb/V2/yTf75FlT1Ul62LyrloBmWA3aMcg9mHlmJTa8EHXsUlla1LJq7aDMM62niB9BWOjh3KvQVXU/nBnF6p72YwZsgjMtzN0L+dwCacmYMX3W2kzs=;\n\t24:TRVkYNSsRVK8uT8zcLVB3ZN212hJEjzbgBvI03+Myxnh1+sC9gb71Q1kOYzPObTyaH8BjF+v8OwYB/+FlxzWAaZW7l0eSD9LzXwrK7kk/WU=;\n\t7:Fmn4DCMuYZRFGqoU1RO9J3uOgTL+UYUq46Nt9xDVrC2a+kJRknDCMUZ+19nRGq3/X/ASO8spJBHBTE7977I0zH3pLC58CfR1rBswjTbqrxOPkSZh7F50EIdKSijbR19EJDoMdtHp1+iLRnBw9gFtHeVRjvnOgXRtc3E+FiCifub9JaX2K3plmro47g3hSlFMkBVlpa2ElctMF1vIrLmcL1UqnVl/ViRYC0BMPC563L5eSpV6lq9MszX7KLaVssd/"
        ],
        "X-MS-TrafficTypeDiagnostic": "VI1PR0502MB3887:",
        "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr",
        "X-Microsoft-Antispam-PRVS": "<VI1PR0502MB38878BA8872A7DF06A947A3ED1F70@VI1PR0502MB3887.eurprd05.prod.outlook.com>",
        "X-Exchange-Antispam-Report-Test": "UriScan:(20558992708506);",
        "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(2400082)(944501161)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041288)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);\n\tSRVR:VI1PR0502MB3887; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB3887; ",
        "X-Forefront-PRVS": "0581B5AB35",
        "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(39860400002)(346002)(396003)(376002)(39380400002)(366004)(199004)(189003)(16526019)(186003)(5660300001)(53936002)(97736004)(36756003)(55016002)(26005)(7696005)(52116002)(51416003)(4326008)(25786009)(7736002)(69596002)(105586002)(66066001)(6666003)(305945005)(6916009)(47776003)(4720700003)(6116002)(68736007)(33026002)(478600001)(86362001)(50466002)(106356001)(3846002)(575784001)(21086003)(48376002)(8676002)(2906002)(81156014)(81166006)(50226002)(54906003)(316002)(8936002)(16586007)(386003)(168613001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3887; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ",
        "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)",
        "SpamDiagnosticOutput": "1:99",
        "SpamDiagnosticMetadata": "NSPM",
        "X-OriginatorOrg": "Mellanox.com",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Feb 2018 14:43:32.1489\n\t(UTC)",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "433c607d-0364-41a9-1e63-08d57226fd7f",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0502MB3887",
        "Subject": "[dpdk-dev] [PATCH v1] net/tap: fix CRC stripping capability report",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "CRC stripping is executed outside of TAP PMD scope. There is no\nprevention that TAP reports on Rx CRC stripping capability.\nIt is especially required when TAP is operating as failsafe sub-device\nwith another PCI sub-device which supports CRC stripping.\nIn the corrupted code TAP did not report on this capability which\ncaused failsafe to not report on it as well.\nThe fix is for TAP to report that Rx CRC stripping is supported.\n\nFixes: 95ae196ae10b (\"net/tap: use new Rx offloads API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\n---\n drivers/net/tap/rte_eth_tap.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 9d39384..f09db0e 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -261,7 +261,8 @@ tap_rx_offload_get_port_capa(void)\n \treturn DEV_RX_OFFLOAD_SCATTER |\n \t       DEV_RX_OFFLOAD_IPV4_CKSUM |\n \t       DEV_RX_OFFLOAD_UDP_CKSUM |\n-\t       DEV_RX_OFFLOAD_TCP_CKSUM;\n+\t       DEV_RX_OFFLOAD_TCP_CKSUM |\n+\t       DEV_RX_OFFLOAD_CRC_STRIP;\n }\n \n static uint64_t\n@@ -270,7 +271,8 @@ tap_rx_offload_get_queue_capa(void)\n \treturn DEV_RX_OFFLOAD_SCATTER |\n \t       DEV_RX_OFFLOAD_IPV4_CKSUM |\n \t       DEV_RX_OFFLOAD_UDP_CKSUM |\n-\t       DEV_RX_OFFLOAD_TCP_CKSUM;\n+\t       DEV_RX_OFFLOAD_TCP_CKSUM |\n+\t       DEV_RX_OFFLOAD_CRC_STRIP;\n }\n \n static bool\n",
    "prefixes": [
        "dpdk-dev",
        "v1"
    ]
}