Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35122,
    "url": "http://patches.dpdk.org/api/patches/35122/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180212045314.171616-5-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180212045314.171616-5-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180212045314.171616-5-qi.z.zhang@intel.com",
    "date": "2018-02-12T04:53:14",
    "name": "[dpdk-dev,4/4] net/i40e: enable deferred queue setup",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b2148c0841fd4d48152602e20b336298fb1b7061",
    "submitter": {
        "id": 504,
        "url": "http://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180212045314.171616-5-qi.z.zhang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35122/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35122/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 95ACA1B35C;\n\tMon, 12 Feb 2018 05:53:28 +0100 (CET)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id CC5401B342\n\tfor <dev@dpdk.org>; Mon, 12 Feb 2018 05:53:26 +0100 (CET)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Feb 2018 20:53:26 -0800",
            "from dpdk51.sh.intel.com ([10.67.110.184])\n\tby fmsmga001.fm.intel.com with ESMTP; 11 Feb 2018 20:53:25 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,500,1511856000\"; d=\"scan'208\";a=\"30009487\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "thomas@monjalon.net",
        "Cc": "dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com,\n\tarybchenko@solarflare.com, konstantin.ananyev@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>",
        "Date": "Mon, 12 Feb 2018 12:53:14 +0800",
        "Message-Id": "<20180212045314.171616-5-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "In-Reply-To": "<20180212045314.171616-1-qi.z.zhang@intel.com>",
        "References": "<20180212045314.171616-1-qi.z.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 4/4] net/i40e: enable deferred queue setup",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Expose the deferred queue configuration capability and enhance\ni40e_dev_[rx|tx]_queue_[setup|release] to handle the situation when\ndevice already started.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c |  6 ++++\n drivers/net/i40e/i40e_rxtx.c   | 62 ++++++++++++++++++++++++++++++++++++++++--\n 2 files changed, 66 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 06b0f03a1..843a0c42a 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -3195,6 +3195,12 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tDEV_TX_OFFLOAD_GRE_TNL_TSO |\n \t\tDEV_TX_OFFLOAD_IPIP_TNL_TSO |\n \t\tDEV_TX_OFFLOAD_GENEVE_TNL_TSO;\n+\tdev_info->deferred_queue_config_capa =\n+\t\tDEV_DEFERRED_RX_QUEUE_SETUP |\n+\t\tDEV_DEFERRED_TX_QUEUE_SETUP |\n+\t\tDEV_DEFERRED_RX_QUEUE_RELEASE |\n+\t\tDEV_DEFERRED_TX_QUEUE_RELEASE;\n+\n \tdev_info->hash_key_size = (I40E_PFQF_HKEY_MAX_INDEX + 1) *\n \t\t\t\t\t\tsizeof(uint32_t);\n \tdev_info->reta_size = pf->hash_lut_size;\ndiff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 1217e5a61..e5f532cf7 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -1712,6 +1712,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \tuint16_t len, i;\n \tuint16_t reg_idx, base, bsf, tc_mapping;\n \tint q_offset, use_def_burst_func = 1;\n+\tint ret = 0;\n \n \tif (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {\n \t\tvf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n@@ -1841,6 +1842,25 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t\t\trxq->dcb_tc = i;\n \t}\n \n+\tif (dev->data->dev_started) {\n+\t\tret = i40e_rx_queue_init(rxq);\n+\t\tif (ret != I40E_SUCCESS) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t    \"Failed to do RX queue initialization\");\n+\t\t\treturn ret;\n+\t\t}\n+\t\tif (ad->rx_vec_allowed)\n+\t\t\ti40e_rxq_vec_setup(rxq);\n+\t\tif (!rxq->rx_deferred_start) {\n+\t\t\tret = i40e_dev_rx_queue_start(dev, queue_idx);\n+\t\t\tif (ret != I40E_SUCCESS) {\n+\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t    \"Failed to start RX queue\");\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n \treturn 0;\n }\n \n@@ -1848,13 +1868,21 @@ void\n i40e_dev_rx_queue_release(void *rxq)\n {\n \tstruct i40e_rx_queue *q = (struct i40e_rx_queue *)rxq;\n+\tstruct rte_eth_dev *dev = &rte_eth_devices[q->port_id];\n \n \tif (!q) {\n \t\tPMD_DRV_LOG(DEBUG, \"Pointer to rxq is NULL\");\n \t\treturn;\n \t}\n \n-\ti40e_rx_queue_release_mbufs(q);\n+\tif (dev->data->dev_started) {\n+\t\tif (dev->data->rx_queue_state[q->queue_id] ==\n+\t\t\tRTE_ETH_QUEUE_STATE_STARTED)\n+\t\t\ti40e_dev_rx_queue_stop(dev, q->queue_id);\n+\t} else {\n+\t\ti40e_rx_queue_release_mbufs(q);\n+\t}\n+\n \trte_free(q->sw_ring);\n \trte_free(q);\n }\n@@ -1980,6 +2008,8 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \t\t\tconst struct rte_eth_txconf *tx_conf)\n {\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct i40e_adapter *ad =\n+\t\tI40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct i40e_vsi *vsi;\n \tstruct i40e_pf *pf = NULL;\n \tstruct i40e_vf *vf = NULL;\n@@ -1989,6 +2019,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \tuint16_t tx_rs_thresh, tx_free_thresh;\n \tuint16_t reg_idx, i, base, bsf, tc_mapping;\n \tint q_offset;\n+\tint ret = 0;\n \n \tif (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {\n \t\tvf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n@@ -2162,6 +2193,25 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \t\t\ttxq->dcb_tc = i;\n \t}\n \n+\tif (dev->data->dev_started) {\n+\t\tret = i40e_tx_queue_init(txq);\n+\t\tif (ret != I40E_SUCCESS) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t    \"Failed to do TX queue initialization\");\n+\t\t\treturn ret;\n+\t\t}\n+\t\tif (ad->tx_vec_allowed)\n+\t\t\ti40e_txq_vec_setup(txq);\n+\t\tif (!txq->tx_deferred_start) {\n+\t\t\tret = i40e_dev_tx_queue_start(dev, queue_idx);\n+\t\t\tif (ret != I40E_SUCCESS) {\n+\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t    \"Failed to start TX queue\");\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n \treturn 0;\n }\n \n@@ -2169,13 +2219,21 @@ void\n i40e_dev_tx_queue_release(void *txq)\n {\n \tstruct i40e_tx_queue *q = (struct i40e_tx_queue *)txq;\n+\tstruct rte_eth_dev *dev = &rte_eth_devices[q->port_id];\n \n \tif (!q) {\n \t\tPMD_DRV_LOG(DEBUG, \"Pointer to TX queue is NULL\");\n \t\treturn;\n \t}\n \n-\ti40e_tx_queue_release_mbufs(q);\n+\tif (dev->data->dev_started) {\n+\t\tif (dev->data->tx_queue_state[q->queue_id] ==\n+\t\t\tRTE_ETH_QUEUE_STATE_STARTED)\n+\t\t\ti40e_dev_tx_queue_stop(dev, q->queue_id);\n+\t} else {\n+\t\ti40e_tx_queue_release_mbufs(q);\n+\t}\n+\n \trte_free(q->sw_ring);\n \trte_free(q);\n }\n",
    "prefixes": [
        "dpdk-dev",
        "4/4"
    ]
}