Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35121/?format=api
{ "id": 35121, "url": "http://patches.dpdk.org/api/patches/35121/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180212045314.171616-4-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180212045314.171616-4-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180212045314.171616-4-qi.z.zhang@intel.com", "date": "2018-02-12T04:53:13", "name": "[dpdk-dev,3/4] app/testpmd: add command for queue setup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "72f67303f44c1ca640ecccb2861aa5673467944e", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180212045314.171616-4-qi.z.zhang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35121/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35121/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F3D4A1B354;\n\tMon, 12 Feb 2018 05:53:27 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 4B5EA1B335\n\tfor <dev@dpdk.org>; Mon, 12 Feb 2018 05:53:26 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Feb 2018 20:53:24 -0800", "from dpdk51.sh.intel.com ([10.67.110.184])\n\tby fmsmga001.fm.intel.com with ESMTP; 11 Feb 2018 20:53:23 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,500,1511856000\"; d=\"scan'208\";a=\"30009483\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "thomas@monjalon.net", "Cc": "dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com,\n\tarybchenko@solarflare.com, konstantin.ananyev@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Mon, 12 Feb 2018 12:53:13 +0800", "Message-Id": "<20180212045314.171616-4-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180212045314.171616-1-qi.z.zhang@intel.com>", "References": "<20180212045314.171616-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/4] app/testpmd: add command for queue setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add new command to setup queue:\nqueue setup (rx|tx) (port_id) (queue_idx) (ring_size)\n\nrte_eth_[rx|tx]_queue_setup will be called corresponsively\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n app/test-pmd/cmdline.c | 136 ++++++++++++++++++++++++++++\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++\n 2 files changed, 143 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex b4522f46a..b725f644d 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -774,6 +774,9 @@ static void cmd_help_long_parsed(void *parsed_result,\n \t\t\t\"port tm hierarchy commit (port_id) (clean_on_fail)\\n\"\n \t\t\t\"\tCommit tm hierarchy.\\n\\n\"\n \n+\t\t\t\"queue setup (rx|tx) (port_id) (queue_idx) (ring_size)\\n\"\n+\t\t\t\"\tsetup a not started queue or re-setup a started queue.\\n\\n\"\n+\n \t\t\t, list_pkt_forwarding_modes()\n \t\t);\n \t}\n@@ -16030,6 +16033,138 @@ cmdline_parse_inst_t cmd_load_from_file = {\n \t},\n };\n \n+/* Queue Setup */\n+\n+/* Common result structure for queue setup */\n+struct cmd_queue_setup_result {\n+\tcmdline_fixed_string_t queue;\n+\tcmdline_fixed_string_t setup;\n+\tcmdline_fixed_string_t rxtx;\n+\tportid_t port_id;\n+\tuint16_t queue_idx;\n+\tuint16_t ring_size;\n+};\n+\n+/* Common CLI fields for queue setup */\n+cmdline_parse_token_string_t cmd_queue_setup_queue =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, queue, \"queue\");\n+cmdline_parse_token_string_t cmd_queue_setup_setup =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, setup, \"setup\");\n+cmdline_parse_token_string_t cmd_queue_setup_rxtx =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, rxtx, \"rx#tx\");\n+cmdline_parse_token_num_t cmd_queue_setup_port_id =\n+\tTOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, port_id, UINT16);\n+cmdline_parse_token_num_t cmd_queue_setup_queue_idx =\n+\tTOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, queue_idx, UINT16);\n+cmdline_parse_token_num_t cmd_queue_setup_ring_size =\n+\tTOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, ring_size, UINT16);\n+\n+static void\n+cmd_queue_setup_parsed(\n+\tvoid *parsed_result,\n+\t__attribute__((unused)) struct cmdline *cl,\n+\t__attribute__((unused)) void *data)\n+{\n+\tstruct cmd_queue_setup_result *res = parsed_result;\n+\tstruct rte_port *port;\n+\tstruct rte_mempool *mp;\n+\tuint8_t rx = 1;\n+\tint ret;\n+\n+\tif (port_id_is_invalid(res->port_id, ENABLED_WARN))\n+\t\treturn;\n+\n+\tif (!strcmp(res->rxtx, \"tx\"))\n+\t\trx = 0;\n+\n+\tif (rx && res->ring_size <= rx_free_thresh) {\n+\t\tprintf(\"Invalid ring_size, must >= rx_free_thresh: %d\\n\",\n+\t\t\t\trx_free_thresh);\n+\t\treturn;\n+\t}\n+\n+\tif (rx && res->queue_idx >= nb_rxq) {\n+\t\tprintf(\"Invalid rx queue index, must < nb_rxq: %d\\n\",\n+\t\t\t\tnb_rxq);\n+\t\treturn;\n+\t}\n+\n+\tif (!rx && res->queue_idx >= nb_txq) {\n+\t\tprintf(\"Invalid tx queue index, must < nb_txq: %d\\n\",\n+\t\t\t\tnb_txq);\n+\t\treturn;\n+\t}\n+\n+\tport = &ports[res->port_id];\n+\tif (rx) {\n+\t\tif (numa_support &&\n+\t\t\t(rxring_numa[res->port_id] != NUMA_NO_CONFIG)) {\n+\t\t\tmp = mbuf_pool_find(rxring_numa[res->port_id]);\n+\t\t\tif (mp == NULL) {\n+\t\t\t\tprintf(\"Failed to setup RX queue: \"\n+\t\t\t\t\t\"No mempool allocation\"\n+\t\t\t\t\t\" on the socket %d\\n\",\n+\t\t\t\t\trxring_numa[res->port_id]);\n+\t\t\t\treturn;\n+\t\t\t}\n+\t\t\tret = rte_eth_rx_queue_setup(res->port_id,\n+\t\t\t\t\t\t res->queue_idx,\n+\t\t\t\t\t\t res->ring_size,\n+\t\t\t\t\t\t rxring_numa[res->port_id],\n+\t\t\t\t\t\t &(port->rx_conf),\n+\t\t\t\t\t\t mp);\n+\t\t} else {\n+\t\t\tmp = mbuf_pool_find(port->socket_id);\n+\t\t\tif (mp == NULL) {\n+\t\t\t\tprintf(\"Failed to setup RX queue:\"\n+\t\t\t\t\t\"No mempool allocation\"\n+\t\t\t\t\t\" on the socket %d\\n\",\n+\t\t\t\t\tport->socket_id);\n+\t\t\t\treturn;\n+\t\t\t}\n+\t\t\tret = rte_eth_rx_queue_setup(res->port_id,\n+\t\t\t\t\t\t res->queue_idx,\n+\t\t\t\t\t\t res->ring_size,\n+\t\t\t\t\t\t port->socket_id,\n+\t\t\t\t\t\t &(port->rx_conf),\n+\t\t\t\t\t\t mp);\n+\t\t}\n+\t\tif (ret)\n+\t\t\tprintf(\"Failed to setup RX queue\\n\");\n+\t} else {\n+\t\tif ((numa_support) &&\n+\t\t\t(txring_numa[res->port_id] != NUMA_NO_CONFIG))\n+\t\t\tret = rte_eth_tx_queue_setup(res->port_id,\n+\t\t\t\t\t\t res->queue_idx,\n+\t\t\t\t\t\t res->ring_size,\n+\t\t\t\t\t\t txring_numa[res->port_id],\n+\t\t\t\t\t\t &(port->tx_conf));\n+\t\telse\n+\t\t\tret = rte_eth_tx_queue_setup(res->port_id,\n+\t\t\t\t\t\t res->queue_idx,\n+\t\t\t\t\t\t res->ring_size,\n+\t\t\t\t\t\t port->socket_id,\n+\t\t\t\t\t\t &(port->tx_conf));\n+\t\tif (ret)\n+\t\t\tprintf(\"Failed to setup TX queue\\n\");\n+\t}\n+}\n+\n+cmdline_parse_inst_t cmd_queue_setup = {\n+\t.f = cmd_queue_setup_parsed,\n+\t.data = NULL,\n+\t.help_str = \"queue setup <rx|tx> <port_id> <queue_idx> <ring_size>\",\n+\t.tokens = {\n+\t\t(void *)&cmd_queue_setup_queue,\n+\t\t(void *)&cmd_queue_setup_setup,\n+\t\t(void *)&cmd_queue_setup_rxtx,\n+\t\t(void *)&cmd_queue_setup_port_id,\n+\t\t(void *)&cmd_queue_setup_queue_idx,\n+\t\t(void *)&cmd_queue_setup_ring_size,\n+\t\tNULL,\n+\t},\n+};\n+\n /* ******************************************************************************** */\n \n /* list of instructions */\n@@ -16272,6 +16407,7 @@ cmdline_parse_ctx_t main_ctx[] = {\n \t(cmdline_parse_inst_t *)&cmd_del_port_tm_node,\n \t(cmdline_parse_inst_t *)&cmd_set_port_tm_node_parent,\n \t(cmdline_parse_inst_t *)&cmd_port_tm_hierarchy_commit,\n+\t(cmdline_parse_inst_t *)&cmd_queue_setup,\n \tNULL,\n };\n \ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex a766ac795..74269cb03 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -1444,6 +1444,13 @@ Reset ptype mapping table::\n \n testpmd> ptype mapping reset (port_id)\n \n+queue setup\n+~~~~~~~~~~~\n+\n+Setup a not started queue or re-setup a started queue::\n+\n+ testpmd> queue setup (rx|tx) (port_id) (queue_idx) (ring_size)\n+\n Port Functions\n --------------\n \n", "prefixes": [ "dpdk-dev", "3/4" ] }