Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35117,
    "url": "http://patches.dpdk.org/api/patches/35117/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1518405628-23976-3-git-send-email-jianfeng.tan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1518405628-23976-3-git-send-email-jianfeng.tan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1518405628-23976-3-git-send-email-jianfeng.tan@intel.com",
    "date": "2018-02-12T03:20:27",
    "name": "[dpdk-dev,2/3] net/virtio-user: fix not working with vhost kernel",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "3d8d0b75f578b2b4b9857815a75acb596d82c7c0",
    "submitter": {
        "id": 313,
        "url": "http://patches.dpdk.org/api/people/313/?format=api",
        "name": "Jianfeng Tan",
        "email": "jianfeng.tan@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1518405628-23976-3-git-send-email-jianfeng.tan@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35117/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35117/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F12481B33B;\n\tMon, 12 Feb 2018 04:18:50 +0100 (CET)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id F06E11B32D;\n\tMon, 12 Feb 2018 04:18:46 +0100 (CET)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Feb 2018 19:18:46 -0800",
            "from dpdk06.sh.intel.com ([10.67.110.196])\n\tby orsmga003.jf.intel.com with ESMTP; 11 Feb 2018 19:18:44 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,499,1511856000\"; d=\"scan'208\";a=\"26853855\"",
        "From": "Jianfeng Tan <jianfeng.tan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yliu@fridaylinux.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n\tJianfeng Tan <jianfeng.tan@intel.com>, stable@dpdk.org",
        "Date": "Mon, 12 Feb 2018 03:20:27 +0000",
        "Message-Id": "<1518405628-23976-3-git-send-email-jianfeng.tan@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1518405628-23976-1-git-send-email-jianfeng.tan@intel.com>",
        "References": "<1518405628-23976-1-git-send-email-jianfeng.tan@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 2/3] net/virtio-user: fix not working with vhost\n\tkernel",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "After reset owner in below patch, we failed to set owner before\nsending further vhost messages. It is OK with vhost user implemented\nDPDK/VPP/Contrail, but it sees \"Operation not permitted\" error when\nused with vhost kernel.\n\nWe fix this by setting owner every time the device is started.\n\nFixes: 0d6a8752ac9d (\"net/virtio-user: fix crash as features change\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 3b5f737..b5809ee 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -99,6 +99,9 @@ virtio_user_start_device(struct virtio_user_dev *dev)\n \tuint64_t features;\n \tint ret;\n \n+\t/* Do not check return as already done in init, or reset in stop */\n+\tdev->ops->send_request(dev, VHOST_USER_SET_OWNER, NULL);\n+\n \t/* Step 0: tell vhost to create queues */\n \tif (virtio_user_queue_setup(dev, virtio_user_create_queue) < 0)\n \t\tgoto error;\n@@ -332,6 +335,7 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n \t\tPMD_INIT_LOG(ERR, \"backend set up fails\");\n \t\treturn -1;\n \t}\n+\n \tif (dev->ops->send_request(dev, VHOST_USER_SET_OWNER, NULL) < 0) {\n \t\tPMD_INIT_LOG(ERR, \"set_owner fails: %s\", strerror(errno));\n \t\treturn -1;\n",
    "prefixes": [
        "dpdk-dev",
        "2/3"
    ]
}