Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35110,
    "url": "http://patches.dpdk.org/api/patches/35110/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1518337772-24763-1-git-send-email-yliu@fridaylinux.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1518337772-24763-1-git-send-email-yliu@fridaylinux.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1518337772-24763-1-git-send-email-yliu@fridaylinux.org",
    "date": "2018-02-11T08:29:32",
    "name": "[dpdk-dev] net/mlx4: use PCI address as port name",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "87ce9513f4a8d5ed503e5ec40fd7a6a82731d783",
    "submitter": {
        "id": 760,
        "url": "http://patches.dpdk.org/api/people/760/?format=api",
        "name": "Yuanhan Liu",
        "email": "yliu@fridaylinux.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1518337772-24763-1-git-send-email-yliu@fridaylinux.org/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35110/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35110/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0954E1B372;\n\tSun, 11 Feb 2018 09:29:39 +0100 (CET)",
            "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n\t[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 96CA81B36D;\n\tSun, 11 Feb 2018 09:29:37 +0100 (CET)",
            "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 0EFDC20D6C;\n\tSun, 11 Feb 2018 03:29:37 -0500 (EST)",
            "from frontend2 ([10.202.2.161])\n\tby compute1.internal (MEProxy); Sun, 11 Feb 2018 03:29:37 -0500",
            "from yliu-mob.mtl.com (unknown [115.150.101.1])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id C42D224108;\n\tSun, 11 Feb 2018 03:29:34 -0500 (EST)"
        ],
        "DKIM-Signature": [
            "v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org;\n\th=cc:date:from:message-id:subject:to:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=tCaWFkn88ZkrakFKXVJgfVzztc6QW0z5wc9rmLk8Q\n\t2U=; b=K30gkeOZ/29au9wF/iaMR5n1+Ij1TkQoKQ29WSFOgXIlq3bsxWUY0UUY8\n\t2Qrotn/Q/KkEY4opsngrGE6C7Kx4BDz0seQqQJG+JN/PzLzAbywyuZy9YnzPrmgM\n\txWtBQVnXesAfIuSfMpLaZvIPtddaWhS9bZhsEPvUVALoKXlo+RbD3A7dXbLhG83K\n\txppJx56GXjsyu7ilXQGpmmZaUzt60gsdoPYeFcIyW40OcWVW/+ii7QnBsEbY/Z26\n\t6mKnuQqXLf72aaYHCLAwkMMmCsJJyuUHnM/qdz2ykFJy/kPRocqbmufQYias/P+4\n\t0H3RIuIiGZzDUFhEGqDxZmWG/1Haw==",
            "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tCaWFkn88ZkrakFKX\n\tVJgfVzztc6QW0z5wc9rmLk8Q2U=; b=dA+CvpVkFJqq8EuJsdXWkhYUZqoBFMOWD\n\tfRODS/pk7Rr9mkHqL9rtG0twlsmmdEWC0yvl/FfdtIPrmLee6yBVrrFqsU9thPZC\n\tXIvjY4lw215zpOxTYNOWzacECbq9eX8rk26U91xahNrOXqN/as3gWYkP3Xy203gT\n\tcNF9KXMGYNTJxGqWSp/xOPrR+m0bOLBQdpCZpIkOjIS31oyJOmm5SxFlT8Jb9U0b\n\tslzDzyNcRE3ON04ybMV0FQkbVlfxxdXYM9R+Skf8Amo6NeOwrUMZdqZwJ43coB7N\n\tiRgLZ2G9AfRSb0dODfVhpcLb9to3ng2TC65ZyyoY/i1KD6DK1jUEg=="
        ],
        "X-ME-Sender": "<xms:8P5_Wuldh36TOJfO01FGORBg0Qy2MN8577y1Gv8OQuLWKw40PSRrHQ>",
        "From": "Yuanhan Liu <yliu@fridaylinux.org>",
        "To": "dev@dpdk.org",
        "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tNelio Laranjeiro <nelio.laranjeiro@6wind.com>,\n\tYongseok Koh <yskoh@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, \n\tYuanhan Liu <yliu@fridaylinux.org>, stable@dpdk.org",
        "Date": "Sun, 11 Feb 2018 16:29:32 +0800",
        "Message-Id": "<1518337772-24763-1-git-send-email-yliu@fridaylinux.org>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] net/mlx4: use PCI address as port name",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "It is suggested to use PCI BDF to identify a port for port addition\nin OVS-DPDK. While mlx5 has its own naming style: name it by ib dev\nname. This breaks the typical OVS DPDK use case and brings more puzzle\nto the end users.\n\nTo fix it, this patch changes it to use PCI BDF as the name, too.\nJudging the fact that there are 2 ports associated with one PCI for\nConnectX-3, a postfix is needed. Thus, the final name looks like\nsomething below:\n\n    0000:04:00.0-port0\n    0000:04:00.0-port1\n\nCc: stable@dpdk.org\nSigned-off-by: Yuanhan Liu <yliu@fridaylinux.org>\n---\n drivers/net/mlx4/mlx4.c | 17 +++++++++--------\n 1 file changed, 9 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex ee93daf..eb8851c 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -497,6 +497,14 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\tstruct priv *priv = NULL;\n \t\tstruct rte_eth_dev *eth_dev = NULL;\n \t\tstruct ether_addr mac;\n+\t\tchar name[RTE_ETH_NAME_MAX_LEN];\n+\t\tint len;\n+\n+\t\tlen = snprintf(name, sizeof(name), PCI_PRI_FMT,\n+\t\t\t pci_dev->addr.domain, pci_dev->addr.bus,\n+\t\t\t pci_dev->addr.devid, pci_dev->addr.function);\n+\t\tif (device_attr.phys_port_cnt > 1)\n+\t\t\tsnprintf(name + len, sizeof(name), \"-port%u\", i);\n \n \t\t/* If port is not enabled, skip. */\n \t\tif (!(conf.ports.enabled & (1 << i)))\n@@ -605,14 +613,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\t/* Get actual MTU if possible. */\n \t\tmlx4_mtu_get(priv, &priv->mtu);\n \t\tDEBUG(\"port %u MTU is %u\", priv->port, priv->mtu);\n-\t\t/* from rte_ethdev.c */\n-\t\t{\n-\t\t\tchar name[RTE_ETH_NAME_MAX_LEN];\n-\n-\t\t\tsnprintf(name, sizeof(name), \"%s port %u\",\n-\t\t\t\t mlx4_glue->get_device_name(ibv_dev), port);\n-\t\t\teth_dev = rte_eth_dev_allocate(name);\n-\t\t}\n+\t\teth_dev = rte_eth_dev_allocate(name);\n \t\tif (eth_dev == NULL) {\n \t\t\tERROR(\"can not allocate rte ethdev\");\n \t\t\trte_errno = ENOMEM;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}