Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35094,
    "url": "http://patches.dpdk.org/api/patches/35094/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180209171049.7132-1-tomaszx.kulasek@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180209171049.7132-1-tomaszx.kulasek@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180209171049.7132-1-tomaszx.kulasek@intel.com",
    "date": "2018-02-09T17:10:49",
    "name": "[dpdk-dev] vhost: fix close callfd on get vring base",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "26eb22b3f3bcbf8d7c0d174a1405c1d1702cef68",
    "submitter": {
        "id": 155,
        "url": "http://patches.dpdk.org/api/people/155/?format=api",
        "name": "Tomasz Kulasek",
        "email": "tomaszx.kulasek@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180209171049.7132-1-tomaszx.kulasek@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35094/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35094/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 00D161B849;\n\tFri,  9 Feb 2018 18:12:21 +0100 (CET)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id C4A5F1B846;\n\tFri,  9 Feb 2018 18:12:18 +0100 (CET)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Feb 2018 09:12:05 -0800",
            "from unknown (HELO Sent) ([10.103.103.74])\n\tby fmsmga001.fm.intel.com with SMTP; 09 Feb 2018 09:12:03 -0800",
            "by Sent (sSMTP sendmail emulation); Fri, 09 Feb 2018 18:10:59 +0100"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,483,1511856000\"; d=\"scan'208\";a=\"29525440\"",
        "From": "Tomasz Kulasek <tomaszx.kulasek@intel.com>",
        "To": "yliu@fridaylinux.org",
        "Cc": "dev@dpdk.org, huawei.xie@intel.com, stable@dpdk.org,\n\tDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>",
        "Date": "Fri,  9 Feb 2018 18:10:49 +0100",
        "Message-Id": "<20180209171049.7132-1-tomaszx.kulasek@intel.com>",
        "X-Mailer": "git-send-email 2.12.3",
        "Subject": "[dpdk-dev] [PATCH] vhost: fix close callfd on get vring base",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This prevents from destroying & recreating user device in \"incomplete\"\nvring state. virtio_is_ready() was returning true for devices with\nvrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL\nhasn't arrived yet)\n\nFixes: 8f972312b8f4 (\"vhost: support vhost-user\")\nCc: huawei.xie@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>\nSigned-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>\n---\n lib/librte_vhost/vhost_user.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 65ee33919..dd8682c09 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -897,6 +897,11 @@ vhost_user_get_vring_base(struct virtio_net *dev,\n \n \tvq->kickfd = VIRTIO_UNINITIALIZED_EVENTFD;\n \n+\tif (vq->callfd >= 0)\n+\t\tclose(vq->callfd);\n+\n+\tvq->callfd = VIRTIO_UNINITIALIZED_EVENTFD;\n+\n \tif (dev->dequeue_zero_copy)\n \t\tfree_zmbufs(vq);\n \trte_free(vq->shadow_used_ring);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}